herunkang2018 commented on code in PR #3303:
URL: https://github.com/apache/calcite/pull/3303#discussion_r1284954381
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -6618,6 +6618,64 @@ private static void checkIf(SqlOperatorFixture f) {
sonarcloud[bot] commented on PR #3289:
URL: https://github.com/apache/calcite/pull/3289#issuecomment-1666358473
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #3348:
URL: https://github.com/apache/calcite/pull/3348#issuecomment-1665838994
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #3348:
URL: https://github.com/apache/calcite/pull/3348#issuecomment-1665807134
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #3348:
URL: https://github.com/apache/calcite/pull/3348#issuecomment-1665776512
Please retry analysis of this Pull-Request directly on
[SonarCloud](https://sonarcloud.io/project/issues?id=apache_calcite=3348).
--
This is an automated message from the
sonarcloud[bot] commented on PR #3348:
URL: https://github.com/apache/calcite/pull/3348#issuecomment-1665774214
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
chucheng92 opened a new pull request, #3348:
URL: https://github.com/apache/calcite/pull/3348
# What is the purpose of the change
current mysql soundex has 2 different behaviors with actual mysql soundex.
1: mysql soundex return arbitrarily long string
current in calcite:
Rajeshwari4 closed pull request #3347: Support for INTERVAL WEEK
URL: https://github.com/apache/calcite/pull/3347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Rajeshwari4 closed pull request #3347: Support for INTERVAL WEEK
URL: https://github.com/apache/calcite/pull/3347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Rajeshwari4 opened a new pull request, #3347:
URL: https://github.com/apache/calcite/pull/3347
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
stoty commented on PR #224:
URL: https://github.com/apache/calcite-avatica/pull/224#issuecomment-1665410309
I have added a test @snuyanzin.
It's not a full end to end crypto test, but it does cover the few new lines
where we configure the HTTP client object.
It turns out that
herunkang2018 commented on PR #3303:
URL: https://github.com/apache/calcite/pull/3303#issuecomment-1665337003
@tanclary I will check it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
LakeShen commented on PR #3337:
URL: https://github.com/apache/calcite/pull/3337#issuecomment-1665317090
could anyone else give me some review suggestions? Thank you very much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
stoty commented on PR #224:
URL: https://github.com/apache/calcite-avatica/pull/224#issuecomment-1665281770
There is no easy way to do that.
Without a lot of effort, I could add a test where I specify "JKS" (the
default), and another one where I specify a non-existent one, and check that
snuyanzin commented on PR #224:
URL: https://github.com/apache/calcite-avatica/pull/224#issuecomment-1665208653
Thanks for the PR
it looks ok from my side
The only thing I wonder is whether there is an easy way to cover it with
tests?
--
This is an automated message from the Apache
This is an automated email from the ASF dual-hosted git repository.
rubenql pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new 98f3048fb1 [CALCITE-5882] Compile-time evaluation
rubenada merged PR #3343:
URL: https://github.com/apache/calcite/pull/3343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
17 matches
Mail list logo