[GitHub] [calcite] sonarcloud[bot] commented on pull request #3352: [CALCITE-5184] Core parser allow "LIMIT start, ALL"

sonarcloud[bot] commented on PR #3352: URL: https://github.com/apache/calcite/pull/3352#issuecomment-1668870237 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3355: [CALCITE-5893] Wrong NULL operand behavior of ARRAY_CONTAINS/ARRAY_EXCEPT/ARRAY_INTERSECT In Spark Library

sonarcloud[bot] commented on PR #3355: URL: https://github.com/apache/calcite/pull/3355#issuecomment-1668840919 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3355: [CALCITE-5893] Wrong NULL operand behavior of ARRAY_CONTAINS/ARRAY_EXCEPT/ARRAY_INTERSECT In Spark Library

sonarcloud[bot] commented on PR #3355: URL: https://github.com/apache/calcite/pull/3355#issuecomment-1668839970 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] chucheng92 opened a new pull request, #3355: [CALCITE-5893] Wrong NULL literal behavior of ARRAY_CONTAINS/ARRAY_EXCEPT/ARRAY_INTERSECT In Spark Library

chucheng92 opened a new pull request, #3355: URL: https://github.com/apache/calcite/pull/3355 https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-5893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3314: [CALCITE-5843] Constant expression with nested casts causes a compiler crash

sonarcloud[bot] commented on PR #3314: URL: https://github.com/apache/calcite/pull/3314#issuecomment-1668680321 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] walterddr commented on pull request #3288: [CALCITE-5740] support aggregate semi-join rule

walterddr commented on PR #3288: URL: https://github.com/apache/calcite/pull/3288#issuecomment-1668663566 @chunweilei could you share any additional follow up comments or if this is ready for merge? thanks -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3314: [CALCITE-5843] Constant expression with nested casts causes a compiler crash

sonarcloud[bot] commented on PR #3314: URL: https://github.com/apache/calcite/pull/3314#issuecomment-1668643924 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] mihaibudiu commented on pull request #3314: [CALCITE-5843] Constant expression with nested casts causes a compiler crash

mihaibudiu commented on PR #3314: URL: https://github.com/apache/calcite/pull/3314#issuecomment-1668635096 @rubenada hopefully I have addressed your comments. The commits are already squashed. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3303: [CALCITE-5827] Add IS_INF and IS_NAN functions (enabled in BigQuery l…

sonarcloud[bot] commented on PR #3303: URL: https://github.com/apache/calcite/pull/3303#issuecomment-1668223737 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] tanclary commented on pull request #3303: [CALCITE-5827] Add IS_INF and IS_NAN functions (enabled in BigQuery l…

tanclary commented on PR #3303: URL: https://github.com/apache/calcite/pull/3303#issuecomment-1668224893 @herunkang2018 Could you elaborate on your comment about the decimal testing? is that blocking this PR? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] tanclary commented on pull request #3336: [CALCITE-5869] LEAST_RESTRICTIVE does not use inner type of MEASURE f…

tanclary commented on PR #3336: URL: https://github.com/apache/calcite/pull/3336#issuecomment-1668222785 @tjbanghart @julianhyde Do either of you have additional comments? Thanks for your suggestions so far! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3336: [CALCITE-5869] LEAST_RESTRICTIVE does not use inner type of MEASURE f…

sonarcloud[bot] commented on PR #3336: URL: https://github.com/apache/calcite/pull/3336#issuecomment-1668192965 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] tanclary commented on a diff in pull request #3147: [CALCITE-5644] Add CONTAINS_SUBSTR function (enabled in BigQuery library)

tanclary commented on code in PR #3147: URL: https://github.com/apache/calcite/pull/3147#discussion_r1286109761 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -562,6 +564,91 @@ public static List split(ByteString s, ByteString delimiter) { }

[GitHub] [calcite] tanclary commented on a diff in pull request #3147: [CALCITE-5644] Add CONTAINS_SUBSTR function (enabled in BigQuery library)

tanclary commented on code in PR #3147: URL: https://github.com/apache/calcite/pull/3147#discussion_r1286109962 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -562,6 +564,91 @@ public static List split(ByteString s, ByteString delimiter) { }

[GitHub] [calcite] tanclary commented on a diff in pull request #3303: [CALCITE-5827] Add IS_INF and IS_NAN functions (enabled in BigQuery l…

tanclary commented on code in PR #3303: URL: https://github.com/apache/calcite/pull/3303#discussion_r1286101447 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -6618,6 +6618,64 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] rubenada commented on a diff in pull request #3314: [CALCITE-5843] Prevent crash during evaluation of constant expressions in linq4j

rubenada commented on code in PR #3314: URL: https://github.com/apache/calcite/pull/3314#discussion_r1286101426 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -687,6 +687,17 @@ void testCastToExactNumeric(CastType castType, SqlOperatorFixture f) {

[GitHub] [calcite] rubenada commented on a diff in pull request #3314: [CALCITE-5843] Prevent crash during evaluation of constant expressions in linq4j

rubenada commented on code in PR #3314: URL: https://github.com/apache/calcite/pull/3314#discussion_r1286100494 ## linq4j/src/main/java/org/apache/calcite/linq4j/tree/Expressions.java: ## @@ -570,7 +570,37 @@ public static ConstantExpression constant(@Nullable Object value,

[GitHub] [calcite] rubenada commented on a diff in pull request #3314: [CALCITE-5843] Prevent crash during evaluation of constant expressions in linq4j

rubenada commented on code in PR #3314: URL: https://github.com/apache/calcite/pull/3314#discussion_r1286096496 ## linq4j/src/main/java/org/apache/calcite/linq4j/tree/Expressions.java: ## @@ -570,7 +570,37 @@ public static ConstantExpression constant(@Nullable Object value,

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3354: [CALCITE-5904] The result should be empty list when table sample rate is 0

sonarcloud[bot] commented on PR #3354: URL: https://github.com/apache/calcite/pull/3354#issuecomment-1668138384 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] LakeShen opened a new pull request, #3354: [CALCITE-5904] The result should be empty list when table sample rate is 0

LakeShen opened a new pull request, #3354: URL: https://github.com/apache/calcite/pull/3354 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [calcite] LakeShen commented on pull request #3345: [CALCITE-5881] Support to get foreign keys metadata in RelMetadataQuery

LakeShen commented on PR #3345: URL: https://github.com/apache/calcite/pull/3345#issuecomment-1668059287 Another point,Do you need add a class GeneratedMetadata_ForeignXXX like GeneratedMetadata_CollationHandler.java?

[GitHub] [calcite] LakeShen commented on pull request #3353: [CALCITE-5903] RelMdCollation does not define collations for EnumerableLimit

LakeShen commented on PR #3353: URL: https://github.com/apache/calcite/pull/3353#issuecomment-1668053040 The PR looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3353: [CALCITE-5903] RelMdCollation does not define collations for EnumerableLimit

sonarcloud[bot] commented on PR #3353: URL: https://github.com/apache/calcite/pull/3353#issuecomment-1667988795 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] rubenada opened a new pull request, #3353: [CALCITE-5903] RelMdCollation does not define collations for EnumerableLimit

rubenada opened a new pull request, #3353: URL: https://github.com/apache/calcite/pull/3353 Jira: CALCITE-5903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3352: [CALCITE-5184] Core parser allow "LIMIT start, ALL"

sonarcloud[bot] commented on PR #3352: URL: https://github.com/apache/calcite/pull/3352#issuecomment-1667926843 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] macroguo-ghy opened a new pull request, #3352: [CALCITE-5184] Core parser allow "LIMIT start, ALL"

macroguo-ghy opened a new pull request, #3352: URL: https://github.com/apache/calcite/pull/3352 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [calcite] LakeShen commented on a diff in pull request #3345: [CALCITE-5881] Support to get foreign keys metadata in RelMetadataQuery

LakeShen commented on code in PR #3345: URL: https://github.com/apache/calcite/pull/3345#discussion_r1285783800 ## core/src/test/java/org/apache/calcite/test/RelMetadataTest.java: ## @@ -971,6 +989,1025 @@ final RelMetadataFixture sql(String sql) { is(1D)); }

[GitHub] [calcite] LakeShen commented on a diff in pull request #3345: [CALCITE-5881] Support to get foreign keys metadata in RelMetadataQuery

LakeShen commented on code in PR #3345: URL: https://github.com/apache/calcite/pull/3345#discussion_r1285777370 ## core/src/main/java/org/apache/calcite/plan/RelOptForeignKey.java: ## @@ -0,0 +1,411 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [calcite] LakeShen commented on a diff in pull request #3345: [CALCITE-5881] Support to get foreign keys metadata in RelMetadataQuery

LakeShen commented on code in PR #3345: URL: https://github.com/apache/calcite/pull/3345#discussion_r1285776926 ## core/src/main/java/org/apache/calcite/plan/RelOptForeignKey.java: ## @@ -0,0 +1,411 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [calcite] LakeShen commented on a diff in pull request #3345: [CALCITE-5881] Support to get foreign keys metadata in RelMetadataQuery

LakeShen commented on code in PR #3345: URL: https://github.com/apache/calcite/pull/3345#discussion_r1285772183 ## testkit/src/main/java/org/apache/calcite/test/RelMetadataFixture.java: ## @@ -264,6 +265,18 @@ public RelMetadataFixture assertPercentageOriginalRows(Matcher

[GitHub] [calcite] LakeShen commented on a diff in pull request #3345: [CALCITE-5881] Support to get foreign keys metadata in RelMetadataQuery

LakeShen commented on code in PR #3345: URL: https://github.com/apache/calcite/pull/3345#discussion_r1285772183 ## testkit/src/main/java/org/apache/calcite/test/RelMetadataFixture.java: ## @@ -264,6 +265,18 @@ public RelMetadataFixture assertPercentageOriginalRows(Matcher

[GitHub] [calcite] LakeShen commented on a diff in pull request #3345: [CALCITE-5881] Support to get foreign keys metadata in RelMetadataQuery

LakeShen commented on code in PR #3345: URL: https://github.com/apache/calcite/pull/3345#discussion_r1285767798 ## core/src/main/java/org/apache/calcite/plan/RelOptForeignKey.java: ## @@ -0,0 +1,411 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [calcite] LakeShen commented on a diff in pull request #3345: [CALCITE-5881] Support to get foreign keys metadata in RelMetadataQuery

LakeShen commented on code in PR #3345: URL: https://github.com/apache/calcite/pull/3345#discussion_r1285766949 ## core/src/main/java/org/apache/calcite/plan/RelOptForeignKey.java: ## @@ -0,0 +1,411 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [calcite] LakeShen commented on a diff in pull request #3345: [CALCITE-5881] Support to get foreign keys metadata in RelMetadataQuery

LakeShen commented on code in PR #3345: URL: https://github.com/apache/calcite/pull/3345#discussion_r1285764802 ## core/src/main/java/org/apache/calcite/plan/RelOptForeignKey.java: ## @@ -0,0 +1,411 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [calcite] LakeShen commented on a diff in pull request #3345: [CALCITE-5881] Support to get foreign keys metadata in RelMetadataQuery

LakeShen commented on code in PR #3345: URL: https://github.com/apache/calcite/pull/3345#discussion_r1285763589 ## core/src/main/java/org/apache/calcite/rel/metadata/BuiltInMetadata.java: ## @@ -105,6 +106,43 @@ interface Handler extends MetadataHandler { } } + /** +

[GitHub] [calcite] LakeShen commented on a diff in pull request #3345: [CALCITE-5881] Support to get foreign keys metadata in RelMetadataQuery

LakeShen commented on code in PR #3345: URL: https://github.com/apache/calcite/pull/3345#discussion_r1285760940 ## core/src/main/java/org/apache/calcite/plan/RelOptForeignKey.java: ## @@ -0,0 +1,411 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [calcite] LakeShen commented on a diff in pull request #3345: [CALCITE-5881] Support to get foreign keys metadata in RelMetadataQuery

LakeShen commented on code in PR #3345: URL: https://github.com/apache/calcite/pull/3345#discussion_r1285760940 ## core/src/main/java/org/apache/calcite/plan/RelOptForeignKey.java: ## @@ -0,0 +1,411 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [calcite] LakeShen commented on a diff in pull request #3345: [CALCITE-5881] Support to get foreign keys metadata in RelMetadataQuery

LakeShen commented on code in PR #3345: URL: https://github.com/apache/calcite/pull/3345#discussion_r1285755688 ## core/src/main/java/org/apache/calcite/rel/metadata/BuiltInMetadata.java: ## @@ -105,6 +106,43 @@ interface Handler extends MetadataHandler { } } + /** +

[GitHub] [calcite] LakeShen commented on a diff in pull request #3345: [CALCITE-5881] Support to get foreign keys metadata in RelMetadataQuery

LakeShen commented on code in PR #3345: URL: https://github.com/apache/calcite/pull/3345#discussion_r1285753858 ## core/src/main/java/org/apache/calcite/rel/metadata/BuiltInMetadata.java: ## @@ -105,6 +106,43 @@ interface Handler extends MetadataHandler { } } + /** +

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3351: [CALCITE-5899] Add HAMMING_DISTANCE function (enabled in Presto Library)

sonarcloud[bot] commented on PR #3351: URL: https://github.com/apache/calcite/pull/3351#issuecomment-1667701773 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] LakeShen commented on a diff in pull request #3345: [CALCITE-5881] Support to get foreign keys metadata in RelMetadataQuery

LakeShen commented on code in PR #3345: URL: https://github.com/apache/calcite/pull/3345#discussion_r1285753858 ## core/src/main/java/org/apache/calcite/rel/metadata/BuiltInMetadata.java: ## @@ -105,6 +106,43 @@ interface Handler extends MetadataHandler { } } + /** +

[GitHub] [calcite] LakeShen commented on a diff in pull request #3345: [CALCITE-5881] Support to get foreign keys metadata in RelMetadataQuery

LakeShen commented on code in PR #3345: URL: https://github.com/apache/calcite/pull/3345#discussion_r1285749110 ## core/src/main/java/org/apache/calcite/plan/RelOptForeignKey.java: ## @@ -0,0 +1,411 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [calcite] chucheng92 commented on pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on PR #3320: URL: https://github.com/apache/calcite/pull/3320#issuecomment-1667627032 @NobiGo hi, I have solved all your comments. If you have time, pls help to re-check it. thank you. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1285699097 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

sonarcloud[bot] commented on PR #3320: URL: https://github.com/apache/calcite/pull/3320#issuecomment-1667588055 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

sonarcloud[bot] commented on PR #3320: URL: https://github.com/apache/calcite/pull/3320#issuecomment-1667566829 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1285651475 ## site/_docs/reference.md: ## @@ -2658,6 +2658,7 @@ BigQuery's type system uses confusingly different names for types and functions: | s | ARRAY_CONTAINS(array,

[calcite-avatica] branch main updated (2736c2795 -> db4cd704a)

This is an automated email from the ASF dual-hosted git repository. stoty pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git from 2736c2795 [CALCITE-5748] Support Guava 32.1.1-jre add db4cd704a [CALCITE-5890] Handle non-JKS truststores

[GitHub] [calcite-avatica] stoty closed pull request #224: [CALCITE-5890] Handle non-JKS truststores in Avatica client

stoty closed pull request #224: [CALCITE-5890] Handle non-JKS truststores in Avatica client URL: https://github.com/apache/calcite-avatica/pull/224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3351: [CALCITE-5899] Add HAMMING_DISTANCE function (enabled in Presto Library)

sonarcloud[bot] commented on PR #3351: URL: https://github.com/apache/calcite/pull/3351#issuecomment-1667413813 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] macroguo-ghy opened a new pull request, #3351: [CALCITE-5899] Add HAMMING_DISTANCE function (enabled in Presto Library)

macroguo-ghy opened a new pull request, #3351: URL: https://github.com/apache/calcite/pull/3351 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [calcite-avatica] stoty commented on pull request #224: [CALCITE-5890] Handle non-JKS truststores in Avatica client

stoty commented on PR #224: URL: https://github.com/apache/calcite-avatica/pull/224#issuecomment-1667363989 Is this test sufficient, @snuyanzin ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [calcite] NobiGo commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

NobiGo commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1285482457 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return new