[GitHub] [calcite] sonarcloud[bot] commented on pull request #3289: [CALCITE-5813] Type inference for sql functions REPEAT, SPACE, XML_TRANSFORM, and XML_EXTRACT is incorrect

2023-08-11 Thread via GitHub
sonarcloud[bot] commented on PR #3289: URL: https://github.com/apache/calcite/pull/3289#issuecomment-1675722178 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] julianhyde closed pull request #3352: [CALCITE-5184] Support "LIMIT start, ALL" in SQL Parser

2023-08-11 Thread via GitHub
julianhyde closed pull request #3352: [CALCITE-5184] Support "LIMIT start, ALL" in SQL Parser URL: https://github.com/apache/calcite/pull/3352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[calcite] 02/02: [CALCITE-5184] Support "LIMIT start, ALL" in MySQL conformance, equivalent to "OFFSET start"

2023-08-11 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git commit 161e220384dfbd85f896a95cac40cca23141583e Author: macroguo AuthorDate: Mon Aug 7 21:46:24 2023 +0800 [CALCITE-5184]

[calcite] 01/02: [CALCITE-5908] Refactor: Remove unnecessary null checks in CalciteSchema

2023-08-11 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git commit 6b750b8e9b44e644d9073d908c384307b4aa7e2c Author: Ran Tao AuthorDate: Tue Aug 8 23:29:15 2023 +0800 [CALCITE-5908]

[calcite] branch main updated (bde9110ca6 -> 161e220384)

2023-08-11 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git from bde9110ca6 [CALCITE-5843] Constant expression with nested casts causes a compiler crash new 6b750b8e9b

[GitHub] [calcite] julianhyde commented on a diff in pull request #3338: [CALCITE-5873] Add REGEXP_CONTAINS function (enabled in BigQuery library)

2023-08-11 Thread via GitHub
julianhyde commented on code in PR #3338: URL: https://github.com/apache/calcite/pull/3338#discussion_r1291828491 ## site/_docs/reference.md: ## @@ -2776,6 +2776,7 @@ BigQuery's type system uses confusingly different names for types and functions: | b |

[GitHub] [calcite] Anthrino commented on a diff in pull request #3338: [CALCITE-5873] Add REGEXP_CONTAINS function (enabled in BigQuery library)

2023-08-11 Thread via GitHub
Anthrino commented on code in PR #3338: URL: https://github.com/apache/calcite/pull/3338#discussion_r1291725341 ## core/src/test/java/org/apache/calcite/test/SqlFunctionsTest.java: ## @@ -234,6 +235,34 @@ static List list() { assertThat(posixRegex("abcq", "[[:xdigit:]]",

[GitHub] [calcite] Anthrino commented on a diff in pull request #3338: [CALCITE-5873] Add REGEXP_CONTAINS function (enabled in BigQuery library)

2023-08-11 Thread via GitHub
Anthrino commented on code in PR #3338: URL: https://github.com/apache/calcite/pull/3338#discussion_r1291720323 ## site/_docs/reference.md: ## @@ -2776,6 +2776,7 @@ BigQuery's type system uses confusingly different names for types and functions: | b | PARSE_TIMESTAMP(format,

[GitHub] [calcite] Anthrino commented on a diff in pull request #3338: [CALCITE-5873] Add REGEXP_CONTAINS function (enabled in BigQuery library)

2023-08-11 Thread via GitHub
Anthrino commented on code in PR #3338: URL: https://github.com/apache/calcite/pull/3338#discussion_r1291719259 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -401,6 +402,16 @@ private static int makeRegexpFlags(@Nullable String stringFlags) {

[GitHub] [calcite] rubenada merged pull request #3314: [CALCITE-5843] Constant expression with nested casts causes a compiler crash

2023-08-11 Thread via GitHub
rubenada merged PR #3314: URL: https://github.com/apache/calcite/pull/3314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[calcite] branch main updated: [CALCITE-5843] Constant expression with nested casts causes a compiler crash

2023-08-11 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new bde9110ca6 [CALCITE-5843] Constant expression

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-11 Thread via GitHub
chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1291653062 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,93 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-11 Thread via GitHub
sonarcloud[bot] commented on PR #3320: URL: https://github.com/apache/calcite/pull/3320#issuecomment-1675186569 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-11 Thread via GitHub
chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1291653062 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,93 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-11 Thread via GitHub
chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1291653062 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,93 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3314: [CALCITE-5843] Constant expression with nested casts causes a compiler crash

2023-08-11 Thread via GitHub
sonarcloud[bot] commented on PR #3314: URL: https://github.com/apache/calcite/pull/3314#issuecomment-1675156286 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-11 Thread via GitHub
sonarcloud[bot] commented on PR #3320: URL: https://github.com/apache/calcite/pull/3320#issuecomment-1675146179 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] mihaibudiu commented on pull request #3314: [CALCITE-5843] Constant expression with nested casts causes a compiler crash

2023-08-11 Thread via GitHub
mihaibudiu commented on PR #3314: URL: https://github.com/apache/calcite/pull/3314#issuecomment-1675128959 > @mihaibudiu I think we can move on and merge this patch. One final detail, could you please amend the commit message so that it starts with the ticket number? `[CALCITE-5843] ...`

[GitHub] [calcite] mihaibudiu commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-11 Thread via GitHub
mihaibudiu commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1291609059 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,93 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-11 Thread via GitHub
chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1291604326 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,93 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-11 Thread via GitHub
chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1291604759 ## site/_docs/reference.md: ## @@ -2658,6 +2658,7 @@ BigQuery's type system uses confusingly different names for types and functions: | s | ARRAY_CONTAINS(array,

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-11 Thread via GitHub
chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1291604326 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,93 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3360: [CALCITE-5895] TABLESAMPLE(0) should return empty result

2023-08-11 Thread via GitHub
sonarcloud[bot] commented on PR #3360: URL: https://github.com/apache/calcite/pull/3360#issuecomment-1674677409 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] NobiGo commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

2023-08-11 Thread via GitHub
NobiGo commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1291249025 ## core/src/main/java/org/apache/calcite/util/BuiltInMethod.java: ## @@ -658,6 +658,7 @@ public enum BuiltInMethod { ARRAYS_OVERLAP(SqlFunctions.class,

[GitHub] [calcite] divyanshuS27 commented on a diff in pull request #2813: [CALCITE-5127] Error when executing query with subquery in select lis…

2023-08-11 Thread via GitHub
divyanshuS27 commented on code in PR #2813: URL: https://github.com/apache/calcite/pull/2813#discussion_r1291131899 ## mongodb/src/main/java/org/apache/calcite/adapter/mongodb/MongoProject.java: ## @@ -57,8 +58,7 @@ public MongoProject(RelOptCluster cluster, RelTraitSet

[GitHub] [calcite] divyanshuS27 commented on a diff in pull request #2813: [CALCITE-5127] Error when executing query with subquery in select lis…

2023-08-11 Thread via GitHub
divyanshuS27 commented on code in PR #2813: URL: https://github.com/apache/calcite/pull/2813#discussion_r1291131899 ## mongodb/src/main/java/org/apache/calcite/adapter/mongodb/MongoProject.java: ## @@ -57,8 +58,7 @@ public MongoProject(RelOptCluster cluster, RelTraitSet

[GitHub] [calcite] LakeShen commented on pull request #3360: [CALCITE-5895] TABLESAMPLE(0) should return empty result

2023-08-11 Thread via GitHub
LakeShen commented on PR #3360: URL: https://github.com/apache/calcite/pull/3360#issuecomment-1674410385 Hi @julianhyde @JiajunBernoulli ,I have modified the code according to the suggestion. If you have time, please help me review it again. If there is no problem, maybe we could merge

[GitHub] [calcite] LakeShen commented on a diff in pull request #3360: [CALCITE-5895] TABLESAMPLE(0) should return empty result

2023-08-11 Thread via GitHub
LakeShen commented on code in PR #3360: URL: https://github.com/apache/calcite/pull/3360#discussion_r1291003656 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -1104,6 +1104,16 @@ private SqlNode validateScopedExpression( List operands

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3360: [CALCITE-5895] TABLESAMPLE(0) should return empty result

2023-08-11 Thread via GitHub
sonarcloud[bot] commented on PR #3360: URL: https://github.com/apache/calcite/pull/3360#issuecomment-1674311084 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] rubenada commented on pull request #3314: [CALCITE-5843] Constant expression with nested casts causes a compiler crash

2023-08-11 Thread via GitHub
rubenada commented on PR #3314: URL: https://github.com/apache/calcite/pull/3314#issuecomment-1674308237 @mihaibudiu I think we can move on and merge this patch. One final detail, could you please amend the commit message so that it starts with the ticket number? `[CALCITE-5843] ...`

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3360: [CALCITE-5895] TABLESAMPLE(0) should return empty result

2023-08-11 Thread via GitHub
sonarcloud[bot] commented on PR #3360: URL: https://github.com/apache/calcite/pull/3360#issuecomment-1674273006 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png