sonarcloud[bot] commented on PR #3399:
URL: https://github.com/apache/calcite/pull/3399#issuecomment-1700326209
Kudos, SonarCloud Quality Gate passed! [ {
}
/** SQL
sonarcloud[bot] commented on PR #3391:
URL: https://github.com/apache/calcite/pull/3391#issuecomment-1699877299
Kudos, SonarCloud Quality Gate passed! [
add 1eb547c93e [CALCITE-5910]
tanclary merged PR #3252:
URL: https://github.com/apache/calcite/pull/3252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tanclary merged PR #3369:
URL: https://github.com/apache/calcite/pull/3369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
tanner pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new 01467a1797 [CALCITE-5766] Add SAFE_NEGATE function
julianhyde commented on PR #3252:
URL: https://github.com/apache/calcite/pull/3252#issuecomment-1699623273
Two cosmetic things in testSafeNegateFunc:
* There are too many '.' in the javadoc. The jira summary does not include
a '.'
* Function arguments should be indented 4, not
sonarcloud[bot] commented on PR #3391:
URL: https://github.com/apache/calcite/pull/3391#issuecomment-1699619469
Kudos, SonarCloud Quality Gate passed! [ {
defineMethod(SPLIT, "split",
Anthrino commented on code in PR #3369:
URL: https://github.com/apache/calcite/pull/3369#discussion_r1310628458
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -4568,6 +4568,25 @@ private static void checkIf(SqlOperatorFixture f) {
Anthrino commented on code in PR #3369:
URL: https://github.com/apache/calcite/pull/3369#discussion_r1310617255
##
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##
@@ -569,6 +570,8 @@ Builder populate() {
defineReflective(PARSE_URL,
tanclary commented on PR #3252:
URL: https://github.com/apache/calcite/pull/3252#issuecomment-1699581435
@julianhyde I rebased to include your recent changes and no longer use
strings to identify the safe functions' methods. Let me know what you think.
--
This is an automated message
tanclary commented on code in PR #3369:
URL: https://github.com/apache/calcite/pull/3369#discussion_r1308036102
##
core/src/test/java/org/apache/calcite/test/SqlFunctionsTest.java:
##
@@ -260,7 +261,75 @@ static List list() {
} catch (RuntimeException e) {
sonarcloud[bot] commented on PR #3252:
URL: https://github.com/apache/calcite/pull/3252#issuecomment-1699529860
Kudos, SonarCloud Quality Gate passed! [ {
final boolean b = f.regexpContains("abc def
tanclary commented on code in PR #3369:
URL: https://github.com/apache/calcite/pull/3369#discussion_r1308035240
##
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##
@@ -554,6 +555,7 @@ Builder populate() {
defineMethod(SPLIT, "split",
tanclary commented on code in PR #3369:
URL: https://github.com/apache/calcite/pull/3369#discussion_r1310567170
##
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##
@@ -569,6 +570,8 @@ Builder populate() {
defineReflective(PARSE_URL,
sonarcloud[bot] commented on PR #3391:
URL: https://github.com/apache/calcite/pull/3391#issuecomment-1699528863
Kudos, SonarCloud Quality Gate passed! [ under one or
sonarcloud[bot] commented on PR #3404:
URL: https://github.com/apache/calcite/pull/3404#issuecomment-1699169038
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
herunkang2018 commented on code in PR #3367:
URL: https://github.com/apache/calcite/pull/3367#discussion_r1308961936
##
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##
@@ -2699,6 +2699,35 @@ private void
sonarcloud[bot] commented on PR #3401:
URL: https://github.com/apache/calcite/pull/3401#issuecomment-1698746657
Kudos, SonarCloud Quality Gate passed! [