[GitHub] [calcite] sonarcloud[bot] commented on pull request #3397: [CALCITE-5836] Implement Rel2Sql for MERGE

2023-09-06 Thread via GitHub
sonarcloud[bot] commented on PR #3397: URL: https://github.com/apache/calcite/pull/3397#issuecomment-1709406924 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3389: [CALCITE-5935] Add CODE_POINTS_TO_BYTES function (enabled in BigQuery…

2023-09-06 Thread via GitHub
sonarcloud[bot] commented on PR #3389: URL: https://github.com/apache/calcite/pull/3389#issuecomment-1709382851 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3382: [CALCITE-5944] Add metadata for Sample

2023-09-06 Thread via GitHub
sonarcloud[bot] commented on PR #3382: URL: https://github.com/apache/calcite/pull/3382#issuecomment-1709365534 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] JiajunBernoulli commented on pull request #3382: [CALCITE-5944] Add metadata for Sample

2023-09-06 Thread via GitHub
JiajunBernoulli commented on PR #3382: URL: https://github.com/apache/calcite/pull/3382#issuecomment-1709363747 Rename `inputRowCount` and rebase `main`. @rubenada Thank you~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] herunkang2018 commented on pull request #3389: [CALCITE-5935] Add CODE_POINTS_TO_BYTES function (enabled in BigQuery…

2023-09-06 Thread via GitHub
herunkang2018 commented on PR #3389: URL: https://github.com/apache/calcite/pull/3389#issuecomment-1709299782 @macroguo-ghy LGTM. Remind that there are some duplicated commits compare to main branch, would you like to rebase from the main branch to fix this? -- This is an automated

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3408: [CALCITE-5978] Add REGEXP_INSTR function (enabled in BigQuery library)

2023-09-06 Thread via GitHub
sonarcloud[bot] commented on PR #3408: URL: https://github.com/apache/calcite/pull/3408#issuecomment-1708895825 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] Anthrino commented on a diff in pull request #3408: [CALCITE-5978] Add REGEXP_INSTR function (enabled in BigQuery library)

2023-09-06 Thread via GitHub
Anthrino commented on code in PR #3408: URL: https://github.com/apache/calcite/pull/3408#discussion_r1317647557 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -488,13 +502,74 @@ public List regexpExtractAll(String value, String regex) {

[GitHub] [calcite] Anthrino commented on a diff in pull request #3408: [CALCITE-5978] Add REGEXP_INSTR function (enabled in BigQuery library)

2023-09-06 Thread via GitHub
Anthrino commented on code in PR #3408: URL: https://github.com/apache/calcite/pull/3408#discussion_r1317644833 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -404,16 +404,39 @@ private Pattern validateRegexPattern(String regex, String methodName) {

[GitHub] [calcite] Anthrino commented on a diff in pull request #3408: [CALCITE-5978] Add REGEXP_INSTR function (enabled in BigQuery library)

2023-09-06 Thread via GitHub
Anthrino commented on code in PR #3408: URL: https://github.com/apache/calcite/pull/3408#discussion_r1317644833 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -404,16 +404,39 @@ private Pattern validateRegexPattern(String regex, String methodName) {

[GitHub] [calcite] Anthrino commented on a diff in pull request #3408: [CALCITE-5978] Add REGEXP_INSTR function (enabled in BigQuery library)

2023-09-06 Thread via GitHub
Anthrino commented on code in PR #3408: URL: https://github.com/apache/calcite/pull/3408#discussion_r1317644115 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -404,16 +404,39 @@ private Pattern validateRegexPattern(String regex, String methodName) {

[GitHub] [calcite] Anthrino commented on a diff in pull request #3408: [CALCITE-5978] Add REGEXP_INSTR function (enabled in BigQuery library)

2023-09-06 Thread via GitHub
Anthrino commented on code in PR #3408: URL: https://github.com/apache/calcite/pull/3408#discussion_r1317637600 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -488,13 +502,74 @@ public List regexpExtractAll(String value, String regex) {

[GitHub] [calcite] tanclary commented on a diff in pull request #3408: [CALCITE-5978] Add REGEXP_INSTR function (enabled in BigQuery library)

2023-09-06 Thread via GitHub
tanclary commented on code in PR #3408: URL: https://github.com/apache/calcite/pull/3408#discussion_r1317629669 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -488,13 +502,74 @@ public List regexpExtractAll(String value, String regex) {

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3408: [CALCITE-5978] Add REGEXP_INSTR function (enabled in BigQuery library)

2023-09-06 Thread via GitHub
sonarcloud[bot] commented on PR #3408: URL: https://github.com/apache/calcite/pull/3408#issuecomment-1708795300 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] tanclary commented on pull request #3389: [CALCITE-5935] Add CODE_POINTS_TO_BYTES function (enabled in BigQuery…

2023-09-06 Thread via GitHub
tanclary commented on PR #3389: URL: https://github.com/apache/calcite/pull/3389#issuecomment-1708722386 @macroguo-ghy yes, would you mind rebasing/squashing down to a final commit? Sorry for any inconvenience and delay in review I have been a bit busy. -- This is an automated message

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3396: [CALCITE-5940] Add the Rules to optimize Limit

2023-09-06 Thread via GitHub
sonarcloud[bot] commented on PR #3396: URL: https://github.com/apache/calcite/pull/3396#issuecomment-1708610510 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

2023-09-06 Thread via GitHub
sonarcloud[bot] commented on PR #3367: URL: https://github.com/apache/calcite/pull/3367#issuecomment-1708586323 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3395: [CALCITE-5948] Explicit casting should be made if the type of an element in ARRAY/MAP not equals with the derived component type

2023-09-06 Thread via GitHub
sonarcloud[bot] commented on PR #3395: URL: https://github.com/apache/calcite/pull/3395#issuecomment-1708446685 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3405: [CALCITE-5961] Type inference of ARRAY_COMPACT is incorrect

2023-09-06 Thread via GitHub
sonarcloud[bot] commented on PR #3405: URL: https://github.com/apache/calcite/pull/3405#issuecomment-1708293514 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3409: [CALCITE-5980] QuidemTests are not effectively executed on Windows

2023-09-06 Thread via GitHub
sonarcloud[bot] commented on PR #3409: URL: https://github.com/apache/calcite/pull/3409#issuecomment-1708135546 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] rubenada opened a new pull request, #3409: [CALCITE-5980] QuidemTests are not effectively executed on Windows

2023-09-06 Thread via GitHub
rubenada opened a new pull request, #3409: URL: https://github.com/apache/calcite/pull/3409 See details in CALCITE-5980 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [calcite] rubenada merged pull request #3403: [CALCITE-5967] UnsupportedOperationException while implementing a call that requires a special collator

2023-09-06 Thread via GitHub
rubenada merged PR #3403: URL: https://github.com/apache/calcite/pull/3403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[calcite] branch main updated: [CALCITE-5967] UnsupportedOperationException while implementing a call that requires a special collator

2023-09-06 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 164ff0a27e [CALCITE-5967]

[calcite] branch main updated: [CALCITE-5952] SemiJoinJoinTransposeRule should check if JoinType supports pushing predicates into its inputs

2023-09-06 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new d667123585 [CALCITE-5952]

[GitHub] [calcite] rubenada merged pull request #3407: [CALCITE-5952] SemiJoinJoinTransposeRule should check if JoinType supports pushing predicates into its inputs

2023-09-06 Thread via GitHub
rubenada merged PR #3407: URL: https://github.com/apache/calcite/pull/3407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3403: [CALCITE-5967] UnsupportedOperationException while implementing a call that requires a special collator

2023-09-06 Thread via GitHub
sonarcloud[bot] commented on PR #3403: URL: https://github.com/apache/calcite/pull/3403#issuecomment-1707873463 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] LeonidChistov commented on pull request #3407: [CALCITE-5952] SemiJoinJoinTransposeRule should check if JoinType supports pushing predicates into its inputs

2023-09-06 Thread via GitHub
LeonidChistov commented on PR #3407: URL: https://github.com/apache/calcite/pull/3407#issuecomment-1707868065 @rubenada Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3407: [CALCITE-5952] SemiJoinJoinTransposeRule should check if JoinType supports pushing predicates into its inputs

2023-09-06 Thread via GitHub
sonarcloud[bot] commented on PR #3407: URL: https://github.com/apache/calcite/pull/3407#issuecomment-1707860662 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3311: [CALCITE-5732] EnumerableHashJoin and EnumerableMergeJoin on composite key return rows matching condition 'null = null'

2023-09-06 Thread via GitHub
sonarcloud[bot] commented on PR #3311: URL: https://github.com/apache/calcite/pull/3311#issuecomment-1707832963 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3403: [CALCITE-5967] UnsupportedOperationException while implementing a call that requires a special collator

2023-09-06 Thread via GitHub
sonarcloud[bot] commented on PR #3403: URL: https://github.com/apache/calcite/pull/3403#issuecomment-1707826919 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] rubenada commented on a diff in pull request #3311: [CALCITE-5732] EnumerableHashJoin and EnumerableMergeJoin on composite key return rows matching condition 'null = null'

2023-09-06 Thread via GitHub
rubenada commented on code in PR #3311: URL: https://github.com/apache/calcite/pull/3311#discussion_r1316837374 ## linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java: ## @@ -4495,6 +4492,27 @@ private boolean advanceRight(TInner right, TKey rightKey) {

[GitHub] [calcite] libenchao merged pull request #3359: [CALCITE-5905] Documentation for CREATE TYPE is incorrect

2023-09-06 Thread via GitHub
libenchao merged PR #3359: URL: https://github.com/apache/calcite/pull/3359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[calcite] branch main updated: [CALCITE-5905] Documentation for CREATE TYPE is incorrect

2023-09-06 Thread libenchao
This is an automated email from the ASF dual-hosted git repository. libenchao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new b57f2d2cb0 [CALCITE-5905] Documentation for