[GitHub] [calcite] herunkang2018 commented on a diff in pull request #3412: [CALCITE-5921] SqlOperatorFixture.checkFails and checkAggFails don't check runtime failure

herunkang2018 commented on code in PR #3412: URL: https://github.com/apache/calcite/pull/3412#discussion_r1320491554 ## testkit/src/main/java/org/apache/calcite/sql/test/SqlOperatorFixture.java: ## @@ -96,7 +96,7 @@ public interface SqlOperatorFixture extends AutoCloseable {

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3412: [CALCITE-5921] SqlOperatorFixture.checkFails and checkAggFails don't check runtime failure

sonarcloud[bot] commented on PR #3412: URL: https://github.com/apache/calcite/pull/3412#issuecomment-1712426326 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] herunkang2018 opened a new pull request, #3412: [CALCITE-5921] SqlOperatorFixture.checkFails and checkAggFails don't check runtime failure

herunkang2018 opened a new pull request, #3412: URL: https://github.com/apache/calcite/pull/3412 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3411: [CALCITE-5986] The SqlTypeFamily for FP types is incorrect

sonarcloud[bot] commented on PR #3411: URL: https://github.com/apache/calcite/pull/3411#issuecomment-1712284508 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] mihaibudiu commented on pull request #3411: [CALCITE-5986] The SqlTypeFamily for FP types is incorrect

mihaibudiu commented on PR #3411: URL: https://github.com/apache/calcite/pull/3411#issuecomment-1712277072 @julianhyde This solution seems relatively painless. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] mihaibudiu opened a new pull request, #3411: [CALCITE-5986] The SqlTypeFamily for FP types is incorrect

mihaibudiu opened a new pull request, #3411: URL: https://github.com/apache/calcite/pull/3411 I have discovered that the notion of typeFamily for a type was ambiguous. There are two kinds of type families: primary families, and secondary families, as described in the JavaDoc

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3326: CALCITE-5860 Set scale when casting Decimal

sonarcloud[bot] commented on PR #3326: URL: https://github.com/apache/calcite/pull/3326#issuecomment-1712007896 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] pfzhan commented on pull request #3326: CALCITE-5860 Set scale when casting Decimal

pfzhan commented on PR #3326: URL: https://github.com/apache/calcite/pull/3326#issuecomment-1711993037 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [calcite] JiajunBernoulli commented on pull request #3397: [CALCITE-5836] Implement Rel2Sql for MERGE

JiajunBernoulli commented on PR #3397: URL: https://github.com/apache/calcite/pull/3397#issuecomment-1711491000 If there are no other suggestions, I will merge it tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [calcite] chucheng92 commented on pull request #3324: [CALCITE-5862] Incorrect semantics of ARRAY function(Spark library) when elements have Numeric and Character types

chucheng92 commented on PR #3324: URL: https://github.com/apache/calcite/pull/3324#issuecomment-1711448534 @tanclary @JiajunBernoulli thanks for your patient review. all comments resolved. @tanclary If you have time, could you help to merge this? -- This is an automated message from the

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3324: [CALCITE-5862] Incorrect semantics of ARRAY function(Spark library) when elements have Numeric and Character types

sonarcloud[bot] commented on PR #3324: URL: https://github.com/apache/calcite/pull/3324#issuecomment-1711442532 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3409: [CALCITE-5980] QuidemTests are not effectively executed on Windows

sonarcloud[bot] commented on PR #3409: URL: https://github.com/apache/calcite/pull/3409#issuecomment-1711423313 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[calcite] branch main updated: [CALCITE-5732] EnumerableHashJoin and EnumerableMergeJoin on composite key return rows matching condition 'null = null'

This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 3aee0b86aa [CALCITE-5732] EnumerableHashJoin and

[GitHub] [calcite] rubenada merged pull request #3311: [CALCITE-5732] EnumerableHashJoin and EnumerableMergeJoin on composite key return rows matching condition 'null = null'

rubenada merged PR #3311: URL: https://github.com/apache/calcite/pull/3311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3324: [CALCITE-5862] Incorrect semantics of ARRAY function(Spark library) when elements have Numeric and Character types

sonarcloud[bot] commented on PR #3324: URL: https://github.com/apache/calcite/pull/3324#issuecomment-1711214447 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png