[GitHub] [calcite] LakeShen commented on pull request #3436: [CALCITE-5984] Allow disabling field trim via `SqlToRelConverter` config

2023-09-27 Thread via GitHub
LakeShen commented on PR #3436: URL: https://github.com/apache/calcite/pull/3436#issuecomment-1738378375 Hi @WegdanGhazi ,If you think we could add this feature in 1.36.0,please change this jira Fix Version to 1.36.0. And also need the others review. -- This is an automated

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #3399: [CALCITE-5962] Support parse Spark-style syntax LEFT ANTI JOIN in Babel parser

2023-09-27 Thread via GitHub
JiajunBernoulli commented on code in PR #3399: URL: https://github.com/apache/calcite/pull/3399#discussion_r1339432251 ## babel/src/test/java/org/apache/calcite/test/BabelParserTest.java: ## @@ -430,6 +431,23 @@ private void checkParseInfixCast(String sqlType) {

[GitHub] [calcite] JiajunBernoulli commented on pull request #3429: [CALCITE-6006] RelToSqlConverter loses charset information

2023-09-27 Thread via GitHub
JiajunBernoulli commented on PR #3429: URL: https://github.com/apache/calcite/pull/3429#issuecomment-1738337214 @mihaibudiu , would you please squash commits? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] mihaibudiu opened a new pull request, #3446: [CALCITE-6030] DATE_PART is not handled by the RexToLixTranslator

2023-09-27 Thread via GitHub
mihaibudiu opened a new pull request, #3446: URL: https://github.com/apache/calcite/pull/3446 Please note that running this test requires #3445 to be merged first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3445: [CALCITE-6029] SqlOperatorTest cannot test operators that require the Babel parser

2023-09-27 Thread via GitHub
sonarcloud[bot] commented on PR #3445: URL: https://github.com/apache/calcite/pull/3445#issuecomment-1738229307 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] mihaibudiu opened a new pull request, #3445: [CALCITE-6029] SqlOperatorTest cannot test operators that require the Babel parser

2023-09-27 Thread via GitHub
mihaibudiu opened a new pull request, #3445: URL: https://github.com/apache/calcite/pull/3445 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [calcite] asfgit closed pull request #3421: [CALCITE-5982] Allow overloading the created enumerable in CalciteMetaImpl when calling getTables() or getColumns()

2023-09-27 Thread via GitHub
asfgit closed pull request #3421: [CALCITE-5982] Allow overloading the created enumerable in CalciteMetaImpl when calling getTables() or getColumns() URL: https://github.com/apache/calcite/pull/3421 -- This is an automated message from the Apache Git Service. To respond to the message,

[calcite] branch main updated: [CALCITE-5982] Allow implementations of CalciteMeta to return extra columns in their responses to DatabaseMetaData.getTables and getColumns requests

2023-09-27 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 436ae7d296 [CALCITE-5982] Allow implementations of

[calcite] branch main updated: [CALCITE-6007] Sub-query that contains WITH and has no alias generates invalid SQL after expansion

2023-09-27 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 1245db6201 [CALCITE-6007] Sub-query that contains

[GitHub] [calcite] julianhyde closed pull request #3440: [CALCITE-6007] CTE as subquery without alias doesn't have correct alias setup

2023-09-27 Thread via GitHub
julianhyde closed pull request #3440: [CALCITE-6007] CTE as subquery without alias doesn't have correct alias setup URL: https://github.com/apache/calcite/pull/3440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3420: [CALCITE-5989] Type inference for RPAD and LPAD functions (BIGQUERY) is incorrect

2023-09-27 Thread via GitHub
sonarcloud[bot] commented on PR #3420: URL: https://github.com/apache/calcite/pull/3420#issuecomment-1737858473 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] mihaibudiu commented on pull request #3420: [CALCITE-5989] Type inference for RPAD and LPAD functions (BIGQUERY) is incorrect

2023-09-27 Thread via GitHub
mihaibudiu commented on PR #3420: URL: https://github.com/apache/calcite/pull/3420#issuecomment-1737842041 Hopefully I have fixed the conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3444: [MINOR] Add example for MAP type in reference docs

2023-09-27 Thread via GitHub
sonarcloud[bot] commented on PR #3444: URL: https://github.com/apache/calcite/pull/3444#issuecomment-1737804213 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3444: [MINOR] Add example for MAP type in reference docs

2023-09-27 Thread via GitHub
sonarcloud[bot] commented on PR #3444: URL: https://github.com/apache/calcite/pull/3444#issuecomment-1737774036 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] chucheng92 commented on pull request #3444: [MINOR] Add example for MAP type in reference docs

2023-09-27 Thread via GitHub
chucheng92 commented on PR #3444: URL: https://github.com/apache/calcite/pull/3444#issuecomment-1737757453 > Is there a test which confirms this syntax? thanks for reviewing. Yes, we have.

[GitHub] [calcite] chucheng92 opened a new pull request, #3444: [MINOR] Add example for map type in reference docs

2023-09-27 Thread via GitHub
chucheng92 opened a new pull request, #3444: URL: https://github.com/apache/calcite/pull/3444 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[calcite] branch main updated: [CALCITE-5940] Add the Rule to merge Limit

2023-09-27 Thread jiajunxie
This is an automated email from the ASF dual-hosted git repository. jiajunxie pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new aef9bdb5c0 [CALCITE-5940] Add the Rule to merge

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3396: [CALCITE-5940] Add the Rule to merge Limit

2023-09-27 Thread via GitHub
sonarcloud[bot] commented on PR #3396: URL: https://github.com/apache/calcite/pull/3396#issuecomment-1736956144 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] rubenada commented on pull request #3420: [CALCITE-5989] Type inference for RPAD and LPAD functions (BIGQUERY) is incorrect

2023-09-27 Thread via GitHub
rubenada commented on PR #3420: URL: https://github.com/apache/calcite/pull/3420#issuecomment-1736842657 @mihaibudiu , sorry, there seems to be some conflicts now in the PR, could you please resolve it? I'll merge it right away. -- This is an automated message from the Apache Git

[calcite-site] branch main updated: Website deployed from calcite@56f7b8248352568539cbfe0222606903d69e521c

2023-09-27 Thread asf-ci-deploy
This is an automated email from the ASF dual-hosted git repository. asf-ci-deploy pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite-site.git The following commit(s) were added to refs/heads/main by this push: new 9257dec0d Website deployed from

[calcite] branch site updated: [CALCITE-6017] Update the GitHub link of released versions

2023-09-27 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch site in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/site by this push: new d34d844eea [CALCITE-6017] Update the GitHub

[GitHub] [calcite] rubenada merged pull request #3441: [CALCITE-6017] Update the GitHub link of released versions

2023-09-27 Thread via GitHub
rubenada merged PR #3441: URL: https://github.com/apache/calcite/pull/3441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[calcite] branch main updated: [CALCITE-6017] Update the GitHub link of released versions

2023-09-27 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 56f7b82483 [CALCITE-6017] Update the GitHub link