[GitHub] [calcite] sonarcloud[bot] commented on pull request #3444: [MINOR] Add example for MAP type in reference docs

sonarcloud[bot] commented on PR #3444: URL: https://github.com/apache/calcite/pull/3444#issuecomment-1741634711 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3444: [MINOR] Add example for MAP type in reference docs

chucheng92 commented on code in PR #3444: URL: https://github.com/apache/calcite/pull/3444#discussion_r1341881676 ## site/_docs/reference.md: ## @@ -1200,7 +1200,7 @@ Note: | ANY | The union of all types | | UNKNOWN | A value of an unknown type; used as a placeholder |

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3444: [MINOR] Add example for MAP type in reference docs

chucheng92 commented on code in PR #3444: URL: https://github.com/apache/calcite/pull/3444#discussion_r1341881332 ## site/_docs/reference.md: ## @@ -1200,7 +1200,7 @@ Note: | ANY | The union of all types | | UNKNOWN | A value of an unknown type; used as a placeholder |

[calcite] branch main updated: [CALCITE-5989] Type inference for RPAD and LPAD functions (BIGQUERY) is incorrect

This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 3bb7117446 [CALCITE-5989] Type inference for RPAD

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3420: [CALCITE-5989] Type inference for RPAD and LPAD functions (BIGQUERY) is incorrect

sonarcloud[bot] commented on PR #3420: URL: https://github.com/apache/calcite/pull/3420#issuecomment-1741395587 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] mihaibudiu commented on pull request #3420: [CALCITE-5989] Type inference for RPAD and LPAD functions (BIGQUERY) is incorrect

mihaibudiu commented on PR #3420: URL: https://github.com/apache/calcite/pull/3420#issuecomment-1741358294 I have added a symmetric test for LPAD as well. I have squashed the commits optimistically. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [calcite] LakeShen commented on a diff in pull request #3393: [CALCITE-5950] Default column constraint is erroneously processed

LakeShen commented on code in PR #3393: URL: https://github.com/apache/calcite/pull/3393#discussion_r1341464477 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -4769,19 +4778,51 @@ private void convertValuesImpl( return; } -for

[GitHub] [calcite] LakeShen commented on a diff in pull request #3393: [CALCITE-5950] Default column constraint is erroneously processed

LakeShen commented on code in PR #3393: URL: https://github.com/apache/calcite/pull/3393#discussion_r1341448488 ## core/src/main/java/org/apache/calcite/sql/SqlUtil.java: ## @@ -1238,6 +1238,17 @@ public static boolean containsIn(SqlNode node) { return containsCall(node,

[GitHub] [calcite] LeonidChistov commented on a diff in pull request #3431: [CALCITE-5523] RelToSql converter generates GROUP BY clause with wind…

LeonidChistov commented on code in PR #3431: URL: https://github.com/apache/calcite/pull/3431#discussion_r1341439927 ## core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java: ## @@ -1878,6 +1878,11 @@ && hasSortByOrdinal()) { && (hasNestedAgg ||

[GitHub] [calcite] julianhyde commented on a diff in pull request #3393: [CALCITE-5950] Default column constraint is erroneously processed

julianhyde commented on code in PR #3393: URL: https://github.com/apache/calcite/pull/3393#discussion_r1341429998 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -3801,13 +3806,17 @@ private static boolean all(SqlCall call) { protected RelNode

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3449: [CALCITE-6009] Add optimization to remove redundant Limit when its input's row number is less or equal to Limit's fetch

sonarcloud[bot] commented on PR #3449: URL: https://github.com/apache/calcite/pull/3449#issuecomment-1740903974 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] LakeShen opened a new pull request, #3449: [CALCITE-6009] Add optimization to remove redundant Limit when its input's row number is less or equal to Limit's fetch

LakeShen opened a new pull request, #3449: URL: https://github.com/apache/calcite/pull/3449 …put's row number is less or equal to Limit's fetch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [calcite] pfzhan commented on pull request #3326: CALCITE-5860 Set scale when casting Decimal

pfzhan commented on PR #3326: URL: https://github.com/apache/calcite/pull/3326#issuecomment-1740819737 > Overall the changes LGTM, however when I apply locally the patch for [CALCITE-5923](https://issues.apache.org/jira/browse/CALCITE-5923), which makes all the tests under SqlOperatorTest

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #3393: [CALCITE-5950] Default column constraint is erroneously processed

JiajunBernoulli commented on code in PR #3393: URL: https://github.com/apache/calcite/pull/3393#discussion_r1341124452 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -4769,19 +4778,53 @@ private void convertValuesImpl( return; } -

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3393: [CALCITE-5950] Default column constraint is erroneously processed

sonarcloud[bot] commented on PR #3393: URL: https://github.com/apache/calcite/pull/3393#issuecomment-1740549910 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #3442: [CALCITE-6022] Support "CREATE TABLE LIKE" DDL

JiajunBernoulli commented on code in PR #3442: URL: https://github.com/apache/calcite/pull/3442#discussion_r1341084324 ## core/src/main/java/org/apache/calcite/sql/ddl/SqlCreateTableLike.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #3444: [MINOR] Add example for MAP type in reference docs

JiajunBernoulli commented on code in PR #3444: URL: https://github.com/apache/calcite/pull/3444#discussion_r1341075315 ## site/_docs/reference.md: ## @@ -1200,7 +1200,7 @@ Note: | ANY | The union of all types | | UNKNOWN | A value of an unknown type; used as a

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #3444: [MINOR] Add example for MAP type in reference docs

JiajunBernoulli commented on code in PR #3444: URL: https://github.com/apache/calcite/pull/3444#discussion_r1341072293 ## site/_docs/reference.md: ## @@ -1200,7 +1200,7 @@ Note: | ANY | The union of all types | | UNKNOWN | A value of an unknown type; used as a

[GitHub] [calcite] zstan commented on a diff in pull request #3393: [CALCITE-5950] Default column constraint is erroneously processed

zstan commented on code in PR #3393: URL: https://github.com/apache/calcite/pull/3393#discussion_r1341010740 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -4769,19 +4778,51 @@ private void convertValuesImpl( return; } -for

[GitHub] [calcite] rubenada commented on pull request #3420: [CALCITE-5989] Type inference for RPAD and LPAD functions (BIGQUERY) is incorrect

rubenada commented on PR #3420: URL: https://github.com/apache/calcite/pull/3420#issuecomment-1740414057 Thanks @mihaibudiu , sorry for this back and forth. One last question, in the current state, the PR just has one new test in RelOptRulesTest: testRpad; didn't it use to have another

[GitHub] [calcite] zstan commented on a diff in pull request #3393: [CALCITE-5950] Default column constraint is erroneously processed

zstan commented on code in PR #3393: URL: https://github.com/apache/calcite/pull/3393#discussion_r1340984163 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -3801,13 +3806,17 @@ private static boolean all(SqlCall call) { protected RelNode