Re: [PR] [CALCITE-6052] SqlImplementor writes FLOATING POINT literals as DECIMAL literals [calcite]

2023-10-16 Thread via GitHub
sonarcloud[bot] commented on PR #3472: URL: https://github.com/apache/calcite/pull/3472#issuecomment-1765324255 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] [CALCITE-5986] The typeFamily property of SqlTypeName is used inconsistently [calcite]

2023-10-16 Thread via GitHub
sonarcloud[bot] commented on PR #3411: URL: https://github.com/apache/calcite/pull/3411#issuecomment-1765292305 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] [CALCITE-5986] The typeFamily property of SqlTypeName is used inconsistently [calcite]

2023-10-16 Thread via GitHub
mihaibudiu commented on PR #3411: URL: https://github.com/apache/calcite/pull/3411#issuecomment-1765287239 I realize that this is a more intrusive change, but I think it does make a small step in improving the use to type families. This PR also fixes a bug introduced by the incorrect use

[PR] [CALCITE-6052] reltosql writes FLOATING POINT literals as DECIMAL literals [calcite]

2023-10-16 Thread via GitHub
mihaibudiu opened a new pull request, #3472: URL: https://github.com/apache/calcite/pull/3472 This bug was also fixed in #3411, but perhaps we can merge this PR more easily since it is much smaller. I didn't add a new test case since the pig test case covers it. -- This is an

Re: [PR] [CALCITE-6030] DATE_PART is not handled by the RexToLixTranslator [calcite]

2023-10-16 Thread via GitHub
sonarcloud[bot] commented on PR #3446: URL: https://github.com/apache/calcite/pull/3446#issuecomment-1765276947 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] [CALCITE-6030] DATE_PART is not handled by the RexToLixTranslator [calcite]

2023-10-16 Thread via GitHub
mihaibudiu commented on PR #3446: URL: https://github.com/apache/calcite/pull/3446#issuecomment-1765244142 I have reworked this bugfix so that it can be merged right away, and we can debate #3445 separately. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [CALCITE-5884] Type Inference rule for ARRAY_TO_STRING is incorrect [calcite]

2023-10-16 Thread via GitHub
sonarcloud[bot] commented on PR #3346: URL: https://github.com/apache/calcite/pull/3346#issuecomment-1765235356 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] [CALCITE-5979] Add REGEXP_REPLACE function (enabled in BigQuery library) [calcite]

2023-10-16 Thread via GitHub
Anthrino commented on code in PR #3460: URL: https://github.com/apache/calcite/pull/3460#discussion_r1361239481 ## core/src/main/java/org/apache/calcite/sql/validate/SqlConformanceEnum.java: ## @@ -240,6 +240,15 @@ public enum SqlConformanceEnum implements SqlConformance {

Re: [PR] [CALCITE-5884] Type Inference rule for ARRAY_TO_STRING is incorrect [calcite]

2023-10-16 Thread via GitHub
mihaibudiu commented on PR #3346: URL: https://github.com/apache/calcite/pull/3346#issuecomment-1765213995 > @mihaibudiu ,please rebase the latest main branch's code. Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [CALCITE-5918] Add MAP function (enabled in Spark library) [calcite]

2023-10-16 Thread via GitHub
chucheng92 commented on code in PR #3459: URL: https://github.com/apache/calcite/pull/3459#discussion_r1358158316 ## core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java: ## @@ -1221,6 +1225,53 @@ private static class MapFromEntriesOperandTypeChecker } } +

[calcite] branch main updated: [CALCITE-6014] Create a SqlOperatorFixture that parses, unparses, and then parses again before executing

2023-10-16 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 5151168e9a [CALCITE-6014] Create a

Re: [PR] [CALCITE-6014] Create a SqlOperatorFixture that parses, unparses, and… [calcite]

2023-10-16 Thread via GitHub
rubenada merged PR #3433: URL: https://github.com/apache/calcite/pull/3433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: