Re: [PR] [CALCITE-6260] Add already implemented functions in Spark library [calcite]

2024-02-12 Thread via GitHub
YiwenWu commented on code in PR #3684: URL: https://github.com/apache/calcite/pull/3684#discussion_r1487094978 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -1074,6 +1080,26 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding

Re: [PR] [CALCITE-6258] Map value constructor is unparsed incorrectly for PrestoSqlDialect [calcite]

2024-02-12 Thread via GitHub
sonarcloud[bot] commented on PR #3683: URL: https://github.com/apache/calcite/pull/3683#issuecomment-1940337911 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6258] Map value constructor is unparsed incorrectly for PrestoSqlDialect [calcite]

2024-02-12 Thread via GitHub
YiwenWu commented on code in PR #3683: URL: https://github.com/apache/calcite/pull/3683#discussion_r1487082616 ## core/src/main/java/org/apache/calcite/sql/dialect/PrestoSqlDialect.java: ## @@ -131,8 +136,30 @@ private static void unparseUsingLimit(SqlWriter writer, @Nullable

Re: [PR] [CALCITE-6258] Map value constructor is unparsed incorrectly for PrestoSqlDialect [calcite]

2024-02-12 Thread via GitHub
YiwenWu commented on code in PR #3683: URL: https://github.com/apache/calcite/pull/3683#discussion_r1487081624 ## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ## @@ -4169,7 +4171,10 @@ private SqlDialect nonOrdinalDialect() { final String

Re: [PR] [CALCITE-6239] Add a postgis dialect that supports ST functions [calcite]

2024-02-12 Thread via GitHub
jnh5y commented on code in PR #3668: URL: https://github.com/apache/calcite/pull/3668#discussion_r1486959295 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java: ## @@ -312,7 +312,9 @@ private Expression getConvertExpression( case CHAR:

Re: [PR] [CALCITE-6239] Add a postgis dialect that supports ST functions [calcite]

2024-02-12 Thread via GitHub
julianhyde commented on code in PR #3668: URL: https://github.com/apache/calcite/pull/3668#discussion_r1486928091 ## core/src/main/java/org/apache/calcite/sql/SqlKind.java: ## @@ -1140,27 +1140,447 @@ public enum SqlKind { // Spatial functions. They are registered as

Re: [PR] [CALCITE-6239] Add a postgis dialect that supports ST functions [calcite]

2024-02-12 Thread via GitHub
julianhyde commented on code in PR #3668: URL: https://github.com/apache/calcite/pull/3668#discussion_r1486918013 ## core/src/main/java/org/apache/calcite/sql/dialect/PostgisSqlDialect.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [CALCITE-6248] Illegal dates are accepted by casts [calcite]

2024-02-12 Thread via GitHub
sonarcloud[bot] commented on PR #3685: URL: https://github.com/apache/calcite/pull/3685#issuecomment-1939759965 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] [CALCITE-6248] Illegal dates are accepted by casts [calcite]

2024-02-12 Thread via GitHub
mihaibudiu opened a new pull request, #3685: URL: https://github.com/apache/calcite/pull/3685 This PR is a pair to https://github.com/apache/calcite-avatica/pull/238 and should be merged before the other one can pass. It only changes a few date literals in tests to conform to the

Re: [PR] [CALCITE-6252] BigQuery FORMAT_DATE uses the wrong calendar for Julian dates [calcite]

2024-02-12 Thread via GitHub
sonarcloud[bot] commented on PR #3680: URL: https://github.com/apache/calcite/pull/3680#issuecomment-1939734784 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-2980] Implement the FORMAT clause of the CAST operator [calcite]

2024-02-12 Thread via GitHub
sonarcloud[bot] commented on PR #3677: URL: https://github.com/apache/calcite/pull/3677#issuecomment-1939709400 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6252] BigQuery FORMAT_DATE uses the wrong calendar for Julian dates [calcite]

2024-02-12 Thread via GitHub
mihaibudiu commented on code in PR #3680: URL: https://github.com/apache/calcite/pull/3680#discussion_r1486861642 ## core/src/main/java/org/apache/calcite/util/format/FormatElementEnum.java: ## @@ -57,8 +59,17 @@ public enum FormatElementEnum implements FormatElement { },

Re: [PR] [CALCITE-6260] Add already implemented functions in Spark library [calcite]

2024-02-12 Thread via GitHub
mihaibudiu commented on code in PR #3684: URL: https://github.com/apache/calcite/pull/3684#discussion_r1486819673 ## babel/src/test/java/org/apache/calcite/test/BabelQuidemTest.java: ## @@ -131,6 +131,16 @@ public static void main(String[] args) throws Exception {

Re: [PR] [CALCITE-6210] Cast to VARBINARY causes an assertion failure [calcite]

2024-02-12 Thread via GitHub
julianhyde commented on PR #3635: URL: https://github.com/apache/calcite/pull/3635#issuecomment-1939623618 Can we have design discussions in jira? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

(calcite) branch site updated: [CALCITE-6250] Limitations of MongoDB adapter are not documented

2024-02-12 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch site in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/site by this push: new 6c3386c347 [CALCITE-6250] Limitations of

(calcite-site) branch main updated: Website deployed from calcite@e05b0473a00a7b7fdb386e3decb4bff42a2161ac

2024-02-12 Thread asf-ci-deploy
This is an automated email from the ASF dual-hosted git repository. asf-ci-deploy pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite-site.git The following commit(s) were added to refs/heads/main by this push: new df42fbfd6 Website deployed from

(calcite) branch main updated: [CALCITE-6250] Limitations of MongoDB adapter are not documented

2024-02-12 Thread mbudiu
This is an automated email from the ASF dual-hosted git repository. mbudiu pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new e05b0473a0 [CALCITE-6250] Limitations of MongoDB

Re: [PR] [CALCITE-6250] Limitations of MongoDB adapter are not documented [calcite]

2024-02-12 Thread via GitHub
mihaibudiu merged PR #3676: URL: https://github.com/apache/calcite/pull/3676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CALCITE-6210] Cast to VARBINARY causes an assertion failure [calcite]

2024-02-12 Thread via GitHub
mihaibudiu commented on PR #3635: URL: https://github.com/apache/calcite/pull/3635#issuecomment-1939616304 These are very good questions. Indeed, this PR the "Enumerable" implementation. But that implementation is special, because it is the one used when Calcite optimizations simplify a

Re: [PR] [CALCITE-6257] StarRocks dialect implementation [calcite]

2024-02-12 Thread via GitHub
mihaibudiu commented on code in PR #3682: URL: https://github.com/apache/calcite/pull/3682#discussion_r1486629721 ## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ## @@ -4506,13 +4600,16 @@ private void checkLiteral2(String expression, String

Re: [PR] [CALCITE-6260] Add already implemented functions in Spark library [calcite]

2024-02-12 Thread via GitHub
sonarcloud[bot] commented on PR #3684: URL: https://github.com/apache/calcite/pull/3684#issuecomment-1939122808 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6258] Map value constructor is unparsed incorrectly for PrestoSqlDialect [calcite]

2024-02-12 Thread via GitHub
sonarcloud[bot] commented on PR #3683: URL: https://github.com/apache/calcite/pull/3683#issuecomment-1939092167 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6258] Map value constructor is unparsed incorrectly for PrestoSqlDialect [calcite]

2024-02-12 Thread via GitHub
sonarcloud[bot] commented on PR #3683: URL: https://github.com/apache/calcite/pull/3683#issuecomment-1939075027 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6258] Map value constructor is unparsed incorrectly for PrestoSqlDialect [calcite]

2024-02-12 Thread via GitHub
sonarcloud[bot] commented on PR #3683: URL: https://github.com/apache/calcite/pull/3683#issuecomment-1939027076 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6210] Cast to VARBINARY causes an assertion failure [calcite]

2024-02-12 Thread via GitHub
gortiz commented on PR #3635: URL: https://github.com/apache/calcite/pull/3635#issuecomment-1938501532 I have a couple of questions about this PR. ## does it actually fix the issue? The issue was the assertion error when casting STRING to VARBINARY. I'm not an expert on Apache

Re: [PR] [CALCITE-6198] Add TO_TIMESTAMP_LTZ function (enabled in Snowflake li… [calcite]

2024-02-12 Thread via GitHub
caicancai commented on code in PR #3631: URL: https://github.com/apache/calcite/pull/3631#discussion_r1486012354 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -8747,6 +8747,55 @@ private void testCurrentDateFunc(Pair pair) { } } + /**

Re: [PR] [CALCITE-6250] Limitations of MongoDB adapter are not documented [calcite]

2024-02-12 Thread via GitHub
sonarcloud[bot] commented on PR #3676: URL: https://github.com/apache/calcite/pull/3676#issuecomment-1938274801 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6250] Limitations of MongoDB adapter are not documented [calcite]

2024-02-12 Thread via GitHub
TheOezzi commented on PR #3676: URL: https://github.com/apache/calcite/pull/3676#issuecomment-1938240388 I've adapted the commit and title according to your suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

(calcite) branch main updated: [CALCITE-6251] InnerEnumerator in EnumerableDefaults::correlateBatchJoin is not closed

2024-02-12 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new abf462a7dd [CALCITE-6251] InnerEnumerator in

Re: [PR] [CALCITE-6251] innerEnumerator in EnumerableDefaults::correlateBatchJoin is not closed [calcite]

2024-02-12 Thread via GitHub
rubenada merged PR #3675: URL: https://github.com/apache/calcite/pull/3675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: