[GitHub] [calcite] geetha-rangaswamaiah opened a new pull request #2165: Fix grammatical errors

2020-09-22 Thread GitBox
geetha-rangaswamaiah opened a new pull request #2165: URL: https://github.com/apache/calcite/pull/2165 This PR fixes grammatical errors. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [calcite] liupc commented on pull request #2164: [CALCITE-4176] Key descriptor can be optional in SESSION table function

2020-09-22 Thread GitBox
liupc commented on pull request #2164: URL: https://github.com/apache/calcite/pull/2164#issuecomment-696684140 cc @amaliujia @danny0405 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [calcite] liupc opened a new pull request #2164: [CALCITE-4176] Key descriptor can be optional in SESSION table function

2020-09-22 Thread GitBox
liupc opened a new pull request #2164: URL: https://github.com/apache/calcite/pull/2164 This PR try to make the key descriptor optional in SESSION table function * Handling the optional key descriptor when checking operand types * Add validation and checks for operands of time

[GitHub] [calcite] vlsi commented on a change in pull request #2163: [CALCITE-4273] Support get expression lineage for Calc

2020-09-22 Thread GitBox
vlsi commented on a change in pull request #2163: URL: https://github.com/apache/calcite/pull/2163#discussion_r492663176 ## File path: core/src/test/java/org/apache/calcite/test/RelMetadataTest.java ## @@ -2506,6 +2506,30 @@ private void checkPredicates(RelOptCluster cluster,

[GitHub] [calcite] vlsi commented on a change in pull request #2163: [CALCITE-4273] Support get expression lineage for Calc

2020-09-22 Thread GitBox
vlsi commented on a change in pull request #2163: URL: https://github.com/apache/calcite/pull/2163#discussion_r492657451 ## File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java ## @@ -3607,6 +3607,25 @@ public int size() { return relBuilder.build(); }

[GitHub] [calcite] yanlin-Lynn opened a new pull request #2163: [CALCITE-4273] Support get expression lineage for Calc

2020-09-22 Thread GitBox
yanlin-Lynn opened a new pull request #2163: URL: https://github.com/apache/calcite/pull/2163 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] rubenada merged pull request #2143: [CALCITE-4224] Add an method for RelNode to output its tree digest like RelOptUtil.toString (Jiatao Tao)

2020-09-22 Thread GitBox
rubenada merged pull request #2143: URL: https://github.com/apache/calcite/pull/2143 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] Aaaaaaron edited a comment on pull request #2161: [CALCITE-4240] SqlTypeUtil#getMaxPrecisionScaleDecimal returns a decimal that with same precision and scale (Jiatao Tao)

2020-09-22 Thread GitBox
Aaron edited a comment on pull request #2161: URL: https://github.com/apache/calcite/pull/2161#issuecomment-696535352 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] Aaaaaaron edited a comment on pull request #2161: [CALCITE-4240] Fix SqlTypeUtil#getMaxPrecisionScaleDecimal returns a decimal that with same precision and scale(Jiatao Tao)

2020-09-22 Thread GitBox
Aaron edited a comment on pull request #2161: URL: https://github.com/apache/calcite/pull/2161#issuecomment-696535352 > Remove the word 'fix' from the commit message. Change the message so that it is clear what the bug is. > > Add space before '(' in commit message. > >

[GitHub] [calcite] Aaaaaaron commented on pull request #2161: [CALCITE-4240] Fix SqlTypeUtil#getMaxPrecisionScaleDecimal returns a decimal that with same precision and scale(Jiatao Tao)

2020-09-22 Thread GitBox
Aaron commented on pull request #2161: URL: https://github.com/apache/calcite/pull/2161#issuecomment-696535352 > Remove the word 'fix' from the commit message. Change the message so that it is clear what the bug is. > > Add space before '(' in commit message. > > Why

[GitHub] [calcite] Aaaaaaron edited a comment on pull request #2161: [CALCITE-4240] Fix SqlTypeUtil#getMaxPrecisionScaleDecimal returns a decimal that with same precision and scale(Jiatao Tao)

2020-09-22 Thread GitBox
Aaron edited a comment on pull request #2161: URL: https://github.com/apache/calcite/pull/2161#issuecomment-696535352 > Remove the word 'fix' from the commit message. Change the message so that it is clear what the bug is. > > Add space before '(' in commit message. > >

[GitHub] [calcite] chunweilei closed pull request #2121: [CALCITE-4192] RelMdColumnOrigins should obtain the true column index of the group by column of the aggregation operator instead of passing thr

2020-09-22 Thread GitBox
chunweilei closed pull request #2121: URL: https://github.com/apache/calcite/pull/2121 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] rubenada commented on pull request #2143: [CALCITE-4224] Add an method for RelNode to output its tree digest like RelOptUtil.toString (Jiatao Tao)

2020-09-22 Thread GitBox
rubenada commented on pull request #2143: URL: https://github.com/apache/calcite/pull/2143#issuecomment-695995704 IMHO this patch can be merged. If nobody objects, I plan to merge the PR in 24h This is an automated

[GitHub] [calcite] vlsi commented on pull request #2160: [CALCITE-4269] Improvement on enumerable implementation for HOP and SESSION

2020-09-21 Thread GitBox
vlsi commented on pull request #2160: URL: https://github.com/apache/calcite/pull/2160#issuecomment-696094924 LGTM, thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] Aaaaaaron commented on pull request #2161: [CALCITE-4240] Fix SqlTypeUtil#getMaxPrecisionScaleDecimal returns a decimal that with same precision and scale(Jiatao Tao)

2020-09-21 Thread GitBox
Aaron commented on pull request #2161: URL: https://github.com/apache/calcite/pull/2161#issuecomment-695883614 Still have some ut failed, will fix than, with review comments. This is an automated message from the Apache

[GitHub] [calcite] julianhyde commented on pull request #2161: [CALCITE-4240] Fix SqlTypeUtil#getMaxPrecisionScaleDecimal returns a decimal that with same precision and scale(Jiatao Tao)

2020-09-21 Thread GitBox
julianhyde commented on pull request #2161: URL: https://github.com/apache/calcite/pull/2161#issuecomment-696393247 Remove the word 'fix' from the commit message. Change the message so that it is clear what the bug is. Why would `DECIMAL(10, 28)` not be valid? Say if you are

[GitHub] [calcite] asfgit closed pull request #2159: [CALCITE-4209] In RelBuilder, add an option to not simplify LIMIT 0 t…

2020-09-21 Thread GitBox
asfgit closed pull request #2159: URL: https://github.com/apache/calcite/pull/2159 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [calcite] amaliujia commented on pull request #2160: [CALCITE-4269] Improvement on enumerable implementation for HOP and SESSION

2020-09-21 Thread GitBox
amaliujia commented on pull request #2160: URL: https://github.com/apache/calcite/pull/2160#issuecomment-695848881 cc @vlsi This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [calcite] liyafan82 commented on pull request #2151: [CALCITE-4155] Simplify IN expression of discrete values

2020-09-21 Thread GitBox
liyafan82 commented on pull request #2151: URL: https://github.com/apache/calcite/pull/2151#issuecomment-696075496 > I noticed that in the JIRA Julian mentioned he is working on https://github.com/julianhyde/calcite/tree/4159-simplify which might solve this case. It might be still good to

[GitHub] [calcite] chunweilei merged pull request #2146: [CALCITE-4241] Some improvements to metadata query

2020-09-21 Thread GitBox
chunweilei merged pull request #2146: URL: https://github.com/apache/calcite/pull/2146 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] julianhyde edited a comment on pull request #2161: [CALCITE-4240] Fix SqlTypeUtil#getMaxPrecisionScaleDecimal returns a decimal that with same precision and scale(Jiatao Tao)

2020-09-21 Thread GitBox
julianhyde edited a comment on pull request #2161: URL: https://github.com/apache/calcite/pull/2161#issuecomment-696393247 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] rubenada merged pull request #2155: [CALCITE-4261] Join with three tables causes IllegalArgumentException in EnumerableBatchNestedLoopJoinRule

2020-09-21 Thread GitBox
rubenada merged pull request #2155: URL: https://github.com/apache/calcite/pull/2155 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] vlsi commented on a change in pull request #2160: [CALCITE-4269] Improvement on enumerable implementation for HOP and SESSION

2020-09-21 Thread GitBox
vlsi commented on a change in pull request #2160: URL: https://github.com/apache/calcite/pull/2160#discussion_r492021503 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumUtils.java ## @@ -856,7 +856,7 @@ static Expression tumblingWindowSelector(

[GitHub] [calcite] asfgit closed pull request #2159: [CALCITE-4209] In RelBuilder, add an option to not simplify LIMIT 0 t…

2020-09-21 Thread GitBox
asfgit closed pull request #2159: URL: https://github.com/apache/calcite/pull/2159 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [calcite] julianhyde edited a comment on pull request #2161: [CALCITE-4240] Fix SqlTypeUtil#getMaxPrecisionScaleDecimal returns a decimal that with same precision and scale(Jiatao Tao)

2020-09-21 Thread GitBox
julianhyde edited a comment on pull request #2161: URL: https://github.com/apache/calcite/pull/2161#issuecomment-696393247 Remove the word 'fix' from the commit message. Change the message so that it is clear what the bug is. Add space before '(' in commit message. Why would

[GitHub] [calcite] julianhyde opened a new pull request #2162: [Looker branch] Do not review; do not merge

2020-09-21 Thread GitBox
julianhyde opened a new pull request #2162: URL: https://github.com/apache/calcite/pull/2162 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [calcite] julianhyde commented on pull request #2161: [CALCITE-4240] Fix SqlTypeUtil#getMaxPrecisionScaleDecimal returns a decimal that with same precision and scale(Jiatao Tao)

2020-09-21 Thread GitBox
julianhyde commented on pull request #2161: URL: https://github.com/apache/calcite/pull/2161#issuecomment-696393247 Remove the word 'fix' from the commit message. Change the message so that it is clear what the bug is. Why would `DECIMAL(10, 28)` not be valid? Say if you are

[GitHub] [calcite] julianhyde edited a comment on pull request #2161: [CALCITE-4240] Fix SqlTypeUtil#getMaxPrecisionScaleDecimal returns a decimal that with same precision and scale(Jiatao Tao)

2020-09-21 Thread GitBox
julianhyde edited a comment on pull request #2161: URL: https://github.com/apache/calcite/pull/2161#issuecomment-696393247 Remove the word 'fix' from the commit message. Change the message so that it is clear what the bug is. Add space before '(' in commit message. Why would

[GitHub] [calcite] vlsi commented on a change in pull request #2160: [CALCITE-4269] Improvement on enumerable implementation for HOP and SESSION

2020-09-21 Thread GitBox
vlsi commented on a change in pull request #2160: URL: https://github.com/apache/calcite/pull/2160#discussion_r492021831 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumUtils.java ## @@ -998,7 +998,7 @@ private boolean isOverlapped(Pair a, Pair b) {

[GitHub] [calcite] vlsi commented on a change in pull request #2160: [CALCITE-4269] Improvement on enumerable implementation for HOP and SESSION

2020-09-21 Thread GitBox
vlsi commented on a change in pull request #2160: URL: https://github.com/apache/calcite/pull/2160#discussion_r492021503 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumUtils.java ## @@ -856,7 +856,7 @@ static Expression tumblingWindowSelector(

[GitHub] [calcite] vlsi commented on pull request #2160: [CALCITE-4269] Improvement on enumerable implementation for HOP and SESSION

2020-09-21 Thread GitBox
vlsi commented on pull request #2160: URL: https://github.com/apache/calcite/pull/2160#issuecomment-696094924 LGTM, thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] liyafan82 commented on pull request #2151: [CALCITE-4155] Simplify IN expression of discrete values

2020-09-21 Thread GitBox
liyafan82 commented on pull request #2151: URL: https://github.com/apache/calcite/pull/2151#issuecomment-696075496 > I noticed that in the JIRA Julian mentioned he is working on https://github.com/julianhyde/calcite/tree/4159-simplify which might solve this case. It might be still good to

[GitHub] [calcite] rubenada commented on pull request #2143: [CALCITE-4224] Add an method for RelNode to output its tree digest like RelOptUtil.toString (Jiatao Tao)

2020-09-21 Thread GitBox
rubenada commented on pull request #2143: URL: https://github.com/apache/calcite/pull/2143#issuecomment-695995704 IMHO this patch can be merged. If nobody objects, I plan to merge the PR in 24h This is an automated

[GitHub] [calcite] rubenada merged pull request #2155: [CALCITE-4261] Join with three tables causes IllegalArgumentException in EnumerableBatchNestedLoopJoinRule

2020-09-21 Thread GitBox
rubenada merged pull request #2155: URL: https://github.com/apache/calcite/pull/2155 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] chunweilei closed pull request #2121: [CALCITE-4192] RelMdColumnOrigins should obtain the true column index of the group by column of the aggregation operator instead of passing thr

2020-09-20 Thread GitBox
chunweilei closed pull request #2121: URL: https://github.com/apache/calcite/pull/2121 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] chunweilei merged pull request #2146: [CALCITE-4241] Some improvements to metadata query

2020-09-20 Thread GitBox
chunweilei merged pull request #2146: URL: https://github.com/apache/calcite/pull/2146 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] Aaaaaaron commented on pull request #2161: [CALCITE-4240] Fix SqlTypeUtil#getMaxPrecisionScaleDecimal returns a decimal that with same precision and scale(Jiatao Tao)

2020-09-20 Thread GitBox
Aaron commented on pull request #2161: URL: https://github.com/apache/calcite/pull/2161#issuecomment-695883614 Still have some ut failed, will fix than, with review comments. This is an automated message from the Apache

[GitHub] [calcite] Aaaaaaron opened a new pull request #2161: [CALCITE-4240] Fix SqlTypeUtil#getMaxPrecisionScaleDecimal returns a decimal that with same precision and scale(Jiatao Tao)

2020-09-20 Thread GitBox
Aaron opened a new pull request #2161: URL: https://github.com/apache/calcite/pull/2161 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [calcite] amaliujia commented on pull request #2160: [CALCITE-4269] Improvement on enumerable implementation for HOP and SESSION

2020-09-20 Thread GitBox
amaliujia commented on pull request #2160: URL: https://github.com/apache/calcite/pull/2160#issuecomment-695848881 cc @vlsi This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [calcite] amaliujia opened a new pull request #2160: [CALCITE-3780] Improve SESSION Table-valued Function

2020-09-20 Thread GitBox
amaliujia opened a new pull request #2160: URL: https://github.com/apache/calcite/pull/2160 1. Use ArrayDeque to replace LinkedList for the sake of efficiency. 2. Mark the list as "final". This is an automated

[GitHub] [calcite] amaliujia commented on pull request #2151: [CALCITE-4155] Simplify IN expression of discrete values

2020-09-18 Thread GitBox
amaliujia commented on pull request #2151: URL: https://github.com/apache/calcite/pull/2151#issuecomment-695163559 I noticed that in the JIRA Julian mentioned he is working on https://github.com/julianhyde/calcite/tree/4159-simplify which might solve this case. It might be still good to

[GitHub] [calcite] julianhyde opened a new pull request #2159: [CALCITE-4209] In RelBuilder, add an option to not simplify LIMIT 0 t…

2020-09-18 Thread GitBox
julianhyde opened a new pull request #2159: URL: https://github.com/apache/calcite/pull/2159 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [calcite] julianhyde opened a new pull request #2158: Work-in-progress; do not review; do not merge

2020-09-18 Thread GitBox
julianhyde opened a new pull request #2158: URL: https://github.com/apache/calcite/pull/2158 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [calcite] julianhyde merged pull request #2157: Work-in-progress; do not review; do not merge

2020-09-18 Thread GitBox
julianhyde merged pull request #2157: URL: https://github.com/apache/calcite/pull/2157 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] julianhyde opened a new pull request #2157: Work-in-progress; do not review; do not merge

2020-09-18 Thread GitBox
julianhyde opened a new pull request #2157: URL: https://github.com/apache/calcite/pull/2157 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [calcite] KhawlaMhb commented on pull request #2155: [CALCITE-4261] Join with three tables causes IllegalArgumentException in EnumerableBatchNestedLoopJoinRule

2020-09-18 Thread GitBox
KhawlaMhb commented on pull request #2155: URL: https://github.com/apache/calcite/pull/2155#issuecomment-694833453 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] liyafan82 opened a new pull request #2156: [CALCITE-4260] Support plan explain with dot format

2020-09-18 Thread GitBox
liyafan82 opened a new pull request #2156: URL: https://github.com/apache/calcite/pull/2156 See https://issues.apache.org/jira/browse/CALCITE-4260 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] rubenada opened a new pull request #2155: [CALCITE-4261] Join with three tables causes IllegalArgumentException in EnumerableBatchNestedLoopJoinRule

2020-09-18 Thread GitBox
rubenada opened a new pull request #2155: URL: https://github.com/apache/calcite/pull/2155 [CALCITE-4261] Join with three tables causes IllegalArgumentException in EnumerableBatchNestedLoopJoinRule This is an automated

[GitHub] [calcite] liyafan82 commented on a change in pull request #2154: [CALCITE-4223] Introducing column statistics

2020-09-18 Thread GitBox
liyafan82 commented on a change in pull request #2154: URL: https://github.com/apache/calcite/pull/2154#discussion_r490726798 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdDistinctRowCount.java ## @@ -79,6 +82,37 @@ public Double

[GitHub] [calcite] liyafan82 commented on a change in pull request #2154: [CALCITE-4223] Introducing column statistics

2020-09-18 Thread GitBox
liyafan82 commented on a change in pull request #2154: URL: https://github.com/apache/calcite/pull/2154#discussion_r490725620 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdDistinctRowCount.java ## @@ -79,6 +82,37 @@ public Double

[GitHub] [calcite] liyafan82 commented on a change in pull request #2154: [CALCITE-4223] Introducing column statistics

2020-09-18 Thread GitBox
liyafan82 commented on a change in pull request #2154: URL: https://github.com/apache/calcite/pull/2154#discussion_r490724502 ## File path: core/src/main/java/org/apache/calcite/plan/RelOptTable.java ## @@ -133,6 +134,16 @@ * same number of entries as there are fields,

[GitHub] [calcite] julianhyde merged pull request #2147: [CALCITE-4230] In Babel for BigQuery, split quoted table names that contain dots

2020-09-17 Thread GitBox
julianhyde merged pull request #2147: URL: https://github.com/apache/calcite/pull/2147 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] vlsi commented on a change in pull request #2153: [CALCITE-4259] Support JDK 15 and guava-29

2020-09-17 Thread GitBox
vlsi commented on a change in pull request #2153: URL: https://github.com/apache/calcite/pull/2153#discussion_r490194574 ## File path: site/_docs/history.md ## @@ -28,10 +28,21 @@ For a full list of releases, see Downloads are available on the [downloads page]({{

[GitHub] [calcite] rubenada merged pull request #2152: [CALCITE-4258] SqlToRelConverter: SELECT 1 IS [NOT] DISTINCT FROM NULL fails with AssertionError

2020-09-17 Thread GitBox
rubenada merged pull request #2152: URL: https://github.com/apache/calcite/pull/2152 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] chunweilei opened a new pull request #2154: [CALCITE-4223] Introducing column statistics

2020-09-17 Thread GitBox
chunweilei opened a new pull request #2154: URL: https://github.com/apache/calcite/pull/2154 JIRA: https://issues.apache.org/jira/browse/CALCITE-4223 This is an automated message from the Apache Git Service. To respond to

[GitHub] [calcite] zabetak commented on a change in pull request #2153: [CALCITE-4259] Support JDK 15 and guava-29

2020-09-17 Thread GitBox
zabetak commented on a change in pull request #2153: URL: https://github.com/apache/calcite/pull/2153#discussion_r490062939 ## File path: site/_docs/history.md ## @@ -28,10 +28,21 @@ For a full list of releases, see Downloads are available on the [downloads page]({{

[GitHub] [calcite] liyafan82 commented on a change in pull request #2151: [CALCITE-4155] Simplify IN expression of discrete values

2020-09-16 Thread GitBox
liyafan82 commented on a change in pull request #2151: URL: https://github.com/apache/calcite/pull/2151#discussion_r489962729 ## File path: core/src/main/java/org/apache/calcite/rex/RexBuilder.java ## @@ -1359,7 +1359,7 @@ public RexNode makeBetween(RexNode arg, RexNode lower,

[GitHub] [calcite] amaliujia commented on a change in pull request #2151: [CALCITE-4155] Simplify IN expression of discrete values

2020-09-16 Thread GitBox
amaliujia commented on a change in pull request #2151: URL: https://github.com/apache/calcite/pull/2151#discussion_r489898308 ## File path: core/src/main/java/org/apache/calcite/rex/RexBuilder.java ## @@ -1359,7 +1359,7 @@ public RexNode makeBetween(RexNode arg, RexNode lower,

[GitHub] [calcite] julianhyde opened a new pull request #2153: [CALCITE-4259] Support JDK 15 and guava-29

2020-09-16 Thread GitBox
julianhyde opened a new pull request #2153: URL: https://github.com/apache/calcite/pull/2153 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [calcite] yanlin-Lynn merged pull request #2117: [CALCITE-4182] Support mv recognition when query has constant filter for missing columns in group by list of mv

2020-09-16 Thread GitBox
yanlin-Lynn merged pull request #2117: URL: https://github.com/apache/calcite/pull/2117 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [calcite] rubenada opened a new pull request #2152: [CALCITE-4258] SqlToRelConverter: SELECT 1 IS [NOT] DISTINCT FROM NULL fails with AssertionError

2020-09-16 Thread GitBox
rubenada opened a new pull request #2152: URL: https://github.com/apache/calcite/pull/2152 Fixes root cause in RelOptPredicateList#isEffectivelyNotNull This is an automated message from the Apache Git Service. To respond to

[GitHub] [calcite] liyafan82 commented on pull request #2151: [CALCITE-4155] Simplify IN expression of discrete values

2020-09-16 Thread GitBox
liyafan82 commented on pull request #2151: URL: https://github.com/apache/calcite/pull/2151#issuecomment-693268091 @amaliujia Thank you in advance! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] amaliujia commented on pull request #2151: [CALCITE-4155] Simplify IN expression of discrete values

2020-09-16 Thread GitBox
amaliujia commented on pull request #2151: URL: https://github.com/apache/calcite/pull/2151#issuecomment-693210118 @liyafan82 I will try to give a code review soon. This is an automated message from the Apache Git Service.

[GitHub] [calcite] liyafan82 closed pull request #2098: [CALCITE-4155][WIP] Simplify IN expression of discrete values

2020-09-15 Thread GitBox
liyafan82 closed pull request #2098: URL: https://github.com/apache/calcite/pull/2098 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] liyafan82 opened a new pull request #2151: [CALCITE-4155] Simplify IN expression of discrete values

2020-09-15 Thread GitBox
liyafan82 opened a new pull request #2151: URL: https://github.com/apache/calcite/pull/2151 See https://issues.apache.org/jira/browse/CALCITE-4155 After introducing the Sarg framework, we need to support it based on that.

[GitHub] [calcite] liyafan82 commented on pull request #2098: [CALCITE-4155][WIP] Simplify IN expression of discrete values

2020-09-15 Thread GitBox
liyafan82 commented on pull request #2098: URL: https://github.com/apache/calcite/pull/2098#issuecomment-693126829 I am closing this, as the patch should be based on the new Sarg framework. Thank you for reviewing it @vlsi

[GitHub] [calcite] jamesstarr opened a new pull request #2150: CALCITE-4257 Parameterize CachingRelMetadataProvider.cached

2020-09-15 Thread GitBox
jamesstarr opened a new pull request #2150: URL: https://github.com/apache/calcite/pull/2150 Adding a constructor to all CachingRelMetadataProvider.cached to be passed, so end user can decide if they want to use LRU or soft reference cache.

[GitHub] [calcite] xy2953396112 closed pull request #2148: [CALCITE-4250] Failed to get original column of aggregate operator

2020-09-14 Thread GitBox
xy2953396112 closed pull request #2148: URL: https://github.com/apache/calcite/pull/2148 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [calcite] rubenada commented on pull request #2143: [CALCITE-4224] Add an method for RelNode to output its tree digest like RelOptUtil.toString (Jiatao Tao)

2020-09-14 Thread GitBox
rubenada commented on pull request #2143: URL: https://github.com/apache/calcite/pull/2143#issuecomment-691871301 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] liyafan82 commented on a change in pull request #2146: [CALCITE-4241] Some improvements to metadata query

2020-09-13 Thread GitBox
liyafan82 commented on a change in pull request #2146: URL: https://github.com/apache/calcite/pull/2146#discussion_r487628337 ## File path: core/src/test/java/org/apache/calcite/test/RelMetadataTest.java ## @@ -918,6 +918,28 @@ private void checkRelSelectivity( @Test void

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2143: [CALCITE-4224] Add an method for RelNode to output its tree digest like RelOptUtil.toString (Jiatao Tao)

2020-09-13 Thread GitBox
Aaron commented on a change in pull request #2143: URL: https://github.com/apache/calcite/pull/2143#discussion_r487622205 ## File path: core/src/main/java/org/apache/calcite/rel/RelNode.java ## @@ -222,6 +223,22 @@ */ void explain(RelWriter pw); + /** + *

[GitHub] [calcite] chunweilei commented on pull request #2148: [CALCITE-4250] Failed to get original column of aggregate operator

2020-09-13 Thread GitBox
chunweilei commented on pull request #2148: URL: https://github.com/apache/calcite/pull/2148#issuecomment-691773724 Seems duplicate with https://github.com/apache/calcite/pull/2121. This is an automated message from the

[GitHub] [calcite] chunweilei merged pull request #2145: [CALCITE-4239] RelMdUniqueKeys returns wrong unique keys for Aggregate with grouping sets

2020-09-13 Thread GitBox
chunweilei merged pull request #2145: URL: https://github.com/apache/calcite/pull/2145 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] chunweilei commented on a change in pull request #2148: [CALCITE-4250] Failed to get original column of aggregate operator

2020-09-13 Thread GitBox
chunweilei commented on a change in pull request #2148: URL: https://github.com/apache/calcite/pull/2148#discussion_r487616657 ## File path: core/src/test/java/org/apache/calcite/materialize/NormalizationTrimFieldTest.java ## @@ -105,4 +108,25 @@ final String

[GitHub] [calcite] chunweilei commented on a change in pull request #2146: [CALCITE-4241] Some improvements to metadata query

2020-09-13 Thread GitBox
chunweilei commented on a change in pull request #2146: URL: https://github.com/apache/calcite/pull/2146#discussion_r487615286 ## File path: core/src/test/java/org/apache/calcite/test/RelMetadataTest.java ## @@ -918,6 +918,28 @@ private void checkRelSelectivity( @Test

[GitHub] [calcite] chunweilei merged pull request #2128: [CALCITE-4197] Provide utility to visualize RelNode plans

2020-09-13 Thread GitBox
chunweilei merged pull request #2128: URL: https://github.com/apache/calcite/pull/2128 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] amaliujia commented on a change in pull request #2143: [CALCITE-4224] Add an method for RelNode to output its tree digest like RelOptUtil.toString (Jiatao Tao)

2020-09-12 Thread GitBox
amaliujia commented on a change in pull request #2143: URL: https://github.com/apache/calcite/pull/2143#discussion_r487468101 ## File path: core/src/main/java/org/apache/calcite/rel/RelNode.java ## @@ -222,6 +223,22 @@ */ void explain(RelWriter pw); + /** + *

[GitHub] [calcite] cuglifangzheng commented on a change in pull request #2121: [CALCITE-4192] RelMdColumnOrigins should obtain the true column index of the group by column of the aggregation operator

2020-09-12 Thread GitBox
cuglifangzheng commented on a change in pull request #2121: URL: https://github.com/apache/calcite/pull/2121#discussion_r487359768 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ## @@ -6764,4 +6769,25 @@ protected MyProjectRule(Config config) {

[GitHub] [calcite] xy2953396112 commented on a change in pull request #2148: [CALCITE-4250] Failed to get original column of aggregate operator

2020-09-12 Thread GitBox
xy2953396112 commented on a change in pull request #2148: URL: https://github.com/apache/calcite/pull/2148#discussion_r487388133 ## File path: core/src/test/java/org/apache/calcite/materialize/NormalizationTrimFieldTest.java ## @@ -105,4 +107,25 @@ final String

[GitHub] [calcite] chunweilei commented on pull request #2128: [CALCITE-4197] Provide utility to visualize RelNode plans

2020-09-12 Thread GitBox
chunweilei commented on pull request #2128: URL: https://github.com/apache/calcite/pull/2128#issuecomment-690930458 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2143: [CALCITE-4224] Add an method for RelNode to output its tree digest like RelOptUtil.toString (Jiatao Tao)

2020-09-12 Thread GitBox
Aaron commented on a change in pull request #2143: URL: https://github.com/apache/calcite/pull/2143#discussion_r487387680 ## File path: core/src/main/java/org/apache/calcite/rel/RelNode.java ## @@ -232,6 +233,21 @@ */ RelNode onRegister(RelOptPlanner planner); +

[GitHub] [calcite] vlsi commented on a change in pull request #2148: [CALCITE-4250] Failed to get original column of aggregate operator

2020-09-12 Thread GitBox
vlsi commented on a change in pull request #2148: URL: https://github.com/apache/calcite/pull/2148#discussion_r487386711 ## File path: core/src/test/java/org/apache/calcite/materialize/NormalizationTrimFieldTest.java ## @@ -105,4 +107,25 @@ final String relOptimizedStr =

[GitHub] [calcite] liyafan82 commented on pull request #2128: [CALCITE-4197] Provide utility to visualize RelNode plans

2020-09-12 Thread GitBox
liyafan82 commented on pull request #2128: URL: https://github.com/apache/calcite/pull/2128#issuecomment-690941436 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [calcite] chunweilei commented on a change in pull request #2145: [CALCITE-4239] RelMdUniqueKeys returns wrong unique keys for Aggregate with grouping sets

2020-09-12 Thread GitBox
chunweilei commented on a change in pull request #2145: URL: https://github.com/apache/calcite/pull/2145#discussion_r486822423 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdUniqueKeys.java ## @@ -246,8 +246,14 @@ private RelMdUniqueKeys() {}

[GitHub] [calcite] liyafan82 commented on a change in pull request #2146: [CALCITE-4241] Some improvements to metadata query

2020-09-12 Thread GitBox
liyafan82 commented on a change in pull request #2146: URL: https://github.com/apache/calcite/pull/2146#discussion_r486854367 ## File path: core/src/main/java/org/apache/calcite/rel/rules/LoptOptimizeJoinRule.java ## @@ -2064,7 +2064,7 @@ private static boolean

[GitHub] [calcite] liyafan82 commented on a change in pull request #2145: [CALCITE-4239] RelMdUniqueKeys returns wrong unique keys for Aggregate with grouping sets

2020-09-12 Thread GitBox
liyafan82 commented on a change in pull request #2145: URL: https://github.com/apache/calcite/pull/2145#discussion_r486839323 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdUniqueKeys.java ## @@ -246,8 +246,14 @@ private RelMdUniqueKeys() {} public

[GitHub] [calcite] liyafan82 commented on a change in pull request #2121: [CALCITE-4192] RelMdColumnOrigins should obtain the true column index of the group by column of the aggregation operator inste

2020-09-12 Thread GitBox
liyafan82 commented on a change in pull request #2121: URL: https://github.com/apache/calcite/pull/2121#discussion_r486795640 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ## @@ -6764,4 +6769,25 @@ protected MyProjectRule(Config config) {

[GitHub] [calcite] michaelmior commented on a change in pull request #2133: [CALCITE-2040] Arrow adapter

2020-09-12 Thread GitBox
michaelmior commented on a change in pull request #2133: URL: https://github.com/apache/calcite/pull/2133#discussion_r487008505 ## File path: arrow/src/test/java/org/apache/calcite/adapter/arrow/ArrowTest.java ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software

[GitHub] [calcite] xy2953396112 closed pull request #2149: [MINOR] Visit Calc operator in RelShuttle

2020-09-12 Thread GitBox
xy2953396112 closed pull request #2149: URL: https://github.com/apache/calcite/pull/2149 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] rubenada commented on a change in pull request #2143: [CALCITE-4224] Add an method for RelNode to output its tree digest like RelOptUtil.toString (Jiatao Tao)

2020-09-12 Thread GitBox
rubenada commented on a change in pull request #2143: URL: https://github.com/apache/calcite/pull/2143#discussion_r486848210 ## File path: core/src/main/java/org/apache/calcite/rel/RelNode.java ## @@ -232,6 +233,21 @@ */ RelNode onRegister(RelOptPlanner planner); +

[GitHub] [calcite] chunweilei commented on a change in pull request #2146: [CALCITE-4241] Some improvements to metadata query

2020-09-12 Thread GitBox
chunweilei commented on a change in pull request #2146: URL: https://github.com/apache/calcite/pull/2146#discussion_r486827094 ## File path: core/src/main/java/org/apache/calcite/rel/rules/LoptOptimizeJoinRule.java ## @@ -2064,7 +2064,7 @@ private static boolean

[GitHub] [calcite] cuglifangzheng commented on a change in pull request #2121: [CALCITE-4192] RelMdColumnOrigins should obtain the true column index of the group by column of the aggregation operator

2020-09-12 Thread GitBox
cuglifangzheng commented on a change in pull request #2121: URL: https://github.com/apache/calcite/pull/2121#discussion_r487359768 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ## @@ -6764,4 +6769,25 @@ protected MyProjectRule(Config config) {

[GitHub] [calcite] xy2953396112 commented on a change in pull request #2148: [CALCITE-4250] Failed to get original column of aggregate operator

2020-09-12 Thread GitBox
xy2953396112 commented on a change in pull request #2148: URL: https://github.com/apache/calcite/pull/2148#discussion_r487388133 ## File path: core/src/test/java/org/apache/calcite/materialize/NormalizationTrimFieldTest.java ## @@ -105,4 +107,25 @@ final String

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2143: [CALCITE-4224] Add an method for RelNode to output its tree digest like RelOptUtil.toString (Jiatao Tao)

2020-09-12 Thread GitBox
Aaron commented on a change in pull request #2143: URL: https://github.com/apache/calcite/pull/2143#discussion_r487387680 ## File path: core/src/main/java/org/apache/calcite/rel/RelNode.java ## @@ -232,6 +233,21 @@ */ RelNode onRegister(RelOptPlanner planner); +

[GitHub] [calcite] chunweilei commented on pull request #2128: [CALCITE-4197] Provide utility to visualize RelNode plans

2020-09-12 Thread GitBox
chunweilei commented on pull request #2128: URL: https://github.com/apache/calcite/pull/2128#issuecomment-690930458 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [calcite] vlsi commented on a change in pull request #2148: [CALCITE-4250] Failed to get original column of aggregate operator

2020-09-12 Thread GitBox
vlsi commented on a change in pull request #2148: URL: https://github.com/apache/calcite/pull/2148#discussion_r487386711 ## File path: core/src/test/java/org/apache/calcite/materialize/NormalizationTrimFieldTest.java ## @@ -105,4 +107,25 @@ final String relOptimizedStr =

[GitHub] [calcite] liyafan82 commented on a change in pull request #2146: [CALCITE-4241] Some improvements to metadata query

2020-09-12 Thread GitBox
liyafan82 commented on a change in pull request #2146: URL: https://github.com/apache/calcite/pull/2146#discussion_r486854367 ## File path: core/src/main/java/org/apache/calcite/rel/rules/LoptOptimizeJoinRule.java ## @@ -2064,7 +2064,7 @@ private static boolean

[GitHub] [calcite] rubenada commented on a change in pull request #2143: [CALCITE-4224] Add an method for RelNode to output its tree digest like RelOptUtil.toString (Jiatao Tao)

2020-09-12 Thread GitBox
rubenada commented on a change in pull request #2143: URL: https://github.com/apache/calcite/pull/2143#discussion_r486848210 ## File path: core/src/main/java/org/apache/calcite/rel/RelNode.java ## @@ -232,6 +233,21 @@ */ RelNode onRegister(RelOptPlanner planner); +

[GitHub] [calcite] liyafan82 commented on a change in pull request #2121: [CALCITE-4192] RelMdColumnOrigins should obtain the true column index of the group by column of the aggregation operator inste

2020-09-12 Thread GitBox
liyafan82 commented on a change in pull request #2121: URL: https://github.com/apache/calcite/pull/2121#discussion_r486795640 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ## @@ -6764,4 +6769,25 @@ protected MyProjectRule(Config config) {

[GitHub] [calcite] liyafan82 commented on a change in pull request #2145: [CALCITE-4239] RelMdUniqueKeys returns wrong unique keys for Aggregate with grouping sets

2020-09-12 Thread GitBox
liyafan82 commented on a change in pull request #2145: URL: https://github.com/apache/calcite/pull/2145#discussion_r486839323 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdUniqueKeys.java ## @@ -246,8 +246,14 @@ private RelMdUniqueKeys() {} public

  1   2   3   4   5   6   7   8   9   10   >