[GitHub] [calcite] rubenada commented on pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-29 Thread GitBox 


rubenada commented on pull request #2035:
URL: https://github.com/apache/calcite/pull/2035#issuecomment-651017132


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [calcite] rubenada commented on pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-29 Thread GitBox 


rubenada commented on pull request #2035:
URL: https://github.com/apache/calcite/pull/2035#issuecomment-650978346


   Thanks @hsyuan .
   @amaliujia do you think there is any other issue to be addressed? Could we 
consider squash commits and merge?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [calcite] rubenada commented on pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-26 Thread GitBox 


rubenada commented on pull request #2035:
URL: https://github.com/apache/calcite/pull/2035#issuecomment-650038139


   Thanks for your work @amaliujia !
   I think the PR looks good (just need to squash commits).
   @hsyuan do you want to take a final look?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [calcite] rubenada commented on pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-19 Thread GitBox 


rubenada commented on pull request #2035:
URL: https://github.com/apache/calcite/pull/2035#issuecomment-646697215


   Sure, @hsyuan , I'll take a look



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org