[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2030: [CALCITE-4098] Remove redundant code in "RelJson.toJson(RelDistribution)".

[GitBox]

Aaron commented on a change in pull request #2030:
URL: https://github.com/apache/calcite/pull/2030#discussion_r448445136



##
File path: core/src/test/java/org/apache/calcite/plan/RelWriterTest.java
##
@@ -872,6 +900,20 @@ private RelNode mockCountOver(String table,
 return rel;
   }
 
+  @Test void testHashDistributionWithoutKeys() {
+final RelNode root = createSortPlan(RelDistributions.hash(new 
ArrayList<>()));
+final RelJsonWriter writer = new RelJsonWriter();

Review comment:
   > Use `Collections.emptyList()` instead of `new ArrayList<>()`.
   
   Thanks for your suggestion, updated already.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2030: [CALCITE-4098] Remove redundant code in "RelJson.toJson(RelDistribution)".

[GitBox]

Aaron commented on a change in pull request #2030:
URL: https://github.com/apache/calcite/pull/2030#discussion_r448442551



##
File path: core/src/test/java/org/apache/calcite/plan/RelWriterTest.java
##
@@ -385,6 +385,34 @@
   + "  ]\n"
   + "}";
 
+  public static final String XX4 = "{\n"
+  + "  \"rels\": [\n"
+  + "{\n"
+  + "  \"id\": \"0\",\n"

Review comment:
   The name follows the style above, I'll update it





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org