[GitHub] [calcite] chunweilei commented on issue #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI…

2019-05-16 Thread GitBox
chunweilei commented on issue #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI… URL: https://github.com/apache/calcite/pull/1140#issuecomment-493308964 Update to resolve conflicts. This is an

[GitHub] [calcite] chunweilei commented on issue #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI…

2019-05-16 Thread GitBox
chunweilei commented on issue #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI… URL: https://github.com/apache/calcite/pull/1140#issuecomment-493300057 Update to fix build fail. This is an

[GitHub] [calcite] chunweilei commented on issue #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI…

2019-05-15 Thread GitBox
chunweilei commented on issue #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI… URL: https://github.com/apache/calcite/pull/1140#issuecomment-492904833 Rebase the PR to resolve confilcts. This is

[GitHub] [calcite] chunweilei commented on issue #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI…

2019-04-03 Thread GitBox
chunweilei commented on issue #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI… URL: https://github.com/apache/calcite/pull/1140#issuecomment-479363494 @hsyuan Updated. Thank you for your review. But I am afraid that it should not be merged until we come to an