[GitHub] [calcite] danny0405 commented on pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

2020-06-18 Thread GitBox
danny0405 commented on pull request #2016: URL: https://github.com/apache/calcite/pull/2016#issuecomment-645923910 > Regarding my concern about memory usage, I was talking about `Digest` and the extra list used to store `items` which is kind of redundant with the `RelNode` itself. An

[GitHub] [calcite] danny0405 commented on pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

2020-06-16 Thread GitBox
danny0405 commented on pull request #2016: URL: https://github.com/apache/calcite/pull/2016#issuecomment-644621579 > Regarding my concern about memory usage, I was talking about `Digest` and the extra list used to store `items` which is kind of redundant with the `RelNode` itself. An

[GitHub] [calcite] danny0405 commented on pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

2020-06-12 Thread GitBox
danny0405 commented on pull request #2016: URL: https://github.com/apache/calcite/pull/2016#issuecomment-643544569 > I have to say that I don't see how this pull request makes hash code more efficient (precomputation of hashcode?). For sure it looks to increase memory usage and also