[GitHub] [calcite] eolivelli commented on pull request #1976: [CALCITE-3997] Logical rules matched with physical operators but failed to handle traits

eolivelli commented on pull request #1976: URL: https://github.com/apache/calcite/pull/1976#issuecomment-628738883 btw I see now that you added a marker interface. It is a big change. But I don't have enough context in order to give a suggestion

[GitHub] [calcite] eolivelli commented on pull request #1976: [CALCITE-3997] Logical rules matched with physical operators but failed to handle traits

eolivelli commented on pull request #1976: URL: https://github.com/apache/calcite/pull/1976#issuecomment-628737545 @hsyuan it looks like you modified 92 files... IMHO it would be better to narrow down the patch to the minimal set of changes, in order to prevent conflicts with other

[GitHub] [calcite] eolivelli commented on pull request #1976: [CALCITE-3997] Logical rules matched with physical operators but failed to handle traits

eolivelli commented on pull request #1976: URL: https://github.com/apache/calcite/pull/1976#issuecomment-628737002 @hsyuan thank you ! @vlsi Do you know how to build locally this branch and put the jars into local Maven repository ? this way I can test this branch against my