[GitHub] [calcite] hsyuan commented on issue #1840: [CALCITE-3753] Remove rule queue importance

2020-03-08 Thread GitBox
hsyuan commented on issue #1840: [CALCITE-3753] Remove rule queue importance URL: https://github.com/apache/calcite/pull/1840#issuecomment-596266573 Thanks everyone for reviewing. I will merge this PR in 24 hours. This is an

[GitHub] [calcite] hsyuan commented on issue #1840: [CALCITE-3753] Remove rule queue importance

2020-03-06 Thread GitBox
hsyuan commented on issue #1840: [CALCITE-3753] Remove rule queue importance URL: https://github.com/apache/calcite/pull/1840#issuecomment-596050901 @zabetak Thanks for reminding. Will update it. This is an automated message

[GitHub] [calcite] hsyuan commented on issue #1840: [CALCITE-3753] Remove rule queue importance

2020-03-01 Thread GitBox
hsyuan commented on issue #1840: [CALCITE-3753] Remove rule queue importance URL: https://github.com/apache/calcite/pull/1840#issuecomment-593202058 > Plan diffs are more than what i expected, BTW, what is the diff tool, it looks pretty good ~ It is diffchecker.

[GitHub] [calcite] hsyuan commented on issue #1840: [CALCITE-3753] Remove rule queue importance

2020-03-01 Thread GitBox
hsyuan commented on issue #1840: [CALCITE-3753] Remove rule queue importance URL: https://github.com/apache/calcite/pull/1840#issuecomment-593073365 Here is one example: ![image](https://user-images.githubusercontent.com/15352793/75622812-095d6c80-5b6a-11ea-9cb6-3053622c5e6d.png)

[GitHub] [calcite] hsyuan commented on issue #1840: [CALCITE-3753] Remove rule queue importance

2020-03-01 Thread GitBox
hsyuan commented on issue #1840: [CALCITE-3753] Remove rule queue importance URL: https://github.com/apache/calcite/pull/1840#issuecomment-593072264 All the plan diffs in this patch are either with same or less cost. This is