[GitHub] [calcite] julianhyde commented on pull request #2161: [CALCITE-4240] Fix SqlTypeUtil#getMaxPrecisionScaleDecimal returns a decimal that with same precision and scale(Jiatao Tao)

2020-09-22 Thread GitBox
julianhyde commented on pull request #2161: URL: https://github.com/apache/calcite/pull/2161#issuecomment-696393247 Remove the word 'fix' from the commit message. Change the message so that it is clear what the bug is. Why would `DECIMAL(10, 28)` not be valid? Say if you are measurin

[GitHub] [calcite] julianhyde commented on pull request #2161: [CALCITE-4240] Fix SqlTypeUtil#getMaxPrecisionScaleDecimal returns a decimal that with same precision and scale(Jiatao Tao)

2020-09-21 Thread GitBox
julianhyde commented on pull request #2161: URL: https://github.com/apache/calcite/pull/2161#issuecomment-696393247 Remove the word 'fix' from the commit message. Change the message so that it is clear what the bug is. Why would `DECIMAL(10, 28)` not be valid? Say if you are measurin

[GitHub] [calcite] julianhyde commented on pull request #2161: [CALCITE-4240] Fix SqlTypeUtil#getMaxPrecisionScaleDecimal returns a decimal that with same precision and scale(Jiatao Tao)

2020-09-21 Thread GitBox
julianhyde commented on pull request #2161: URL: https://github.com/apache/calcite/pull/2161#issuecomment-696393247 Remove the word 'fix' from the commit message. Change the message so that it is clear what the bug is. Why would `DECIMAL(10, 28)` not be valid? Say if you are measurin