[GitHub] [calcite] liuyongvs commented on pull request #3212: [CALCITE-5710] Add ARRAY_MAX, ARRAY_MIN function (enabled in Spark li…
liuyongvs commented on PR #3212: URL: https://github.com/apache/calcite/pull/3212#issuecomment-1574711103 hi @snuyanzin thanks for your review, this method justs merged a few days and also in the 1.35 version(snapshot), which don't have released, we think the method name is not good for search, which builtin function belongs to -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [calcite] liuyongvs commented on pull request #3212: [CALCITE-5710] Add ARRAY_MAX, ARRAY_MIN function (enabled in Spark li…
liuyongvs commented on PR #3212: URL: https://github.com/apache/calcite/pull/3212#issuecomment-1574695041 hi @JiajunBernoulli could it be merged otherwise it will conflict with SORT_ARRAY when ci passed. i just fix conflict -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [calcite] liuyongvs commented on pull request #3212: [CALCITE-5710] Add ARRAY_MAX, ARRAY_MIN function (enabled in Spark li…
liuyongvs commented on PR #3212: URL: https://github.com/apache/calcite/pull/3212#issuecomment-1573782725 @JiajunBernoulli git rebase to fix conflicts with main branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [calcite] liuyongvs commented on pull request #3212: [CALCITE-5710] Add ARRAY_MAX, ARRAY_MIN function (enabled in Spark li…
liuyongvs commented on PR #3212: URL: https://github.com/apache/calcite/pull/3212#issuecomment-1573106351 @JiajunBernoulli fix all your reviews and squash the commits -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [calcite] liuyongvs commented on pull request #3212: [CALCITE-5710] Add ARRAY_MAX, ARRAY_MIN function (enabled in Spark li…
liuyongvs commented on PR #3212: URL: https://github.com/apache/calcite/pull/3212#issuecomment-1571084929 hi @tanclary do you also have time to review it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [calcite] liuyongvs commented on pull request #3212: [CALCITE-5710] Add ARRAY_MAX, ARRAY_MIN function (enabled in Spark li…
liuyongvs commented on PR #3212: URL: https://github.com/apache/calcite/pull/3212#issuecomment-1569283175 hi @tanclary @MasseGuillaume @JiajunBernoulli fix all your reviews -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [calcite] liuyongvs commented on pull request #3212: [CALCITE-5710] Add ARRAY_MAX, ARRAY_MIN function (enabled in Spark li…
liuyongvs commented on PR #3212: URL: https://github.com/apache/calcite/pull/3212#issuecomment-1566106615 hi @NobiGo do you have time to help review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [calcite] liuyongvs commented on pull request #3212: [CALCITE-5710] Add ARRAY_MAX, ARRAY_MIN function (enabled in Spark li…
liuyongvs commented on PR #3212: URL: https://github.com/apache/calcite/pull/3212#issuecomment-1552769423 hi @JiajunBernoulli will you also review it if you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
