[GitHub] [calcite] liuyongvs commented on pull request #3238: [CALCITE-5744] Add STR_TO_MAP function (enabled in Spark library)
liuyongvs commented on PR #3238: URL: https://github.com/apache/calcite/pull/3238#issuecomment-1577872882 hi @tanclary thanks for your review and your several valuable suggestion +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [calcite] liuyongvs commented on pull request #3238: [CALCITE-5744] Add STR_TO_MAP function (enabled in Spark library)
liuyongvs commented on PR #3238: URL: https://github.com/apache/calcite/pull/3238#issuecomment-1577700324 Hi @tanclary do you also have time to review this pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [calcite] liuyongvs commented on pull request #3238: [CALCITE-5744] Add STR_TO_MAP function (enabled in Spark library)
liuyongvs commented on PR #3238: URL: https://github.com/apache/calcite/pull/3238#issuecomment-1575636104 hi @tanclary @JiajunBernoulli @MasseGuillaume do you have time to help review ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [calcite] liuyongvs commented on pull request #3238: [CALCITE-5744] Add STR_TO_MAP function (enabled in Spark library)
liuyongvs commented on PR #3238: URL: https://github.com/apache/calcite/pull/3238#issuecomment-1574969753 hi @JiajunBernoulli close the map_from_array pr , and one pr for the two commits -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [calcite] liuyongvs commented on pull request #3238: [CALCITE-5744] Add STR_TO_MAP function (enabled in Spark library)
liuyongvs commented on PR #3238: URL: https://github.com/apache/calcite/pull/3238#issuecomment-1573584337 hi @JiajunBernoulli @tanclary @MasseGuillaume do you have time to review this ,just review STR_TO_MAP and after the former commits merged, i will rebase it.otherwise, it will lots of conflict -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org