rubenada commented on pull request #2035:
URL: https://github.com/apache/calcite/pull/2035#issuecomment-651017132
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rubenada commented on pull request #2035:
URL: https://github.com/apache/calcite/pull/2035#issuecomment-650978346
Thanks @hsyuan .
@amaliujia do you think there is any other issue to be addressed? Could we
consider squash commits and merge?
rubenada commented on pull request #2035:
URL: https://github.com/apache/calcite/pull/2035#issuecomment-650038139
Thanks for your work @amaliujia !
I think the PR looks good (just need to squash commits).
@hsyuan do you want to take a final look?
rubenada commented on pull request #2035:
URL: https://github.com/apache/calcite/pull/2035#issuecomment-646697215
Sure, @hsyuan , I'll take a look
This is an automated message from the Apache Git Service.
To respond to the
