[GitHub] [calcite] siddharthteotia commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary

siddharthteotia commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary URL: https://github.com/apache/calcite/pull/1033#issuecomment-478759476 > @siddharthteotia there are build failures. Can you pls fix them ? @asereda-gs ,

[GitHub] [calcite] siddharthteotia commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary

siddharthteotia commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary URL: https://github.com/apache/calcite/pull/1033#issuecomment-478707030 Rebased. This is an

[GitHub] [calcite] siddharthteotia commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary

siddharthteotia commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary URL: https://github.com/apache/calcite/pull/1033#issuecomment-472957589 @zabetak , can this be merged?

[GitHub] [calcite] siddharthteotia commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary

siddharthteotia commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary URL: https://github.com/apache/calcite/pull/1033#issuecomment-472086793 > I am OK for removing the throws. Let's do this last change :) done

[GitHub] [calcite] siddharthteotia commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary

siddharthteotia commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary URL: https://github.com/apache/calcite/pull/1033#issuecomment-471744821 > @zabetak Thanks for the review. I agree with everything you have said, except adding

[GitHub] [calcite] siddharthteotia commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary

siddharthteotia commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary URL: https://github.com/apache/calcite/pull/1033#issuecomment-471637077 @zabetak , I have addressed the latest comments, rebased and squashed the commits.