[GitHub] [calcite] tanclary commented on a diff in pull request #3303: [CALCITE-5827] Add IS_INF and IS_NAN functions (enabled in BigQuery l…

tanclary commented on code in PR #3303: URL: https://github.com/apache/calcite/pull/3303#discussion_r1286101447 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -6618,6 +6618,64 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] tanclary commented on a diff in pull request #3303: [CALCITE-5827] Add IS_INF and IS_NAN functions (enabled in BigQuery l…

tanclary commented on code in PR #3303: URL: https://github.com/apache/calcite/pull/3303#discussion_r1283866205 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -2106,6 +2106,11 @@ public static boolean isInf(double b0) { return

[GitHub] [calcite] tanclary commented on a diff in pull request #3303: [CALCITE-5827] Add IS_INF and IS_NAN functions (enabled in BigQuery l…

tanclary commented on code in PR #3303: URL: https://github.com/apache/calcite/pull/3303#discussion_r1266940303 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -6618,6 +6618,60 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] tanclary commented on a diff in pull request #3303: [CALCITE-5827] Add IS_INF and IS_NAN functions (enabled in BigQuery l…

tanclary commented on code in PR #3303: URL: https://github.com/apache/calcite/pull/3303#discussion_r1260312377 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -2106,6 +2106,11 @@ public static boolean isInf(double b0) { return

[GitHub] [calcite] tanclary commented on a diff in pull request #3303: [CALCITE-5827] Add IS_INF and IS_NAN functions (enabled in BigQuery l…

tanclary commented on code in PR #3303: URL: https://github.com/apache/calcite/pull/3303#discussion_r1260289501 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -2106,6 +2106,11 @@ public static boolean isInf(double b0) { return

[GitHub] [calcite] tanclary commented on a diff in pull request #3303: [CALCITE-5827] Add IS_INF and IS_NAN functions (enabled in BigQuery l…

tanclary commented on code in PR #3303: URL: https://github.com/apache/calcite/pull/3303#discussion_r1260109468 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -6618,6 +6618,34 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] tanclary commented on a diff in pull request #3303: [CALCITE-5827] Add IS_INF and IS_NAN functions (enabled in BigQuery l…

tanclary commented on code in PR #3303: URL: https://github.com/apache/calcite/pull/3303#discussion_r1260109063 ## site/_docs/reference.md: ## @@ -2731,6 +2731,8 @@ BigQuery's type system uses confusingly different names for types and functions: | b | IFNULL(value1, value2)

[GitHub] [calcite] tanclary commented on a diff in pull request #3303: [CALCITE-5827] Add IS_INF and IS_NAN functions (enabled in BigQuery l…

tanclary commented on code in PR #3303: URL: https://github.com/apache/calcite/pull/3303#discussion_r1258640714 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -6618,6 +6618,34 @@ private static void checkIf(SqlOperatorFixture f) {