vlsi commented on pull request #1929:
URL: https://github.com/apache/calcite/pull/1929#issuecomment-683428235
Ok, now `linq4j` passes the verification.
This is an automated message from the Apache Git Service.
To respond to
vlsi commented on pull request #1929:
URL: https://github.com/apache/calcite/pull/1929#issuecomment-683349305
Just in case, `linq4j:compileJava` says there are only 46 errors left :)
This is an automated message from the
vlsi commented on pull request #1929:
URL: https://github.com/apache/calcite/pull/1929#issuecomment-663597315
> So far I see there are no @NonNull annotations in the codebase
The suggested behavior is `non-null` by default, so I have not added it yet.
It should be enough to
vlsi commented on pull request #1929:
URL: https://github.com/apache/calcite/pull/1929#issuecomment-657549239
Just in case, I've added `nullability` annotations to `pgjdbc`.
Here's what it becomes: https://github.com/pgjdbc/pgjdbc/pull/1814
An interesting note is that I had to add
vlsi commented on pull request #1929:
URL: https://github.com/apache/calcite/pull/1929#issuecomment-646750826
You are right, there's not enough annotations.
The idea was that once all the annotations are there, we could enforce the
check for all the commits.
Feel free to pick it
