[GitHub] [calcite] zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-03-21 Thread GitBox
zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#discussion_r267639290 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlJsonApiCommonSyntaxWithoutPathOperator.java

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-03-17 Thread GitBox
zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#discussion_r266234449 ## File path: core/src/main/java/org/apache/calcite/runtime/CalciteResource.java ## @@ -43,6 +43,9

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-03-16 Thread GitBox
zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#discussion_r266224659 ## File path: core/src/main/java/org/apache/calcite/runtime/CalciteResource.java ## @@ -43,6 +43,9

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-03-16 Thread GitBox
zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#discussion_r266224659 ## File path: core/src/main/java/org/apache/calcite/runtime/CalciteResource.java ## @@ -43,6 +43,9

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-03-15 Thread GitBox
zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#discussion_r265861435 ## File path: core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java ## @@

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-03-14 Thread GitBox
zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#discussion_r265506772 ## File path: core/src/main/codegen/templates/Parser.jj ## @@ -4988,7 +5000,7 @@ SqlCall

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-03-14 Thread GitBox
zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#discussion_r265504602 ## File path: core/src/main/codegen/templates/Parser.jj ## @@ -4927,21 +4929,32 @@ SqlNode

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-03-14 Thread GitBox
zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#discussion_r265503576 ## File path: core/src/main/codegen/templates/Parser.jj ## @@ -5300,6 +5312,30 @@ SqlCall

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-03-11 Thread GitBox
zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#discussion_r264505551 ## File path: core/src/main/codegen/templates/Parser.jj ## @@ -5300,6 +5302,30 @@ SqlCall

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-03-11 Thread GitBox
zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#discussion_r264505551 ## File path: core/src/main/codegen/templates/Parser.jj ## @@ -5300,6 +5302,30 @@ SqlCall

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-03-11 Thread GitBox
zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#discussion_r264211919 ## File path: core/src/main/codegen/templates/Parser.jj ## @@ -5300,6 +5302,30 @@ SqlCall

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-03-11 Thread GitBox
zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#discussion_r264211919 ## File path: core/src/main/codegen/templates/Parser.jj ## @@ -5300,6 +5302,30 @@ SqlCall

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-03-05 Thread GitBox
zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#discussion_r262384794 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java ## @@ -137,9 +134,6 @@

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-03-05 Thread GitBox
zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#discussion_r262381412 ## File path: site/_docs/reference.md ## @@ -2005,6 +2006,7 @@ Note: | JSON_TYPE(value)

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-03-05 Thread GitBox
zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#discussion_r262382023 ## File path: core/src/test/java/org/apache/calcite/test/SqlJsonFunctionsTest.java ## @@ -55,6

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-03-04 Thread GitBox
zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#discussion_r262381729 ## File path: core/src/test/java/org/apache/calcite/test/RexProgramTest.java ## @@ -1223,37 +1223,37

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-03-04 Thread GitBox
zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#discussion_r262377232 ## File path: core/src/main/codegen/templates/Parser.jj ## @@ -5300,6 +5302,30 @@ SqlCall

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-03-04 Thread GitBox
zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#discussion_r262373989 ## File path: babel/src/main/codegen/config.fmpp ## @@ -141,6 +141,7 @@ data: { "JSON"