(camel) 03/05: (chores) camel-core: fixed bogus test assertions

[orpiske]

This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit beafab729fb8039117b3cb89add9c37da0d3ba7b
Author: Otavio Rodolfo Piske <angusyo...@gmail.com>
AuthorDate: Wed Apr 10 11:17:42 2024 +0200

    (chores) camel-core: fixed bogus test assertions
---
 .../camel/component/xslt/XsltFromHeaderOverrideEndpointUriTest.java     | 2 +-
 .../component/xslt/XsltTemplateFromHeaderOverrideEndpointUriTest.java   | 2 +-
 .../apache/camel/impl/CamelContextAddRouteDefinitionsFromXmlTest.java   | 1 -
 .../test/java/org/apache/camel/impl/converter/TypeConvertersTest.java   | 2 +-
 4 files changed, 3 insertions(+), 4 deletions(-)

diff --git 
a/core/camel-core/src/test/java/org/apache/camel/component/xslt/XsltFromHeaderOverrideEndpointUriTest.java
 
b/core/camel-core/src/test/java/org/apache/camel/component/xslt/XsltFromHeaderOverrideEndpointUriTest.java
index bd5182ebc01..0a95d477f80 100644
--- 
a/core/camel-core/src/test/java/org/apache/camel/component/xslt/XsltFromHeaderOverrideEndpointUriTest.java
+++ 
b/core/camel-core/src/test/java/org/apache/camel/component/xslt/XsltFromHeaderOverrideEndpointUriTest.java
@@ -46,7 +46,7 @@ public class XsltFromHeaderOverrideEndpointUriTest extends 
ContextTestSupport {
         Exchange exchange = list.get(0);
         String xml = exchange.getIn().getBody(String.class);
 
-        assertNotNull("The transformed XML should not be null", xml);
+        assertNotNull(xml, "The transformed XML should not be null");
         assertTrue(xml.contains("transformed"));
         // the foo tag is in the transform_to_foo.xsl which is what we want. 
If this didn't
         // work then transform.xsl would be used and we'd have a cheese element
diff --git 
a/core/camel-core/src/test/java/org/apache/camel/component/xslt/XsltTemplateFromHeaderOverrideEndpointUriTest.java
 
b/core/camel-core/src/test/java/org/apache/camel/component/xslt/XsltTemplateFromHeaderOverrideEndpointUriTest.java
index 039566298e9..b773d640c95 100644
--- 
a/core/camel-core/src/test/java/org/apache/camel/component/xslt/XsltTemplateFromHeaderOverrideEndpointUriTest.java
+++ 
b/core/camel-core/src/test/java/org/apache/camel/component/xslt/XsltTemplateFromHeaderOverrideEndpointUriTest.java
@@ -52,7 +52,7 @@ public class XsltTemplateFromHeaderOverrideEndpointUriTest 
extends ContextTestSu
         Exchange exchange = list.get(0);
         String xml = exchange.getIn().getBody(String.class);
 
-        assertNotNull("The transformed XML should not be null", xml);
+        assertNotNull(xml, "The transformed XML should not be null");
         assertTrue(xml.contains("transformed"));
         // the foo tag is in the transform_to_foo.xsl which is what we want. 
If this didn't
         // work then transform.xsl would be used and we'd have a cheese element
diff --git 
a/core/camel-core/src/test/java/org/apache/camel/impl/CamelContextAddRouteDefinitionsFromXmlTest.java
 
b/core/camel-core/src/test/java/org/apache/camel/impl/CamelContextAddRouteDefinitionsFromXmlTest.java
index a90bd6aee3e..aef45e8b6df 100644
--- 
a/core/camel-core/src/test/java/org/apache/camel/impl/CamelContextAddRouteDefinitionsFromXmlTest.java
+++ 
b/core/camel-core/src/test/java/org/apache/camel/impl/CamelContextAddRouteDefinitionsFromXmlTest.java
@@ -127,7 +127,6 @@ public class CamelContextAddRouteDefinitionsFromXmlTest 
extends ContextTestSuppo
         
assertTrue(context.getRouteController().getRouteStatus("foo").isStarted(), 
"Route should be started");
 
         // should be prepared, check parents has been set
-        assertNotNull("Parent should be set on outputs");
         route = context.getRouteDefinition("foo");
         for (ProcessorDefinition<?> output : route.getOutputs()) {
             assertNotNull(output.getParent(), "Parent should be set on 
output");
diff --git 
a/core/camel-core/src/test/java/org/apache/camel/impl/converter/TypeConvertersTest.java
 
b/core/camel-core/src/test/java/org/apache/camel/impl/converter/TypeConvertersTest.java
index ae02af2d52f..54adddd8835 100644
--- 
a/core/camel-core/src/test/java/org/apache/camel/impl/converter/TypeConvertersTest.java
+++ 
b/core/camel-core/src/test/java/org/apache/camel/impl/converter/TypeConvertersTest.java
@@ -54,7 +54,7 @@ public class TypeConvertersTest extends ContextTestSupport {
         assertEquals(Float.parseFloat("1.1"), 
context.getTypeConverter().mandatoryConvertTo(float.class, "1.1"));
         assertEquals(Double.parseDouble("1.1"), 
context.getTypeConverter().mandatoryConvertTo(double.class, "1.1"));
 
-        assertEquals("a".charAt(0), 
context.getTypeConverter().mandatoryConvertTo(char.class, "a"));
+        assertEquals('a', 
context.getTypeConverter().mandatoryConvertTo(char.class, "a"));
         assertEquals(Boolean.parseBoolean("true"), 
context.getTypeConverter().mandatoryConvertTo(boolean.class, "true"));
     }
 }