This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit a4f8086003daf12f111abef225aed1b69ec2a99e
Author: Otavio Rodolfo Piske <angusyo...@gmail.com>
AuthorDate: Wed Apr 10 11:00:13 2024 +0200
(chores) camel-core: prefer primitive values when possible
---
.../PropertiesComponentDefaultFunctionsTest.java | 2 +-
...rterRegistryStatisticsEnabledNoStreamCachingTest.java | 16 ++++++++--------
.../impl/TypeConverterRegistryStatisticsEnabledTest.java | 16 ++++++++--------
.../camel/support/builder/xml/XMLConverterHelper.java | 2 +-
4 files changed, 18 insertions(+), 18 deletions(-)
diff --git
a/core/camel-core/src/test/java/org/apache/camel/component/properties/PropertiesComponentDefaultFunctionsTest.java
b/core/camel-core/src/test/java/org/apache/camel/component/properties/PropertiesComponentDefaultFunctionsTest.java
index 0157ecc96a4..49ea3b2195c 100644
---
a/core/camel-core/src/test/java/org/apache/camel/component/properties/PropertiesComponentDefaultFunctionsTest.java
+++
b/core/camel-core/src/test/java/org/apache/camel/component/properties/PropertiesComponentDefaultFunctionsTest.java
@@ -34,7 +34,7 @@ public class PropertiesComponentDefaultFunctionsTest extends
ContextTestSupport
private static Map.Entry<String, String> anyNonEmptyEnvironmentVariable() {
for (Map.Entry<String, String> entry : System.getenv().entrySet()) {
- if (entry.getValue() != null && !"".equals(entry.getValue())) {
+ if (entry.getValue() != null && !entry.getValue().isEmpty()) {
return entry;
}
}
diff --git
a/core/camel-core/src/test/java/org/apache/camel/impl/TypeConverterRegistryStatisticsEnabledNoStreamCachingTest.java
b/core/camel-core/src/test/java/org/apache/camel/impl/TypeConverterRegistryStatisticsEnabledNoStreamCachingTest.java
index f8a0adad8ec..7120eb62316 100644
---
a/core/camel-core/src/test/java/org/apache/camel/impl/TypeConverterRegistryStatisticsEnabledNoStreamCachingTest.java
+++
b/core/camel-core/src/test/java/org/apache/camel/impl/TypeConverterRegistryStatisticsEnabledNoStreamCachingTest.java
@@ -48,27 +48,27 @@ public class
TypeConverterRegistryStatisticsEnabledNoStreamCachingTest extends C
TypeConverterRegistry reg = context.getTypeConverterRegistry();
assertTrue(reg.getStatistics().isStatisticsEnabled(), "Should be
enabled");
- Long failed = reg.getStatistics().getFailedCounter();
- assertEquals(0, failed.intValue());
- Long miss = reg.getStatistics().getMissCounter();
- assertEquals(0, miss.intValue());
+ long failed = reg.getStatistics().getFailedCounter();
+ assertEquals(0, (int) failed);
+ long miss = reg.getStatistics().getMissCounter();
+ assertEquals(0, (int) miss);
assertThrows(Exception.class, () -> template.sendBody("direct:start",
"foo"),
"Should have thrown exception");
// should now have a failed
failed = reg.getStatistics().getFailedCounter();
- assertEquals(1, failed.intValue());
+ assertEquals(1, (int) failed);
miss = reg.getStatistics().getMissCounter();
- assertEquals(0, miss.intValue());
+ assertEquals(0, (int) miss);
// reset
reg.getStatistics().reset();
failed = reg.getStatistics().getFailedCounter();
- assertEquals(0, failed.intValue());
+ assertEquals(0, (int) failed);
miss = reg.getStatistics().getMissCounter();
- assertEquals(0, miss.intValue());
+ assertEquals(0, (int) miss);
}
@Override
diff --git
a/core/camel-core/src/test/java/org/apache/camel/impl/TypeConverterRegistryStatisticsEnabledTest.java
b/core/camel-core/src/test/java/org/apache/camel/impl/TypeConverterRegistryStatisticsEnabledTest.java
index 6c2549323f6..68db6062fda 100644
---
a/core/camel-core/src/test/java/org/apache/camel/impl/TypeConverterRegistryStatisticsEnabledTest.java
+++
b/core/camel-core/src/test/java/org/apache/camel/impl/TypeConverterRegistryStatisticsEnabledTest.java
@@ -47,27 +47,27 @@ public class TypeConverterRegistryStatisticsEnabledTest
extends ContextTestSuppo
TypeConverterRegistry reg = context.getTypeConverterRegistry();
assertTrue(reg.getStatistics().isStatisticsEnabled(), "Should be
enabled");
- Long failed = reg.getStatistics().getFailedCounter();
- assertEquals(0, failed.intValue());
- Long miss = reg.getStatistics().getMissCounter();
- assertEquals(4, miss.intValue()); // stream caching misses
+ long failed = reg.getStatistics().getFailedCounter();
+ assertEquals(0, (int) failed);
+ long miss = reg.getStatistics().getMissCounter();
+ assertEquals(4, (int) miss); // stream caching misses
assertThrows(Exception.class, () -> template.sendBody("direct:start",
"foo"),
"Should have thrown exception");
// should now have a failed
failed = reg.getStatistics().getFailedCounter();
- assertEquals(1, failed.intValue());
+ assertEquals(1, (int) failed);
miss = reg.getStatistics().getMissCounter();
- assertEquals(5, miss.intValue()); // stream caching misses
+ assertEquals(5, (int) miss); // stream caching misses
// reset
reg.getStatistics().reset();
failed = reg.getStatistics().getFailedCounter();
- assertEquals(0, failed.intValue());
+ assertEquals(0, (int) failed);
miss = reg.getStatistics().getMissCounter();
- assertEquals(0, miss.intValue());
+ assertEquals(0, (int) miss);
}
@Override
diff --git
a/core/camel-xml-jaxp/src/main/java/org/apache/camel/support/builder/xml/XMLConverterHelper.java
b/core/camel-xml-jaxp/src/main/java/org/apache/camel/support/builder/xml/XMLConverterHelper.java
index ff221b9d129..383c226c154 100644
---
a/core/camel-xml-jaxp/src/main/java/org/apache/camel/support/builder/xml/XMLConverterHelper.java
+++
b/core/camel-xml-jaxp/src/main/java/org/apache/camel/support/builder/xml/XMLConverterHelper.java
@@ -298,7 +298,7 @@ public class XMLConverterHelper {
String key = (String) prop.getKey();
if (key.startsWith(DOCUMENT_BUILDER_FACTORY_FEATURE)) {
String uri = StringHelper.after(key, ":");
- Boolean value = Boolean.valueOf((String) prop.getValue());
+ boolean value = Boolean.parseBoolean((String) prop.getValue());
try {
factory.setFeature(uri, value);
features.add("feature " + uri + " value " + value);
