AemieJ commented on pull request #3860:
URL: https://github.com/apache/camel/pull/3860#issuecomment-636488368
@djencks I ran `mvn compile` and I ran into a couple of errors which then
resulted in a couple of git errors so I re-created the PR.
AemieJ commented on pull request #3860:
URL: https://github.com/apache/camel/pull/3860#issuecomment-636483057
@djencks While using the changes you made in your code, I ran `mvn
compile`, it is failing to build as there is no plugin descriptor
AemieJ commented on pull request #3860:
URL: https://github.com/apache/camel/pull/3860#issuecomment-635533914
See, we used summary and group majorly for index listing in future so we
could auto generate the list in summary group, so while checking you just
required the need for
AemieJ commented on pull request #3860:
URL: https://github.com/apache/camel/pull/3860#issuecomment-635524516
Alright, I got what you meant, it wasn't clear from before. I will include
the summary pages with basic styling as the other summary pages as of now to
maintain the listing.
AemieJ commented on pull request #3860:
URL: https://github.com/apache/camel/pull/3860#issuecomment-635499937
@djencks I modified the gulpfile to include `checkAttributeExistence()` and
thus it resulted in removal of `isChildAttribute()` function as it isn't
required based on the logic
AemieJ commented on pull request #3860:
URL: https://github.com/apache/camel/pull/3860#issuecomment-635490536
I realized, I made the mistake for two of the group files and omitted the
space.
About your third point you mentioned, I made changes to the files within the
components
AemieJ commented on pull request #3860:
URL: https://github.com/apache/camel/pull/3860#issuecomment-635150486
About the first point, in the gulpfile, the file is generated one by one,
and hence I read that turn by turn to check whether they are either the parent
or child attribute.
AemieJ commented on pull request #3860:
URL: https://github.com/apache/camel/pull/3860#issuecomment-635118543
@djencks I have included the attributes for the related files within the
`components/src` folders and modified the `gulpfile.js`, check it out.
AemieJ commented on pull request #3860:
URL: https://github.com/apache/camel/pull/3860#issuecomment-634498964
@djencks For providing the attribute for the ones with relative groupings,
the docs pages within the **docs/components** is auto-generated from the src
files in **components**
AemieJ commented on pull request #3860:
URL: https://github.com/apache/camel/pull/3860#issuecomment-634483541
Fine I will rename those attributes, it helps with understanding the
definition better but this idea of yours to use attributes seems much better
and reliable way to generate.
AemieJ commented on pull request #3860:
URL: https://github.com/apache/camel/pull/3860#issuecomment-634459112
> I appreciate you showing your code, but please use markdown on text;
surround the text with ```.
>
> Your code looks like it would work, but I think it is rather fragile.
AemieJ commented on pull request #3860:
URL: https://github.com/apache/camel/pull/3860#issuecomment-633900927
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
12 matches
Mail list logo
