[GitHub] [camel] AemieJ edited a comment on pull request #3879: CAMEL-14910: Bundling of the heavily distributed components

2020-06-03 Thread GitBox
AemieJ edited a comment on pull request #3879: URL: https://github.com/apache/camel/pull/3879#issuecomment-638577699 @djencks Yea, I will correct that. I missed out on a condition for both groups not null. I will modify it. Also, throughout the file == & != is used rather than === & !==

[GitHub] [camel] AemieJ edited a comment on pull request #3879: CAMEL-14910: Bundling of the heavily distributed components

2020-06-03 Thread GitBox
AemieJ edited a comment on pull request #3879: URL: https://github.com/apache/camel/pull/3879#issuecomment-638384597 @djencks I thought I didn't include AWS Xray, other than that the code can look more sophisticated and optimized & for the first could you elobarate, we included the case wh

[GitHub] [camel] AemieJ edited a comment on pull request #3879: CAMEL-14910: Bundling of the heavily distributed components

2020-06-02 Thread GitBox
AemieJ edited a comment on pull request #3879: URL: https://github.com/apache/camel/pull/3879#issuecomment-637991186 > We need a better sorting algorithm. > If the summary-group was always the same as the docTitle, then I think the comparison for the sort could be (lets assume everything

[GitHub] [camel] AemieJ edited a comment on pull request #3879: CAMEL-14910: Bundling of the heavily distributed components

2020-06-02 Thread GitBox
AemieJ edited a comment on pull request #3879: URL: https://github.com/apache/camel/pull/3879#issuecomment-637682556 @djencks By group you mean the sorting of **summary-group** right? 'cause that's the one where the issue is arising. Also for the 4th and 5th case, not all have **summary-gr