djencks commented on pull request #3860:
URL: https://github.com/apache/camel/pull/3860#issuecomment-636393187
I wrote https://github.com/apache/camel/pull/3876 which provides the
functionality needed so your manual changes won't get overwritten by the java
build. I tried it on "ignite"
djencks commented on pull request #3860:
URL: https://github.com/apache/camel/pull/3860#issuecomment-635522339
- You are still reading the file twice sometimes. I was thinking of
replacing
```
if (summaryGroup != null || group != null) return true;
return false;
```
djencks commented on pull request #3860:
URL: https://github.com/apache/camel/pull/3860#issuecomment-635410111
- I think for files that are not summary files, your code reads the file
twice, first to determine it's not a summary page, and second to determine if
it is in a group. You
djencks commented on pull request #3860:
URL: https://github.com/apache/camel/pull/3860#issuecomment-635137587
The code modifications look good, but I didn't try building it. A couple of
minor comments:
- it might be worth reading each file only once and extracting both parent
and
djencks commented on pull request #3860:
URL: https://github.com/apache/camel/pull/3860#issuecomment-634754864
Yes. The files in docs/components should have an attribute indicating
exactly where they come from, in components.
djencks commented on pull request #3860:
URL: https://github.com/apache/camel/pull/3860#issuecomment-634480495
That's the solution I was trying to suggest, except you've renamed the
attributes I proposed:
```
summary-group > parentGroup
group > childGroup
```
I think my
djencks commented on pull request #3860:
URL: https://github.com/apache/camel/pull/3860#issuecomment-634127414
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
