[GitHub] [camel] orpiske commented on pull request #11225: CAMEL-19398: refactor the core type-converter

2023-08-30 Thread via GitHub
orpiske commented on PR #11225: URL: https://github.com/apache/camel/pull/11225#issuecomment-1699010495 Marking as skip-tests because `camel-maven-package-plugin` is severely broken on GitHub. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [camel] orpiske commented on pull request #11225: CAMEL-19398: refactor the core type-converter

2023-08-28 Thread via GitHub
orpiske commented on PR #11225: URL: https://github.com/apache/camel/pull/11225#issuecomment-1696811872 Using the tests from camel-performance-tests repo: | Test | 4.0.0 | This Patch | |--|-|--| | SlowTypeConverter | 35 ms/op | 7 ms/op | | FastTypeConverterTest | 35

[GitHub] [camel] orpiske commented on pull request #11225: CAMEL-19398: refactor the core type-converter

2023-08-28 Thread via GitHub
orpiske commented on PR #11225: URL: https://github.com/apache/camel/pull/11225#issuecomment-1696805803 Some performance details: - Testing with a content-based-router, routing based on the body of a message, this code was faster than 4.0.0 in 100% of the times - Testing with a