[GitHub] [camel] orpiske commented on pull request #6292: CAMEL-17096: Add async commit support in camel-kafka component

2021-10-19 Thread GitBox
orpiske commented on pull request #6292: URL: https://github.com/apache/camel/pull/6292#issuecomment-946453423 > Checks are failing here but are passing on my machine. An idea why @orpiske @oscerd @davsclaus ? Same on the other PR. This comes from other code. I think we fixed it by

[GitHub] [camel] orpiske commented on pull request #6292: CAMEL-17096: Add async commit support in camel-kafka component

2021-10-18 Thread GitBox
orpiske commented on pull request #6292: URL: https://github.com/apache/camel/pull/6292#issuecomment-945767772 I'm wondering whether it wouldn't better - from a maintenance perspective - to have the async commit in a separated class. We would need to adjust the KafkaManualCommit to rename