[GitHub] [camel-k] claudio4j commented on pull request #2577: trait: Add tests for route trait and read certificate from secrets

2021-09-09 Thread GitBox
claudio4j commented on pull request #2577: URL: https://github.com/apache/camel-k/pull/2577#issuecomment-916263407 @astefanutti rebase done. All checks are green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [camel-k] claudio4j commented on pull request #2577: trait: Add tests for route trait and read certificate from secrets

2021-09-03 Thread GitBox
claudio4j commented on pull request #2577: URL: https://github.com/apache/camel-k/pull/2577#issuecomment-91283 For testing I am using Openshift on IBM cloud and I noticed the operator-ingress uses a letsencrypt certificate CA to manage the serving service CA certificates, which are

[GitHub] [camel-k] claudio4j commented on pull request #2577: trait: Add tests for route trait and read certificate from secrets

2021-09-03 Thread GitBox
claudio4j commented on pull request #2577: URL: https://github.com/apache/camel-k/pull/2577#issuecomment-912530975 > I'm not sure I understand why it's necessary for users to deal with low level resource mounting and Quarkus properties. Could the user provide only the secret name and the

[GitHub] [camel-k] claudio4j commented on pull request #2577: trait: Add tests for route trait and read certificate from secrets

2021-09-01 Thread GitBox
claudio4j commented on pull request #2577: URL: https://github.com/apache/camel-k/pull/2577#issuecomment-910824396 There is a single test "Route reencrypt (with openshift service CA) https works" failing because the route host is not ready yet, that may occur occasionally, we may increase

[GitHub] [camel-k] claudio4j commented on pull request #2577: trait: Add tests for route trait and read certificate from secrets

2021-09-01 Thread GitBox
claudio4j commented on pull request #2577: URL: https://github.com/apache/camel-k/pull/2577#issuecomment-910519529 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [camel-k] claudio4j commented on pull request #2577: trait: Add tests for route trait and read certificate from secrets

2021-09-01 Thread GitBox
claudio4j commented on pull request #2577: URL: https://github.com/apache/camel-k/pull/2577#issuecomment-910503046 I changed the e2e test to skip TLS certificate validation for client http request when it is unable to determine the dns base domain name (from dns/cluster object). So the

[GitHub] [camel-k] claudio4j commented on pull request #2577: trait: Add tests for route trait and read certificate from secrets

2021-09-01 Thread GitBox
claudio4j commented on pull request #2577: URL: https://github.com/apache/camel-k/pull/2577#issuecomment-910273412 There are issues running the route tests, related to openshift 3 test cluster (CI) complaining about different base domain names. I am investigating this issue. -- This is

[GitHub] [camel-k] claudio4j commented on pull request #2577: trait: Add tests for route trait and read certificate from secrets

2021-08-31 Thread GitBox
claudio4j commented on pull request #2577: URL: https://github.com/apache/camel-k/pull/2577#issuecomment-908462204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [camel-k] claudio4j commented on pull request #2577: trait: Add tests for route trait and read certificate from secrets

2021-08-30 Thread GitBox
claudio4j commented on pull request #2577: URL: https://github.com/apache/camel-k/pull/2577#issuecomment-908467217 > I think we can take the opportunity and make this more general than just `secret`. We should use the `path` concept (ie `TLSCertificatePath`) that will read a generic path

[GitHub] [camel-k] claudio4j commented on pull request #2577: trait: Add tests for route trait and read certificate from secrets

2021-08-30 Thread GitBox
claudio4j commented on pull request #2577: URL: https://github.com/apache/camel-k/pull/2577#issuecomment-908462204 @astefanutti more e2e tests were added, to support 5 cases: no tls, edge, reencrypt, reencrypt with service signing and passthrough Also, added more examples in docs on how