[GitHub] [camel-kamelets] davsclaus commented on pull request #1162: chore: Introduce Kamelet input/output data types

2022-12-01 Thread GitBox
davsclaus commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1334332204 LGTM Thanks for the effort @christophd and sorry for the bike-shedding but thats the nature of humans, github and big PRs ;) -- This is an automated message from the

[GitHub] [camel-kamelets] davsclaus commented on pull request #1162: chore: Introduce Kamelet input/output data types

2022-12-01 Thread GitBox
davsclaus commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-179437 camel-kamelet (kamelets) are discovered via camel-kamelets-catalog in the kamelets sub folder, so you should NOT have other folders. If we end up with alot of kamelets,

[GitHub] [camel-kamelets] davsclaus commented on pull request #1162: chore: Introduce Kamelet input/output data types

2022-11-30 Thread GitBox
davsclaus commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1331987032 This gives time for this new stuff to stabilize and improve and have it moved out of kamelets-utils as its not util and into its own module. And then later find out what

[GitHub] [camel-kamelets] davsclaus commented on pull request #1162: chore: Introduce Kamelet input/output data types

2022-11-30 Thread GitBox
davsclaus commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1331983573 This PR changes 2 existing kamelets so it cannot be an opt-in. So I suggest to revert the 2 kamelets so all kamelets works as now. And then add new kamelets that use this

[GitHub] [camel-kamelets] davsclaus commented on pull request #1162: chore: Introduce Kamelet input/output data types

2022-11-24 Thread GitBox
davsclaus commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1326673603 Please make sure that this works in standalone Camel as well, eg such as try via camel-jbang. Kamelets are universal building blocks and MUST work on camel-spring-boot,