[GitHub] [camel-quarkus] ppalaga commented on pull request #5117: Onboard Camel K Runtime

2023-08-23 Thread via GitHub
ppalaga commented on PR #5117: URL: https://github.com/apache/camel-quarkus/pull/5117#issuecomment-1690280718 @claudio4j in https://github.com/apache/camel-quarkus/pull/5219 I have rebased on top of recent main and I have put a few enhancements on top of the current PR. Please review there

[GitHub] [camel-quarkus] ppalaga commented on pull request #5117: Onboard Camel K Runtime

2023-08-22 Thread via GitHub
ppalaga commented on PR #5117: URL: https://github.com/apache/camel-quarkus/pull/5117#issuecomment-1688379633 > In camel-k-runtime repository, these tests are IT enabled.

[GitHub] [camel-quarkus] ppalaga commented on pull request #5117: Onboard Camel K Runtime

2023-08-22 Thread via GitHub
ppalaga commented on PR #5117: URL: https://github.com/apache/camel-quarkus/pull/5117#issuecomment-1688210157 > I am still looking whether we could merge the ITs into fewer Maven modules to save some time on the CI. Now I see that `camel-k-loader` does not have any assertions for

[GitHub] [camel-quarkus] ppalaga commented on pull request #5117: Onboard Camel K Runtime

2023-08-22 Thread via GitHub
ppalaga commented on PR #5117: URL: https://github.com/apache/camel-quarkus/pull/5117#issuecomment-1688162593 Thanks @claudio4j, I have done another round of review. I have send a PR against your PR https://github.com/claudio4j/camel-quarkus/pull/1 with some minor fixes. Please feel free

[GitHub] [camel-quarkus] ppalaga commented on pull request #5117: Onboard Camel K Runtime

2023-08-08 Thread via GitHub
ppalaga commented on PR #5117: URL: https://github.com/apache/camel-quarkus/pull/5117#issuecomment-1670097150 We had a chat with @claudio4j and we agreed to work towards the following (@jamesnetherton and others please speak up if you do not like something): 1. The BOM currently in

[GitHub] [camel-quarkus] ppalaga commented on pull request #5117: Onboard Camel K Runtime

2023-08-08 Thread via GitHub
ppalaga commented on PR #5117: URL: https://github.com/apache/camel-quarkus/pull/5117#issuecomment-1669388263 ![image](https://github.com/apache/camel-quarkus/assets/1826249/730021a3-76f7-4a46-8848-1cf71d0355eb) looks scarry, but I will have a look later today -- This is an