stn1slv commented on PR #13630:
URL: https://github.com/apache/camel/pull/13630#issuecomment-2044641075
The doc for consumerBytesOutstanding fixed in
https://github.com/apache/camel/pull/13660
--
This is an automated message from the Apache Git Service.
To respond to the message, please
stn1slv commented on PR #13630:
URL: https://github.com/apache/camel/pull/13630#issuecomment-2026946070
Thanks, I'll fix the doc for `consumerBytesOutstanding`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
davsclaus commented on PR #13630:
URL: https://github.com/apache/camel/pull/13630#issuecomment-2026937895
okay pushed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
davsclaus commented on PR #13630:
URL: https://github.com/apache/camel/pull/13630#issuecomment-2026936857
Okay I am soon ready and will push fixes.
I noticed that the doc for `consumerBytesOutstanding` in the component is
wrong. You are welcome to send a PR to fix that when I am done
davsclaus commented on PR #13630:
URL: https://github.com/apache/camel/pull/13630#issuecomment-2026921423
its a bit of mess to get this PR clean due to the 4.5 -> 4.6 release and
main changes. So lets me clean it up, and when done you can if more needed send
new PRs
--
This is an
davsclaus merged PR #13630:
URL: https://github.com/apache/camel/pull/13630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
stn1slv commented on PR #13630:
URL: https://github.com/apache/camel/pull/13630#issuecomment-2025342006
> Ah its in the JIRA. If this information is missing in the docs, then it
would be good to add there.
I'll add it to the docs
--
This is an automated message from the Apache Git
davsclaus commented on PR #13630:
URL: https://github.com/apache/camel/pull/13630#issuecomment-2025315868
> Can you tell more what is the difference between this `list` vs the
regular pubsub in google ? And is so that would be good to have in the docs
Ah its in the JIRA. If this
davsclaus commented on PR #13630:
URL: https://github.com/apache/camel/pull/13630#issuecomment-2025304523
Can you tell more what is the difference between this `list` vs the regular
pubsub in google ?
And is so that would be good to have in the docs
--
This is an automated message
stn1slv commented on PR #13630:
URL: https://github.com/apache/camel/pull/13630#issuecomment-2024884192
@davsclaus, apologies for such a basic query: I attempted to build the docs
but didn't observe any new changes. I'm unclear whether I need to manually copy
files over. There might be
davsclaus commented on PR #13630:
URL: https://github.com/apache/camel/pull/13630#issuecomment-2024725081
cd camel/docs
mvn install
and then you should have some changed files you can add to this PR
--
This is an automated message from the Apache Git Service.
To respond to the
davsclaus commented on PR #13630:
URL: https://github.com/apache/camel/pull/13630#issuecomment-2024724635
maybe you can build the docs folder and add changed file to the PR so the GH
action can run
docs/components/modules/ROOT/examples/json/google-pubsub-lite.json
stn1slv commented on code in PR #13630:
URL: https://github.com/apache/camel/pull/13630#discussion_r1542457420
##
components/camel-google/camel-google-pubsub-lite/.gitignore:
##
@@ -0,0 +1,7 @@
+.idea
Review Comment:
Fixed in 8bfe10f
##
stn1slv commented on code in PR #13630:
URL: https://github.com/apache/camel/pull/13630#discussion_r1542458053
##
components/camel-google/camel-google-pubsub-lite/src/main/java/org/apache/camel/component/google/pubsublite/GooglePubsubLiteComponent.java:
##
@@ -0,0 +1,245 @@
+/*
stn1slv commented on PR #13630:
URL: https://github.com/apache/camel/pull/13630#issuecomment-2024606515
@oscerd, thanks for the review and feedback.
Addressed findings in 8bfe10f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
stn1slv commented on code in PR #13630:
URL: https://github.com/apache/camel/pull/13630#discussion_r1542457517
##
components/camel-google/camel-google-pubsub-lite/src/main/java/org/apache/camel/component/google/pubsublite/GooglePubsubLiteProducer.java:
##
@@ -0,0 +1,120 @@
+/*
stn1slv commented on code in PR #13630:
URL: https://github.com/apache/camel/pull/13630#discussion_r1542458053
##
components/camel-google/camel-google-pubsub-lite/src/main/java/org/apache/camel/component/google/pubsublite/GooglePubsubLiteComponent.java:
##
@@ -0,0 +1,245 @@
+/*
stn1slv commented on code in PR #13630:
URL: https://github.com/apache/camel/pull/13630#discussion_r1542457420
##
components/camel-google/camel-google-pubsub-lite/.gitignore:
##
@@ -0,0 +1,7 @@
+.idea
Review Comment:
Fixed in
stn1slv commented on code in PR #13630:
URL: https://github.com/apache/camel/pull/13630#discussion_r1542456791
##
components/camel-google/camel-google-pubsub-lite/src/main/java/org/apache/camel/component/google/pubsublite/GooglePubsubLiteComponent.java:
##
@@ -0,0 +1,245 @@
+/*
stn1slv commented on code in PR #13630:
URL: https://github.com/apache/camel/pull/13630#discussion_r1542457092
##
components/camel-google/camel-google-pubsub-lite/src/main/java/org/apache/camel/component/google/pubsublite/GooglePubsubLiteEndpoint.java:
##
@@ -0,0 +1,238 @@
+/*
oscerd commented on code in PR #13630:
URL: https://github.com/apache/camel/pull/13630#discussion_r1542340660
##
components/camel-google/camel-google-pubsub-lite/src/main/java/org/apache/camel/component/google/pubsublite/GooglePubsubLiteProducer.java:
##
@@ -0,0 +1,120 @@
+/*
+
github-actions[bot] commented on PR #13630:
URL: https://github.com/apache/camel/pull/13630#issuecomment-2023139998
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel
stn1slv opened a new pull request, #13630:
URL: https://github.com/apache/camel/pull/13630
# Description
# Target
- [x] I checked that the commit is targeting the correct branch (note that
Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
#
23 matches
Mail list logo
