squakez merged PR #5115:
URL: https://github.com/apache/camel-k/pull/5115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lfabriko commented on PR #5115:
URL: https://github.com/apache/camel-k/pull/5115#issuecomment-1938184477
I observe failed tests `TestRunDevMode` (in
`common-it-single-operator-installation`) and `TestKamelCLIPromote` (in
`common-it-custom-operator-installation`); I tried re-running them on
github-actions[bot] commented on PR #5115:
URL: https://github.com/apache/camel-k/pull/5115#issuecomment-1933500720
:heavy_check_mark: Unit test coverage report - coverage increased from 35.6%
to 35.8% (**+0.2%**)
--
This is an automated message from the Apache Git Service.
To respond to
lfabriko commented on PR #5115:
URL: https://github.com/apache/camel-k/pull/5115#issuecomment-1933140256
Validation via `make lint` with golangci-lint version 1.55.2 locally passed
for modified files.
--
This is an automated message from the Apache Git Service.
To respond to the message,
squakez commented on PR #5115:
URL: https://github.com/apache/camel-k/pull/5115#issuecomment-1931733676
I've restarted the check, maybe it's a flaky one. Please, have a look at the
validate error. Locally you can `make lint` to see what's the problem.
--
This is an automated message from
lfabriko commented on PR #5115:
URL: https://github.com/apache/camel-k/pull/5115#issuecomment-1931709137
I observe failed `TestRunIncrementalBuildWithDifferentBaseImages`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
github-actions[bot] commented on PR #5115:
URL: https://github.com/apache/camel-k/pull/5115#issuecomment-1929114604
:heavy_check_mark: Unit test coverage report - coverage increased from 35.6%
to 35.7% (**+0.1%**)
--
This is an automated message from the Apache Git Service.
To respond to
github-actions[bot] commented on PR #5115:
URL: https://github.com/apache/camel-k/pull/5115#issuecomment-1926572913
:heavy_check_mark: Unit test coverage report - coverage increased from 35.6%
to 35.7% (**+0.1%**)
--
This is an automated message from the Apache Git Service.
To respond to
lfabriko commented on PR #5115:
URL: https://github.com/apache/camel-k/pull/5115#issuecomment-1926513656
Sure, I thought I should replace it by e2e test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
squakez commented on PR #5115:
URL: https://github.com/apache/camel-k/pull/5115#issuecomment-1926500293
@lfabriko any reason why you removed the `digest_test.go` in the last
commit? I think that was still good to make some unit test coverage. In fact,
with that change, the coverage
github-actions[bot] commented on PR #5115:
URL: https://github.com/apache/camel-k/pull/5115#issuecomment-1926487375
:warning: Unit test coverage report - coverage decreased from 35.6% to 35.5%
(**-0.1%**)
--
This is an automated message from the Apache Git Service.
To respond to the
squakez commented on code in PR #5115:
URL: https://github.com/apache/camel-k/pull/5115#discussion_r1473974795
##
pkg/util/digest/digest.go:
##
@@ -183,7 +183,7 @@ func ComputeForIntegration(integration *v1.Integration,
configmaps []*corev1.Con
github-actions[bot] commented on PR #5115:
URL: https://github.com/apache/camel-k/pull/5115#issuecomment-1920672786
:heavy_check_mark: Unit test coverage report - coverage increased from 35.6%
to 35.7% (**+0.1%**)
--
This is an automated message from the Apache Git Service.
To respond to
lfabriko commented on code in PR #5115:
URL: https://github.com/apache/camel-k/pull/5115#discussion_r1473911442
##
pkg/util/digest/digest.go:
##
@@ -183,7 +183,7 @@ func ComputeForIntegration(integration *v1.Integration,
configmaps []*corev1.Con
squakez commented on code in PR #5115:
URL: https://github.com/apache/camel-k/pull/5115#discussion_r1473899524
##
pkg/util/digest/digest.go:
##
@@ -183,7 +183,7 @@ func ComputeForIntegration(integration *v1.Integration,
configmaps []*corev1.Con
squakez commented on PR #5115:
URL: https://github.com/apache/camel-k/pull/5115#issuecomment-1918665281
A part the validate check failure, the rest seems good. However, I think it
would be convenient to have some unit test to cover the scenarios we're trying
to fix.
--
This is an
lfabriko commented on PR #5115:
URL: https://github.com/apache/camel-k/pull/5115#issuecomment-1914386234
I observe if configmap is created without the ownerReference part, there
isn't the memory reference and the case 5115 doesn't appear:
```
lfabriko commented on PR #5115:
URL: https://github.com/apache/camel-k/pull/5115#issuecomment-1914277833
I think it tries to compute digest of configmap from memory address:
(digest.go)
```
// Configmap and secret content
for _, cm := range configmaps {
lfabriko opened a new pull request, #5115:
URL: https://github.com/apache/camel-k/pull/5115
Proposal of fix to https://github.com/apache/camel-k/issues/5114 - use Name,
Namespace and Data/StringData to compute digest of Configmap and Secret.
--
This is an automated message from the
19 matches
Mail list logo
