mgubaidullin merged PR #1085:
URL: https://github.com/apache/camel-karavan/pull/1085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mgubaidullin commented on PR #1085:
URL: https://github.com/apache/camel-karavan/pull/1085#issuecomment-1914833115
@mvolf your validation framework is great. And it might be good part of any
application with a lot of forms and validations. In the Karavan we have only 2
forms (new project
mvolf commented on PR #1085:
URL: https://github.com/apache/camel-karavan/pull/1085#issuecomment-1913512564
> It would be great if we keep `axios` stuff in one place KaravanApi instead
of spreading over the app.
@mgubaidullin I'm not sure what you're aiming at with this comment :)
mvolf commented on code in PR #1085:
URL: https://github.com/apache/camel-karavan/pull/1085#discussion_r1468785276
##
karavan-web/karavan-app/src/main/webui/src/topology/TopologyToolbar.tsx:
##
@@ -34,7 +34,7 @@ export function TopologyToolbar (props: Props) {
mvolf commented on PR #1085:
URL: https://github.com/apache/camel-karavan/pull/1085#issuecomment-1913511445
> @mvolf thank for the contribution. This Validator on backend and and yup
on frontend with dosens lines of code just to simply check if file is already
exists. Look like an
mgubaidullin commented on PR #1085:
URL: https://github.com/apache/camel-karavan/pull/1085#issuecomment-1912758224
It would be great if we keep `axios` stuff in one place KaravanApi instead
of spreading over the app.
--
This is an automated message from the Apache Git Service.
To respond
mgubaidullin commented on code in PR #1085:
URL: https://github.com/apache/camel-karavan/pull/1085#discussion_r1468114445
##
karavan-web/karavan-app/src/main/webui/src/topology/TopologyToolbar.tsx:
##
@@ -34,7 +34,7 @@ export function TopologyToolbar (props: Props) {
mgubaidullin commented on code in PR #1085:
URL: https://github.com/apache/camel-karavan/pull/1085#discussion_r1468114602
##
karavan-web/karavan-app/src/main/webui/src/topology/TopologyToolbar.tsx:
##
@@ -45,7 +45,7 @@ export function TopologyToolbar (props: Props) {
mgubaidullin commented on PR #1085:
URL: https://github.com/apache/camel-karavan/pull/1085#issuecomment-1912596629
@mvolf thank for the contribution.
This Validator on backend and and yup on frontend with dosens lines of code
just to simply check if file is already exists.
Look like
mvolf opened a new pull request, #1085:
URL: https://github.com/apache/camel-karavan/pull/1085
@mgubaidullin Here's an implementation for validating file existence on
project file import/upload. I've also propagated the same validation on file
creation, so it's uniform and both uses the
10 matches
Mail list logo
