Re: [PR] Review permission check [camel-k]

2024-05-09 Thread via GitHub
lburgazzoli merged PR #5479: URL: https://github.com/apache/camel-k/pull/5479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Review permission check [camel-k]

2024-05-08 Thread via GitHub
squakez commented on PR #5479: URL: https://github.com/apache/camel-k/pull/5479#issuecomment-2100613067 > mh, since the master trait has been moved to addons, validation is not relevant as addons are untyped (in the CRDs) Very true. We should open a discussion and understand if it is

Re: [PR] Review permission check [camel-k]

2024-05-08 Thread via GitHub
lburgazzoli commented on PR #5479: URL: https://github.com/apache/camel-k/pull/5479#issuecomment-2100600513 > Sorry, I misinterpreted the change, I thought you were removing the `Configmap` option. Okey, I see that nothing is really changing, however, I wonder if we can take the

Re: [PR] Review permission check [camel-k]

2024-05-08 Thread via GitHub
squakez commented on PR #5479: URL: https://github.com/apache/camel-k/pull/5479#issuecomment-2100554400 Sorry, I misinterpreted the change, I thought you were removing the `Configmap` option. Okey, I see that nothing is really changing, however, I wonder if we can take the opportunity and

Re: [PR] Review permission check [camel-k]

2024-05-08 Thread via GitHub
lburgazzoli commented on PR #5479: URL: https://github.com/apache/camel-k/pull/5479#issuecomment-2100406013 > You'll need to change also [#5479 (files)](https://github.com/apache/camel-k/pull/5479/files#diff-7e0ef56e991c8a8605de6dd8886fe8be2694b81248420587eb799384adcd5257L58) > > and

[PR] Review permission check [camel-k]

2024-05-08 Thread via GitHub
lburgazzoli opened a new pull request, #5479: URL: https://github.com/apache/camel-k/pull/5479 Fixes #5210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To