Re: [PR] feat(install): Separate namespaced and descoped rbacs [camel-k]

2023-12-13 Thread via GitHub
squakez merged PR #4914: URL: https://github.com/apache/camel-k/pull/4914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apac

Re: [PR] feat(install): Separate namespaced and descoped rbacs [camel-k]

2023-12-12 Thread via GitHub
gansheer commented on code in PR #4914: URL: https://github.com/apache/camel-k/pull/4914#discussion_r1424119707 ## config/rbac/kustomization.yaml: ## @@ -23,23 +23,22 @@ kind: Kustomization resources: - user-cluster-role.yaml -- operator-role-events.yaml -- operator-role-kna

Re: [PR] feat(install): Separate namespaced and descoped rbacs [camel-k]

2023-12-12 Thread via GitHub
gansheer commented on code in PR #4914: URL: https://github.com/apache/camel-k/pull/4914#discussion_r1423956152 ## config/rbac/kustomization.yaml: ## @@ -23,23 +23,22 @@ kind: Kustomization resources: - user-cluster-role.yaml -- operator-role-events.yaml -- operator-role-kna

Re: [PR] feat(install): Separate namespaced and descoped rbacs [camel-k]

2023-12-12 Thread via GitHub
squakez commented on code in PR #4914: URL: https://github.com/apache/camel-k/pull/4914#discussion_r1423908950 ## config/rbac/kustomization.yaml: ## @@ -23,23 +23,22 @@ kind: Kustomization resources: - user-cluster-role.yaml -- operator-role-events.yaml -- operator-role-knat

Re: [PR] feat(install): Separate namespaced and descoped rbacs [camel-k]

2023-12-12 Thread via GitHub
gansheer commented on PR #4914: URL: https://github.com/apache/camel-k/pull/4914#issuecomment-1851919244 It is ready for merge. From my tests, on vanilla kubernetes and Openshift, it is transparent on existing installation methods CLI and Kustomize (I didn't test helm as helm uses its own f

Re: [PR] feat(install): Separate namespaced and descoped rbacs [camel-k]

2023-12-12 Thread via GitHub
squakez commented on PR #4914: URL: https://github.com/apache/camel-k/pull/4914#issuecomment-1851879623 @gansheer is this good to merge? how is this affecting the installation procedures (if it does affect in any manner)? -- This is an automated message from the Apache Git Service. To res

Re: [PR] feat(install): Separate namespaced and descoped rbacs [camel-k]

2023-12-12 Thread via GitHub
gansheer commented on PR #4914: URL: https://github.com/apache/camel-k/pull/4914#issuecomment-1851702772 @squakez can you launch the tests again please 🙏 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] feat(install): Separate namespaced and descoped rbacs [camel-k]

2023-12-05 Thread via GitHub
github-actions[bot] commented on PR #4914: URL: https://github.com/apache/camel-k/pull/4914#issuecomment-1840285278 :camel: **Thank you for contributing!** Code Coverage Report :warning: - Coverage changed: 33.6% --> 33.5% (Coverage difference: **-.1%**) -- This is an automated mes

Re: [PR] feat(install): Separate namespaced and descoped rbacs [camel-k]

2023-11-20 Thread via GitHub
github-actions[bot] commented on PR #4914: URL: https://github.com/apache/camel-k/pull/4914#issuecomment-1819073303 :camel: **Thank you for contributing!** Code Coverage Report :warning: - Coverage changed: 33.6% --> 33.5% (Coverage difference: **-.1%**) -- This is an automated mes

Re: [PR] feat(install): Separate namespaced and descoped rbacs [camel-k]

2023-11-20 Thread via GitHub
github-actions[bot] commented on PR #4914: URL: https://github.com/apache/camel-k/pull/4914#issuecomment-1818730663 :camel: **Thank you for contributing!** Code Coverage Report :warning: - Coverage changed: 33.6% --> 33.5% (Coverage difference: **-.1%**) -- This is an automated mes

Re: [PR] feat(install): Separate namespaced and descoped rbacs [camel-k]

2023-11-17 Thread via GitHub
github-actions[bot] commented on PR #4914: URL: https://github.com/apache/camel-k/pull/4914#issuecomment-1816411380 :camel: **Thank you for contributing!** Code Coverage Report :warning: - Coverage changed: 33.6% --> 33.5% (Coverage difference: **-.1%**) -- This is an automated mes

Re: [PR] feat(install): Separate namespaced and descoped rbacs [camel-k]

2023-11-16 Thread via GitHub
claudio4j commented on code in PR #4914: URL: https://github.com/apache/camel-k/pull/4914#discussion_r1396501841 ## pkg/install/operator.go: ## @@ -200,44 +199,6 @@ func OperatorOrCollect(ctx context.Context, cmd *cobra.Command, c client.Client,

Re: [PR] feat(install): Separate namespaced and descoped rbacs [camel-k]

2023-11-16 Thread via GitHub
gansheer commented on PR #4914: URL: https://github.com/apache/camel-k/pull/4914#issuecomment-1813966332 @oscerd @christophd @squakez Could you trigger the e2e tests please :pray: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] feat(install): Separate namespaced and descoped rbacs [camel-k]

2023-11-14 Thread via GitHub
gansheer commented on code in PR #4914: URL: https://github.com/apache/camel-k/pull/4914#discussion_r1392570618 ## pkg/install/operator.go: ## @@ -200,44 +199,6 @@ func OperatorOrCollect(ctx context.Context, cmd *cobra.Command, c client.Client,

[PR] feat(install): Separate namespaced and descoped rbacs [camel-k]

2023-11-10 Thread via GitHub
gansheer opened a new pull request, #4914: URL: https://github.com/apache/camel-k/pull/4914 Ref #3165 **Release Note** ```release-note NONE ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log