Re: [PR] fix(#4916): Improve component resolver [camel-k]

2023-11-16 Thread via GitHub
christophd merged PR #4919: URL: https://github.com/apache/camel-k/pull/4919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix(#4916): Improve component resolver [camel-k]

2023-11-15 Thread via GitHub
github-actions[bot] commented on PR #4919: URL: https://github.com/apache/camel-k/pull/4919#issuecomment-1813281996 :camel: **Thank you for contributing!** Code Coverage Report :heavy_check_mark: - Coverage changed: 33.5% --> 33.6% (Coverage difference: **+.1%**) -- This is an

Re: [PR] fix(#4916): Improve component resolver [camel-k]

2023-11-15 Thread via GitHub
christophd commented on PR #4919: URL: https://github.com/apache/camel-k/pull/4919#issuecomment-1813278463 @gansheer many thanks! I have merged your PR and rebased this one so lets see those CI jobs becoming green now -- This is an automated message from the Apache Git Service. To

Re: [PR] fix(#4916): Improve component resolver [camel-k]

2023-11-15 Thread via GitHub
gansheer commented on PR #4919: URL: https://github.com/apache/camel-k/pull/4919#issuecomment-1813095153 > @squakez I do not have the `Error: File is not goimports-ed (goimports)` locally and the changes in that PR did not touch any imports 路 The error is not from your PR. The

Re: [PR] fix(#4916): Improve component resolver [camel-k]

2023-11-15 Thread via GitHub
christophd commented on PR #4919: URL: https://github.com/apache/camel-k/pull/4919#issuecomment-1813088189 @squakez I do not have the `Error: File is not goimports-ed (goimports)` locally and the changes in that PR did not touch any imports 路 -- This is an automated message from the

Re: [PR] fix(#4916): Improve component resolver [camel-k]

2023-11-15 Thread via GitHub
claudio4j commented on PR #4919: URL: https://github.com/apache/camel-k/pull/4919#issuecomment-1812738443 In the prepare sections there are many `/usr/bin/tar: ../../../go/pkg/mod/go.uber.org/multierr@v1.11.0/.gitignore: Cannot open: File exists` errors. I restarted the checks. -- This

Re: [PR] fix(#4916): Improve component resolver [camel-k]

2023-11-15 Thread via GitHub
squakez commented on PR #4919: URL: https://github.com/apache/camel-k/pull/4919#issuecomment-1812664168 > @gansheer @squakez @claudio4j any idea why the validate CI job could be failing? " Error: File is not `goimports`-ed (goimports)" Checkstyles formatting I guess. --

Re: [PR] fix(#4916): Improve component resolver [camel-k]

2023-11-15 Thread via GitHub
christophd commented on PR #4919: URL: https://github.com/apache/camel-k/pull/4919#issuecomment-1812661568 @gansheer @squakez @claudio4j any idea why the validate CI job could be failing? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] fix(#4916): Improve component resolver [camel-k]

2023-11-14 Thread via GitHub
github-actions[bot] commented on PR #4919: URL: https://github.com/apache/camel-k/pull/4919#issuecomment-1811923414 :camel: **Thank you for contributing!** Code Coverage Report :heavy_check_mark: - Coverage changed: 33.5% --> 33.6% (Coverage difference: **+.1%**) -- This is an

[PR] fix(#4916): Improve component resolver [camel-k]

2023-11-14 Thread via GitHub
christophd opened a new pull request, #4919: URL: https://github.com/apache/camel-k/pull/4919 - Support URL query parameters when resolving components by given scheme - Do not resolve URLs that use parameter placeholder as a scheme - Properly extract scheme from URL that has query