lburgazzoli commented on PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#issuecomment-1968425032
@valdar @rinaldodev please have a look at this may impact
https://github.com/apache/camel-k/pull/5119/
--
This is an automated message from the Apache Git Service.
To respond to the
christophd merged PR #5138:
URL: https://github.com/apache/camel-k/pull/5138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.a
github-actions[bot] commented on PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#issuecomment-1967409618
:warning: Unit test coverage report - coverage decreased from 36.2% to 36%
(**-0.2%**)
--
This is an automated message from the Apache Git Service.
To respond to the message
christophd commented on PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#issuecomment-1967359750
> LGTM. Might be a good idea to regenerate the CRDs.
@gansheer I did a `make generate` and `make bundle` - am I missing something
else?
--
This is an automated message from th
christophd commented on code in PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#discussion_r1504366431
##
pkg/apis/camel/v1/integrationprofile_types.go:
##
@@ -0,0 +1,138 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license a
lburgazzoli commented on PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#issuecomment-1966690563
> > do you think we can do the translation ? just to simplify the logic on
the operator
>
> The resources are not exactly the same. The IntegrationProfile has only a
subset of
christophd commented on PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#issuecomment-1966677350
> do you think we can do the translation ? just to simplify the logic on the
operator
The resources are not exactly the same. The IntegrationProfile has only a
subset of setting
lburgazzoli commented on PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#issuecomment-1966439237
> > bet gets translated to an IntegrationProfile ?
>
> no, the resources can coexist at the moment
do you think we can do the translation ? just to simplify the logic on t
christophd commented on PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#issuecomment-1966435527
> bet gets translated to an IntegrationProfile ?
no, the resources can coexist at the moment
--
This is an automated message from the Apache Git Service.
To respond to the mess
lburgazzoli commented on PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#issuecomment-1966321112
> > I think we should first translate the local `IntegrationPlatform` to a
`IntegrationProfile` without removing it as this may have impacts to CI/CD
pipelines, similar to what has be
christophd commented on PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#issuecomment-1966307085
> I think we should first translate the local `IntegrationPlatform` to a
`IntegrationProfile` without removing it as this may have impacts to CI/CD
pipelines, similar to what has been
lburgazzoli commented on PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#issuecomment-1966212510
>
> Regarding the CRD changes: do you refer to the removed trait options on
the platform trait? What about auto migrating local IntegrationPlatform CRs to
IntegrationProfile CRs?
lburgazzoli commented on code in PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#discussion_r1503920930
##
docs/modules/ROOT/pages/installation/advanced/multi.adoc:
##
@@ -49,34 +49,37 @@ operator id:
kubectl annotate integration timer-to-log
camel.apache.org/operat
lburgazzoli commented on code in PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#discussion_r1503918912
##
pkg/apis/camel/v1/integrationprofile_types.go:
##
@@ -0,0 +1,138 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license
lburgazzoli commented on code in PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#discussion_r1503901906
##
docs/modules/ROOT/pages/installation/advanced/multi.adoc:
##
@@ -49,34 +49,37 @@ operator id:
kubectl annotate integration timer-to-log
camel.apache.org/operat
lburgazzoli commented on PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#issuecomment-1964944220
@valdar @rinaldodev mind having a loom too ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
christophd commented on PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#issuecomment-1964837119
@squakez @lburgazzoli @gansheer @claudio4j the PR is now ready for review.
If you want to have another look 🙏
I'd suggest to follow-up with these tasks in separate PRs:
* Fur
github-actions[bot] commented on PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#issuecomment-1964191615
:warning: Unit test coverage report - coverage decreased from 35.8% to 35.7%
(**-0.1%**)
--
This is an automated message from the Apache Git Service.
To respond to the messa
github-actions[bot] commented on PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#issuecomment-1963864933
:warning: Unit test coverage report - coverage decreased from 35.8% to 35.7%
(**-0.1%**)
--
This is an automated message from the Apache Git Service.
To respond to the messa
github-actions[bot] commented on PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#issuecomment-1959171418
:warning: Unit test coverage report - coverage decreased from 35.8% to 35.5%
(**-0.3%**)
--
This is an automated message from the Apache Git Service.
To respond to the messa
github-actions[bot] commented on PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#issuecomment-1957765953
:warning: Unit test coverage report - coverage decreased from 35.8% to 35.5%
(**-0.3%**)
--
This is an automated message from the Apache Git Service.
To respond to the messa
github-actions[bot] commented on PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#issuecomment-1956691881
:warning: Unit test coverage report - coverage decreased from 35.8% to 35.5%
(**-0.3%**)
--
This is an automated message from the Apache Git Service.
To respond to the messa
github-actions[bot] commented on PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#issuecomment-1956371787
:warning: Unit test coverage report - coverage decreased from 35.8% to 35.5%
(**-0.3%**)
--
This is an automated message from the Apache Git Service.
To respond to the messa
github-actions[bot] commented on PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#issuecomment-1954990566
:warning: Unit test coverage report - coverage decreased from 35.8% to 35.3%
(**-0.5%**)
--
This is an automated message from the Apache Git Service.
To respond to the messa
github-actions[bot] commented on PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#issuecomment-1953017543
:warning: Unit test coverage report - coverage decreased from 35.8% to 35.3%
(**-0.5%**)
--
This is an automated message from the Apache Git Service.
To respond to the messa
christophd commented on PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#issuecomment-1929220175
> 1. we can't remove/rename any field from custom resource for backward
compatibility reason. Anything we want to remove we must deprecate the fields
and eventually remove them in a ma
github-actions[bot] commented on PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#issuecomment-1927967866
:warning: Unit test coverage report - coverage decreased from 35.6% to 35.1%
(**-0.5%**)
--
This is an automated message from the Apache Git Service.
To respond to the messa
github-actions[bot] commented on PR #5138:
URL: https://github.com/apache/camel-k/pull/5138#issuecomment-1927891278
:warning: Unit test coverage report - coverage decreased from 35.6% to 35.1%
(**-0.5%**)
--
This is an automated message from the Apache Git Service.
To respond to the messa
christophd opened a new pull request, #5138:
URL: https://github.com/apache/camel-k/pull/5138
- Remove secondary IntegrationPlatform mode
- Reduce logic to a single IntegrationPlatform per operator instance
- Introduce IntegrationProfile custom resource definition
- Let user customiz
29 matches
Mail list logo
