squakez merged PR #5403:
URL: https://github.com/apache/camel-k/pull/5403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tdiesler commented on PR #5403:
URL: https://github.com/apache/camel-k/pull/5403#issuecomment-2100694018
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
squakez commented on PR #5403:
URL: https://github.com/apache/camel-k/pull/5403#issuecomment-2100190284
@tdiesler is this one ready to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
tdiesler commented on PR #5403:
URL: https://github.com/apache/camel-k/pull/5403#issuecomment-2098201889
> LGTM. I think you can remove the comments in the jib.go which result
misleading.
Changed to ...
```
// Build the integration for the arch configured in the
squakez commented on code in PR #5403:
URL: https://github.com/apache/camel-k/pull/5403#discussion_r1592250011
##
pkg/cmd/install.go:
##
@@ -594,6 +595,14 @@ func (o *installCmdOptions) setupIntegrationPlatform(c
client.Client, namespace
}
tdiesler commented on PR #5403:
URL: https://github.com/apache/camel-k/pull/5403#issuecomment-2098050371
I now set `platform.Status.Build.BuildConfiguration.ImagePlatforms` like
[this](https://github.com/tdiesler/camel-k/blob/ghi5292/pkg/cmd/install.go#L599)
on `kamel install`
```
squakez commented on PR #5403:
URL: https://github.com/apache/camel-k/pull/5403#issuecomment-2095357901
You don't need to create any new parameter. I think you can use
IntegrationPlatform trait [1] setting and just add the default builder trait
setting when it's missing. BTW, in order to
tdiesler commented on PR #5403:
URL: https://github.com/apache/camel-k/pull/5403#issuecomment-2093176168
I've created the property
[here](https://github.com/apache/camel-k/pull/5403/files#diff-eda3c0e8e19488b1353c8fe3c45149b065e9341263eff948eee48d5bac7590c7R138)
and initialized the default
tdiesler commented on PR #5403:
URL: https://github.com/apache/camel-k/pull/5403#issuecomment-2076675654
Ready to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
tdiesler commented on PR #5403:
URL: https://github.com/apache/camel-k/pull/5403#issuecomment-2074063570
The idea is, that (if not explicitly configured otherwise) we build the
integration for the arch we run on. Building the integration for multiarch is a
different story (and breaking
10 matches
Mail list logo
