github-actions[bot] commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-2071772976
:warning: Unit test coverage report - coverage decreased from 38% to 37.9%
(**-0.1%**)
--
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-2064617439
:warning: Unit test coverage report - coverage decreased from 38% to 37.9%
(**-0.1%**)
--
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-2061230296
:warning: Unit test coverage report - coverage decreased from 38% to 37.9%
(**-0.1%**)
--
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-2061059222
:warning: Unit test coverage report - coverage decreased from 38% to 37.9%
(**-0.1%**)
--
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-2059440873
:warning: Unit test coverage report - coverage decreased from 38% to 37.9%
(**-0.1%**)
--
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-2058785527
:warning: Unit test coverage report - coverage decreased from 38% to 37.9%
(**-0.1%**)
--
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-2049885062
:warning: Unit test coverage report - coverage decreased from 37.8% to 37.7%
(**-0.1%**)
--
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-2045101332
:warning: Unit test coverage report - coverage decreased from 37.8% to 37.7%
(**-0.1%**)
--
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-2009258746
:warning: Unit test coverage report - coverage decreased from 37.3% to 37.2%
(**-0.1%**)
--
This is an automated message from the Apache Git Service.
To respond to the
squakez commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-2009111979
@valdar please rebase against `main` again. The Quarkus native checks have
been fixed, so you won't need to run them manually any longer. Thanks.
--
This is an automated message from
squakez commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-2007558011
> > > I agree that we need some docs but since this PR is part of a larger
issue and the rationale was briefly explained in [#3397
lburgazzoli commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-2007343706
> > I agree that we need some docs but since this PR is part of a larger
issue and the rationale was briefly explained in [#3397
squakez commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-2007314372
> I'm not complaining about having to run them locally, I'm just noticing
the OSX build is almost always failing so I wonder what is the value of such
test. Now I can run the test
squakez commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-2007299761
> I agree that we need some docs but since this PR is part of a larger issue
and the rationale was briefly explained in [#3397
lburgazzoli commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-2007195419
> @lburgazzoli the problem is not the failure of the checks per se. As we've
done in other PR, everything that may affect the Quarkus native has to be
validated manually in order to
squakez commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-2006879615
@lburgazzoli the problem is not the failure of the checks per se. As we've
done in other PR, everything that may affect the Quarkus native has to be
validated manually in order to make
lburgazzoli commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-2006809347
> > > Also, several tests have failed and they don't seem to be the usual
flaky ones. I've restarted them.
> >
> >
> > The native tests seems to be failing constantly on
squakez commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-2006783913
> > Also, several tests have failed and they don't seem to be the usual
flaky ones. I've restarted them.
>
> The native tests seems to be failing constantly on OSX, can't we skip
lburgazzoli commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-2006770214
> Also, several tests have failed and they don't seem to be the usual flaky
ones. I've restarted them.
The native tests seems to be failing constantly on OSX, can't we skip
squakez commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-2006744346
Also, several tests have failed and they don't seem to be the usual flaky
ones. I've restarted them.
--
This is an automated message from the Apache Git Service.
To respond to the
squakez commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-2006739926
> @christophd @squakez I guess this is now in a good shape to be merged
I haven't received any feedback about my last 2 comments. We need to run
manually the native checks and it
lburgazzoli commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-2006711589
@christophd @squakez I guess this is now in a good shape to be merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
github-actions[bot] commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-2004577345
:warning: Unit test coverage report - coverage decreased from 37.2% to 37.1%
(**-0.1%**)
--
This is an automated message from the Apache Git Service.
To respond to the
squakez commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-1983848486
I've enabled Quarkus Native tests. However it's very likely they fail due to
some infrastructure problem that we have not yet tackled. In such
circumstances, please, run the Quarkus
valdar commented on code in PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#discussion_r1511438324
##
pkg/cmd/manager/controller.go:
##
@@ -0,0 +1,218 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the
squakez commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-1976919321
@valdar I don't have enough context to review this one, sorry. The immediate
impression I have is that from community perspective it would be good to have
some design diagram and some
valdar commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-1976717697
> The main concern I have is about code duplication (maintainability) and
performance loss. About the first, I think it would be a matter of abstracting
the code from the operator and be
valdar commented on code in PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#discussion_r1511254321
##
pkg/cmd/platformcontroller/platformcontroller.go:
##
@@ -0,0 +1,272 @@
+/*
Review Comment:
I have abstracted as much code as I could in the
valdar commented on code in PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#discussion_r1511244894
##
e2e/support/test_support.go:
##
@@ -2245,7 +2253,7 @@ func OperatorPod(ns string) func() *corev1.Pod {
if err := TestClient().List(TestContext, ,
valdar commented on code in PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#discussion_r1511237712
##
pkg/cmd/manager/controller.go:
##
@@ -0,0 +1,218 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the
valdar commented on code in PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#discussion_r1511236658
##
pkg/cmd/manager/controller.go:
##
@@ -0,0 +1,218 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the
lburgazzoli commented on code in PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#discussion_r1511126823
##
pkg/cmd/manager/controller.go:
##
@@ -0,0 +1,218 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements.
lburgazzoli commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-1976276298
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
lburgazzoli commented on code in PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#discussion_r1510901240
##
pkg/cmd/manager/controller.go:
##
@@ -0,0 +1,218 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements.
lburgazzoli commented on code in PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#discussion_r1510746942
##
pkg/cmd/manager/controller.go:
##
@@ -0,0 +1,218 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements.
lburgazzoli commented on code in PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#discussion_r1510737986
##
e2e/support/test_support.go:
##
@@ -2245,7 +2253,7 @@ func OperatorPod(ns string) func() *corev1.Pod {
if err := TestClient().List(TestContext,
lburgazzoli commented on code in PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#discussion_r1505514030
##
pkg/cmd/manager/controller.go:
##
@@ -0,0 +1,310 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements.
lburgazzoli commented on code in PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#discussion_r1505496052
##
pkg/cmd/operator/operator.go:
##
@@ -70,122 +51,48 @@ import (
var log = logutil.Log.WithName("cmd")
Review Comment:
may be better to use a better log
lburgazzoli commented on code in PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#discussion_r1505497518
##
pkg/cmd/platformcontroller/platformcontroller.go:
##
@@ -0,0 +1,89 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor
lburgazzoli commented on code in PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#discussion_r1505496052
##
pkg/cmd/operator/operator.go:
##
@@ -70,122 +51,48 @@ import (
var log = logutil.Log.WithName("cmd")
Review Comment:
may be better to have a better log
lburgazzoli commented on code in PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#discussion_r1505494747
##
pkg/cmd/manager/controller.go:
##
@@ -0,0 +1,310 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements.
lburgazzoli commented on code in PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#discussion_r1505456692
##
pkg/cmd/manager/controller.go:
##
@@ -0,0 +1,310 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements.
lburgazzoli commented on code in PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#discussion_r1505458111
##
pkg/cmd/manager/controller.go:
##
@@ -0,0 +1,310 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements.
lburgazzoli commented on code in PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#discussion_r1505456692
##
pkg/cmd/manager/controller.go:
##
@@ -0,0 +1,310 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements.
lburgazzoli commented on code in PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#discussion_r1504961262
##
pkg/cmd/manager/controller.go:
##
@@ -0,0 +1,310 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements.
lburgazzoli commented on code in PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#discussion_r1504950108
##
pkg/cmd/manager/controller.go:
##
@@ -0,0 +1,310 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements.
lburgazzoli commented on code in PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#discussion_r1504941598
##
pkg/cmd/manager/controller.go:
##
@@ -0,0 +1,310 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements.
lburgazzoli commented on code in PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#discussion_r1504936589
##
build/test.log:
##
Review Comment:
this is likely a file we don't want to include
--
This is an automated message from the Apache Git Service.
To
lburgazzoli commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-1966096570
@valdar @rinaldodev mind rebasing ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-1947492219
:warning: Unit test coverage report - coverage decreased from 35.8% to 35.7%
(**-0.1%**)
--
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-1947370184
:warning: Unit test coverage report - coverage decreased from 35.8% to 35.7%
(**-0.1%**)
--
This is an automated message from the Apache Git Service.
To respond to the
squakez commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-1926467434
> What about these tests:
>
> ❌ TestMetrics (3m0.27s) ❌ TestMetrics/reconciliation_duration_metric (10ms)
>
> they seems flaky to me, first run they were passing, they are
valdar commented on PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#issuecomment-1925205616
What about these tests:
❌ TestMetrics (3m0.27s)
❌ TestMetrics/reconciliation_duration_metric (10ms)
they seems flaky to me, first run they were passing, they are passing
squakez commented on code in PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#discussion_r1473236743
##
pkg/cmd/platformcontroller/platformcontroller.go:
##
@@ -0,0 +1,272 @@
+/*
Review Comment:
I see a lot of duplicated code. I think it would be wiser to abstract
gansheer commented on code in PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#discussion_r1470871958
##
config/manager/platformcontroller-deployment.yaml:
##
@@ -0,0 +1,89 @@
+# ---
+# Licensed
gansheer commented on code in PR #5119:
URL: https://github.com/apache/camel-k/pull/5119#discussion_r1470872609
##
config/manager/platformcontroller-deployment.yaml:
##
@@ -0,0 +1,89 @@
+# ---
+# Licensed
valdar opened a new pull request, #5119:
URL: https://github.com/apache/camel-k/pull/5119
Fix for #4948 that is part of #3397
A `platformcontroller` command is added as subcommand of `kamel`; it runs an
operator like the `operator` subcomand does, but platformcontroller would
57 matches
Mail list logo
