[camel-k] Diff for: [GitHub] nicolaferraro merged pull request #329: chore: refactor source inspector
diff --git a/pkg/metadata/dependencies.go b/pkg/metadata/dependencies.go
deleted file mode 100644
index f70efdd1..
--- a/pkg/metadata/dependencies.go
+++ /dev/null
@@ -1,88 +0,0 @@
-/*
-Licensed to the Apache Software Foundation (ASF) under one or more
-contributor license agreements. See the NOTICE file distributed with
-this work for additional information regarding copyright ownership.
-The ASF licenses this file to You under the Apache License, Version 2.0
-(the "License"); you may not use this file except in compliance with
-the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
-package metadata
-
-import (
- "regexp"
- "sort"
- "strings"
-
- "github.com/apache/camel-k/pkg/apis/camel/v1alpha1"
- "github.com/apache/camel-k/pkg/util/camel"
-)
-
-var (
- additionalDependencies = map[string]string{
- ".*JsonLibrary\\.Jackson.*": "camel:jackson",
- }
-)
-
-// discoverDependencies returns a list of dependencies required by the given
source code
-func discoverDependencies(source v1alpha1.SourceSpec, fromURIs []string,
toURIs []string) []string {
- candidateMap := make(map[string]bool)
- uris := make([]string, 0, len(fromURIs)+len(toURIs))
- uris = append(uris, fromURIs...)
- uris = append(uris, toURIs...)
- for _, uri := range uris {
- candidateComp := decodeComponent(uri)
- if candidateComp != "" {
- candidateMap[candidateComp] = true
- }
- }
- additional := findAdditionalDependencies(source)
- for _, dep := range additional {
- candidateMap[dep] = true
- }
- // Remove duplicates and sort
- candidateComponents := make([]string, 0, len(candidateMap))
- for cmp := range candidateMap {
- candidateComponents = append(candidateComponents, cmp)
- }
- sort.Strings(candidateComponents)
- return candidateComponents
-}
-
-func decodeComponent(uri string) string {
- uriSplit := strings.SplitN(uri, ":", 2)
- if len(uriSplit) < 2 {
- return ""
- }
- uriStart := uriSplit[0]
- if component := camel.Runtime.GetArtifactByScheme(uriStart); component
!= nil {
- artifactID := component.ArtifactID
- if component.GroupID == "org.apache.camel" &&
strings.HasPrefix(artifactID, "camel-") {
- return "camel:" + artifactID[6:]
- }
- if component.GroupID == "org.apache.camel.k" &&
strings.HasPrefix(artifactID, "camel-") {
- return "camel-k:" + artifactID[6:]
- }
- return "mvn:" + component.GroupID + ":" + artifactID + ":" +
component.Version
- }
- return ""
-}
-
-func findAdditionalDependencies(source v1alpha1.SourceSpec) []string {
- additional := make([]string, 0)
- for pattern, dep := range additionalDependencies {
- pat := regexp.MustCompile(pattern)
- if pat.MatchString(source.Content) {
- additional = append(additional, dep)
- }
- }
- return additional
-}
diff --git a/pkg/metadata/metadata.go b/pkg/metadata/metadata.go
index bbdacfdb..5b2940c5 100644
--- a/pkg/metadata/metadata.go
+++ b/pkg/metadata/metadata.go
@@ -28,9 +28,11 @@ import (
func ExtractAll(sources []v1alpha1.SourceSpec) IntegrationMetadata {
// neutral metadata
meta := IntegrationMetadata{
- Dependencies:[]string{},
- FromURIs:[]string{},
- ToURIs: []string{},
+ Metadata: src.Metadata{
+ FromURIs: []string{},
+ ToURIs: []string{},
+ Dependencies: []string{},
+ },
PassiveEndpoints:true,
RequiresHTTPService: false,
}
@@ -54,9 +56,11 @@ func merge(m1 IntegrationMetadata, m2 IntegrationMetadata)
IntegrationMetadata {
}
sort.Strings(allDependencies)
return IntegrationMetadata{
- FromURIs:append(m1.FromURIs, m2.FromURIs...),
- ToURIs: append(m1.ToURIs, m2.ToURIs...),
- Dependencies:allDependencies,
+ Metadata: src.Metadata{
+ FromURIs: append(m1.FromURIs, m2.FromURIs...),
+ ToURIs: append(m1.ToURIs, m2.ToURIs...),
+ Dependencies: allDependencies,
+ },
[camel] Diff for: [GitHub] asfgit closed pull request #2708: CAMEL-13054: Olingo4Endpoint - avoid swallowing consumer options
diff --git
a/components/camel-olingo4/camel-olingo4-component/src/main/java/org/apache/camel/component/olingo4/Olingo4Endpoint.java
b/components/camel-olingo4/camel-olingo4-component/src/main/java/org/apache/camel/component/olingo4/Olingo4Endpoint.java
index dfd9e93738f..c1ccfb4b413 100644
---
a/components/camel-olingo4/camel-olingo4-component/src/main/java/org/apache/camel/component/olingo4/Olingo4Endpoint.java
+++
b/components/camel-olingo4/camel-olingo4-component/src/main/java/org/apache/camel/component/olingo4/Olingo4Endpoint.java
@@ -196,6 +196,14 @@ private void parseQueryParams(Map options)
{
final Map.Entry entry = it.next();
final String paramName = entry.getKey();
+/**
+ * Avoid swallowing consumer scheduler properties, which
+ * get processed in configureProperties()
+ */
+if (paramName.startsWith("consumer.")) {
+continue;
+}
+
if (!endpointPropertyNames.contains(paramName)) {
// add to query params
With regards,
Apache Git Services
[camel-k] Diff for: [GitHub] lburgazzoli closed pull request #325: Release some predefined images for Knative
diff --git a/.gitignore b/.gitignore
index e43f8299..6361983f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,6 +1,7 @@
# Binary files
/camel-k
/kamel
+/publisher
# Released Packages
*.tar.gz
diff --git a/cmd/util/publisher/publisher.go b/cmd/util/publisher/publisher.go
new file mode 100644
index ..0ce04621
--- /dev/null
+++ b/cmd/util/publisher/publisher.go
@@ -0,0 +1,199 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package main
+
+import (
+ "context"
+ "fmt"
+ "io/ioutil"
+ "os"
+ "os/exec"
+ "path"
+ "path/filepath"
+ "sort"
+ "strings"
+ "time"
+
+ "github.com/apache/camel-k/deploy"
+ "github.com/apache/camel-k/pkg/apis"
+ "github.com/apache/camel-k/pkg/apis/camel/v1alpha1"
+ "github.com/apache/camel-k/pkg/builder"
+ "github.com/apache/camel-k/pkg/platform/images"
+ "github.com/apache/camel-k/pkg/util/camel"
+ "github.com/apache/camel-k/pkg/util/kubernetes"
+ "github.com/pkg/errors"
+ "github.com/spf13/cobra"
+ clientscheme "k8s.io/client-go/kubernetes/scheme"
+)
+
+// PublisherOptions --
+type PublisherOptions struct {
+ StartWith string
+ EndWith string
+ BuildAttempts int
+}
+
+// Publishes predefined images for all Camel components
+func main() {
+ options := PublisherOptions{}
+
+ var cmd = cobra.Command{
+ Use: "publisher",
+ Short: "Publisher allows to publish base images before a
release",
+ Run: options.run,
+ }
+
+ cmd.Flags().StringVar(, "start-with", "", "The
component to start with")
+ cmd.Flags().StringVar(, "end-with", "", "The component
to end with")
+ cmd.Flags().IntVar(, "attempts", 5, "The maximum
number of build attempts for each image")
+
+ panicIfErr(cmd.Execute())
+}
+
+func (options *PublisherOptions) run(cmd *cobra.Command, args []string) {
+ scheme := clientscheme.Scheme
+ panicIfErr(apis.AddToScheme(scheme))
+
+ platRun, err := kubernetes.LoadResourceFromYaml(scheme,
deploy.Resources["platform-cr.yaml"])
+ panicIfErr(err)
+
+ p := platRun.(*v1alpha1.IntegrationPlatform)
+
+ started := options.StartWith == ""
+
+ keys := make([]string, 0, len(camel.Runtime.Artifacts))
+ for k := range camel.Runtime.Artifacts {
+ keys = append(keys, k)
+ }
+ sort.Strings(keys)
+
+ for _, k := range keys {
+ a := camel.Runtime.Artifacts[k]
+ if a.GroupID == "org.apache.camel" {
+ component := strings.TrimPrefix(a.ArtifactID, "camel-")
+ if options.StartWith == component {
+ started = true
+ }
+
+ if started {
+ fmt.Printf("building component %s\n", component)
+ options.buildWithAttempts(component,
p.Spec.Build.CamelVersion)
+ } else {
+ fmt.Printf("skipping component %s\n", component)
+ }
+
+ if options.EndWith == component {
+ fmt.Println("reached final component")
+ break
+ }
+ }
+ }
+}
+
+func (options *PublisherOptions) buildWithAttempts(component string,
camelVersion string) {
+ var err error
+ for i := 0; i < options.BuildAttempts; i++ {
+ err = options.build(component, camelVersion)
+ if err != nil {
+ sleepTime := 5 * (i + 1)
+ fmt.Printf("waiting %d seconds to recover from error
%v\n", sleepTime, err)
+ time.Sleep(time.Duration(sleepTime) * time.Second)
+ } else {
+ return
+ }
+ }
+ panicIfErr(errors.Wrap(err, "build failed after maximum number of
attempts"))
+}
+
+func (options *PublisherOptions) build(component string, camelVersion string)
error {
+ dir, err := ioutil.TempDir(os.TempDir(), "camel-k-build-")
+ if err != nil {
+ return err
+
[GitHub] [camel-quarkus] gnodet opened a new pull request #373: Upgrade to quarkus 0.28.0
gnodet opened a new pull request #373: Upgrade to quarkus 0.28.0 URL: https://github.com/apache/camel-quarkus/pull/373 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #371: Issue 337
ppalaga commented on a change in pull request #371: Issue 337 URL: https://github.com/apache/camel-quarkus/pull/371#discussion_r342061236 ## File path: build/eclipse-formatter-config.xml ## @@ -262,5 +262,6 @@ + Review comment: Adding the start/end tags explicitly would be nice, plus they should be the same as we have in checkstyle ``` ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #371: Issue 337
ppalaga commented on a change in pull request #371: Issue 337 URL: https://github.com/apache/camel-quarkus/pull/371#discussion_r342058383 ## File path: build/eclipse-formatter-config.xml ## @@ -0,0 +1,264 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + Review comment: Lines having more than 128 chars are hard to review on GitHub. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #371: Issue 337
ppalaga commented on a change in pull request #371: Issue 337 URL: https://github.com/apache/camel-quarkus/pull/371#discussion_r342054951 ## File path: build/eclipse-formatter-config.xml ## @@ -0,0 +1,264 @@ + + + + + + Review comment: All these `value="18"` occurrences feel strange. I'd expect them to be something divisible by 4, e.g. 16, so that it is possible to get them by pressing tab four times in an IDE/editor? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #371: Issue 337
ppalaga commented on a change in pull request #371: Issue 337 URL: https://github.com/apache/camel-quarkus/pull/371#discussion_r342052026 ## File path: build/eclipse-formatter-config.xml ## @@ -0,0 +1,264 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + Review comment: Is there a good reason to limit the line length in comments at 80? The common practice in this repo is 120. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] gastaldi commented on issue #372: Upgrade to Quarkus 0.28.0
gastaldi commented on issue #372: Upgrade to Quarkus 0.28.0 URL: https://github.com/apache/camel-quarkus/issues/372#issuecomment-549463256 This is the stacktrace seen in quarkus-platform: ```java Nov 04, 2019 12:57:57 PM io.quarkus.vertx.http.runtime.QuarkusErrorHandler handle ERROR: HTTP Request to /metrics/application failed, error id: d4150f81-9045-45c7-b952-f06078d17392-1 java.lang.AbstractMethodError at io.smallrye.metrics.exporters.JsonExporter.getValueFromMetric(JsonExporter.java:286) at io.smallrye.metrics.exporters.JsonExporter.exportSimpleMetric(JsonExporter.java:201) at io.smallrye.metrics.exporters.JsonExporter.lambda$exportMetricsByName$1(JsonExporter.java:132) at java.util.HashMap.forEach(HashMap.java:1289) at io.smallrye.metrics.exporters.JsonExporter.exportMetricsByName(JsonExporter.java:130) at io.smallrye.metrics.exporters.JsonExporter.lambda$exportMetricsForMap$8(JsonExporter.java:193) at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) at java.util.HashMap$EntrySpliterator.forEachRemaining(HashMap.java:1699) at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482) at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150) at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173) at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485) at io.smallrye.metrics.exporters.JsonExporter.exportMetricsForMap(JsonExporter.java:194) at io.smallrye.metrics.exporters.JsonExporter.exportOneRegistry(JsonExporter.java:178) at io.smallrye.metrics.exporters.JsonExporter.exportOneScope(JsonExporter.java:59) at io.smallrye.metrics.MetricsRequestHandler.handleRequest(MetricsRequestHandler.java:153) at io.smallrye.metrics.MetricsRequestHandler_ClientProxy.handleRequest(MetricsRequestHandler_ClientProxy.zig:246) at io.quarkus.smallrye.metrics.runtime.SmallRyeMetricsHandler.handle(SmallRyeMetricsHandler.java:35) at io.quarkus.smallrye.metrics.runtime.SmallRyeMetricsHandler.handle(SmallRyeMetricsHandler.java:17) at io.quarkus.vertx.http.runtime.ResumeHandler.handle(ResumeHandler.java:19) at io.quarkus.vertx.http.runtime.ResumeHandler.handle(ResumeHandler.java:6) at io.vertx.ext.web.impl.BlockingHandlerDecorator.lambda$handle$0(BlockingHandlerDecorator.java:48) at io.vertx.core.impl.ContextImpl.lambda$executeBlocking$2(ContextImpl.java:316) at io.vertx.core.impl.TaskQueue.run(TaskQueue.java:76) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.lang.Thread.run(Thread.java:748) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] gnodet opened a new pull request #375: Reuse camel package maven plugin to avoid duplicating code, fixes #336
gnodet opened a new pull request #375: Reuse camel package maven plugin to avoid duplicating code, fixes #336 URL: https://github.com/apache/camel-quarkus/pull/375 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #371: Issue 337
ppalaga commented on a change in pull request #371: Issue 337 URL: https://github.com/apache/camel-quarkus/pull/371#discussion_r342163963 ## File path: examples/timer-log-xml/src/main/java/org/acme/timer/package-info.java ## @@ -1,18 +1,14 @@ /** - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE + * file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file + * to You under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at Review comment: This license header change looks unwanted. It is perhaps caused by the fact that it is using a javadoc comment style `/**` instead of plain `/*` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #371: Issue 337
ppalaga commented on a change in pull request #371: Issue 337
URL: https://github.com/apache/camel-quarkus/pull/371#discussion_r342168028
##
File path: examples/rest-json/src/main/java/org/acme/rest/json/Fruit.java
##
@@ -58,7 +58,7 @@ public boolean equals(Object obj) {
return false;
}
-Fruit other = (Fruit) obj;
+Fruit other = (Fruit)obj;
Review comment:
Having a space after the cast seems to be more common, even in the main
Camel code base.
The following setting would do that:
```
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] gastaldi edited a comment on issue #372: Upgrade to Quarkus 0.28.0
gastaldi edited a comment on issue #372: Upgrade to Quarkus 0.28.0 URL: https://github.com/apache/camel-quarkus/issues/372#issuecomment-549364017 @gnodet it looks like it. The tests run fine for me too when bumping the quarkus version in this repository, but fails in the https://github.com/quarkusio/quarkus-platform/ (which in theory should be the same)? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #370: Improve the Github workflows: use -ntp, check licenses, better step a…
ppalaga commented on issue #370: Improve the Github workflows: use -ntp, check licenses, better step a… URL: https://github.com/apache/camel-quarkus/pull/370#issuecomment-549429222 e89d48e goes back to `-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] gastaldi opened a new issue #372: Upgrade to Quarkus 0.28.0
gastaldi opened a new issue #372: Upgrade to Quarkus 0.28.0 URL: https://github.com/apache/camel-quarkus/issues/372 Right now simply bumping the version in the platform BOM in https://github.com/quarkusio/quarkus-platform fails on the MicrProfileMetricsTest: ```bash [ERROR] Failures: [ERROR] MicroProfileMetricsTest.testMicroProfileMetricsCamelContextEventNotifier:130->getMetricIntValue:135->getApplicationMetrics:162 1 expectation failed. Expected status code <200> but was <500>. [ERROR] MicroProfileMetricsTest.testMicroProfileMetricsConcurrentGauge:50->getMetricIntValue:135->getApplicationMetrics:162 1 expectation failed. Expected status code <200> but was <500>. [ERROR] MicroProfileMetricsTest.testMicroProfileMetricsCounter:40->getMetricIntValue:135->getApplicationMetrics:162 1 expectation failed. Expected status code <200> but was <500>. [ERROR] MicroProfileMetricsTest.testMicroProfileMetricsExchangeEventNotifier:125->getMetricIntValue:135->getApplicationMetrics:162 1 expectation failed. Expected status code <200> but was <500>. [ERROR] MicroProfileMetricsTest.testMicroProfileMetricsGauge:65->getMetricIntValue:135->getApplicationMetrics:162 1 expectation failed. Expected status code <200> but was <500>. [ERROR] MicroProfileMetricsTest.testMicroProfileMetricsHistogram:73->getMetricIntValue:135->getApplicationMetrics:162 1 expectation failed. Expected status code <200> but was <500>. [ERROR] MicroProfileMetricsTest.testMicroProfileMetricsMessageHistoryFactory:106->getApplicationMetrics:162 1 expectation failed. Expected status code <200> but was <500>. [ERROR] MicroProfileMetricsTest.testMicroProfileMetricsMeter:81->getMetricIntValue:135->getApplicationMetrics:162 1 expectation failed. Expected status code <200> but was <500>. [ERROR] MicroProfileMetricsTest.testMicroProfileMetricsRouteEventNotifier:116->getMetricIntValue:135->getApplicationMetrics:162 1 expectation failed. Expected status code <200> but was <500>. [ERROR] MicroProfileMetricsTest.testMicroProfileMetricsRoutePolicyFactory:97->getMetricIntValue:135->getApplicationMetrics:162 1 expectation failed. Expected status code <200> but was <500>. [ERROR] MicroProfileMetricsTest.testMicroProfileMetricsTimer:89->getMetricFloatValue:139->getApplicationMetrics:162 1 expectation failed. Expected status code <200> but was <500>. [INFO] [ERROR] Tests run: 11, Failures: 11, Errors: 0, Skipped: 0 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #373: Upgrade to quarkus 0.28.0
lburgazzoli commented on issue #373: Upgrade to quarkus 0.28.0 URL: https://github.com/apache/camel-quarkus/pull/373#issuecomment-549408850 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] apupier opened a new pull request #1042: Fix typo in doc
apupier opened a new pull request #1042: Fix typo in doc URL: https://github.com/apache/camel-k/pull/1042 Signed-off-by: Aurélien Pupier **Release Note** ```release-note NONE ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] gastaldi commented on issue #372: Upgrade to Quarkus 0.28.0
gastaldi commented on issue #372: Upgrade to Quarkus 0.28.0 URL: https://github.com/apache/camel-quarkus/issues/372#issuecomment-549364017 @gnodet it looks like it. The tests run fine for me too when bumping the quarkus version in this repository, but fails in the https://github.com/quarkusio/quarkus-platform/tree/0.28 (which in theory should be the same)? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] gnodet commented on issue #372: Upgrade to Quarkus 0.28.0
gnodet commented on issue #372: Upgrade to Quarkus 0.28.0 URL: https://github.com/apache/camel-quarkus/issues/372#issuecomment-549360830 @gastaldi are you sure this isn't a transient issue ? the tests do run fine for me with #373 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #373: Upgrade to quarkus 0.28.0
asf-ci commented on issue #373: Upgrade to quarkus 0.28.0 URL: https://github.com/apache/camel-quarkus/pull/373#issuecomment-549457804 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/381/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti closed issue #990: support for quarkus in JVM mode
astefanutti closed issue #990: support for quarkus in JVM mode URL: https://github.com/apache/camel-k/issues/990 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti merged pull request #1013: feat(quarkus): Initial Quarkus support
astefanutti merged pull request #1013: feat(quarkus): Initial Quarkus support URL: https://github.com/apache/camel-k/pull/1013 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #370: Improve the Github workflows: use -ntp, check licenses, better step a…
lburgazzoli commented on issue #370: Improve the Github workflows: use -ntp, check licenses, better step a… URL: https://github.com/apache/camel-quarkus/pull/370#issuecomment-549412933 @ppalaga one of the actions is failing This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #370: Improve the Github workflows: use -ntp, check licenses, better step a…
ppalaga commented on issue #370: Improve the Github workflows: use -ntp, check licenses, better step a… URL: https://github.com/apache/camel-quarkus/pull/370#issuecomment-549427171 > @ppalaga one of the actions is failing Interesting. Looks like the Quarkus tooling depends on a pre-3.6.1 Maven CLI artifact. Let me fix it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] gnodet commented on a change in pull request #371: Issue 337
gnodet commented on a change in pull request #371: Issue 337 URL: https://github.com/apache/camel-quarkus/pull/371#discussion_r342145196 ## File path: build/eclipse-formatter-config.xml ## @@ -0,0 +1,264 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + Review comment: I agree that 80 is a bit too small, but the original file comes directly from the camel tree. I'm happy to make it easier to use though. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #348: Fix #220 platform-http component should return 204 for success and no…
ppalaga commented on issue #348: Fix #220 platform-http component should return
204 for success and no…
URL: https://github.com/apache/camel-quarkus/pull/348#issuecomment-547795777
bf76e48 replaced `LOG.debugf(e, "Could not handle '%s'", path)` with
`getExceptionHandler().handleException("Failed handling platform-http endpoint
" + path, exchg, e)` and enclosed `toExchange(ctx)` in the exception handler
scope.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #344: WIP: Move to Quarkus 0.27+ yaml descriptor
lburgazzoli commented on issue #344: WIP: Move to Quarkus 0.27+ yaml descriptor URL: https://github.com/apache/camel-quarkus/pull/344#issuecomment-547743272 cherry picking the commits here into https://github.com/apache/camel-quarkus/pull/350 so I can work also on upgrading the validation script This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #348: Fix #220 platform-http component should return 204 for success and no…
asf-ci commented on issue #348: Fix #220 platform-http component should return 204 for success and no… URL: https://github.com/apache/camel-quarkus/pull/348#issuecomment-547834984 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/359/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli closed issue #220: platform-http component should return 204 for success and no body
lburgazzoli closed issue #220: platform-http component should return 204 for success and no body URL: https://github.com/apache/camel-quarkus/issues/220 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli closed issue #299: Use Camel's async processor in platform-http
lburgazzoli closed issue #299: Use Camel's async processor in platform-http URL: https://github.com/apache/camel-quarkus/issues/299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli merged pull request #348: Fix #220 platform-http component should return 204 for success and no…
lburgazzoli merged pull request #348: Fix #220 platform-http component should return 204 for success and no… URL: https://github.com/apache/camel-quarkus/pull/348 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga opened a new issue #352: Re-enable the FHIR tests once the FHIR testing service is back again
ppalaga opened a new issue #352: Re-enable the FHIR tests once the FHIR testing service is back again URL: https://github.com/apache/camel-quarkus/issues/352 Set `quarkus.camel.fhir.enable-dstu3=true` in https://github.com/apache/camel-quarkus/blob/master/integration-tests/fhir/src/main/resources/application.properties#L29 and ``` true true ``` in https://github.com/apache/camel-quarkus/blob/master/integration-tests/fhir/pom.xml#L81-L82 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] davsclaus commented on a change in pull request #348: Fix #220 platform-http component should return 204 for success and no…
davsclaus commented on a change in pull request #348: Fix #220 platform-http
component should return 204 for success and no…
URL: https://github.com/apache/camel-quarkus/pull/348#discussion_r340464216
##
File path:
extensions/platform-http/runtime/src/main/java/org/apache/camel/quarkus/component/platform/http/runtime/QuarkusPlatformHttpConsumer.java
##
@@ -111,13 +111,18 @@ protected void doStart() throws Exception {
newRoute.handler(
ctx -> {
+final Exchange exchange = toExchange(ctx);
try {
-final Exchange e = toExchange(ctx);
-getProcessor().process(e);
-writeResponse(ctx, e,
getEndpoint().getHeaderFilterStrategy());
+createUoW(exchange);
+getAsyncProcessor().process(
+exchange,
+doneSync -> writeResponse(ctx, exchange,
getEndpoint().getHeaderFilterStrategy())
+);
} catch (Exception e) {
LOG.debugf(e, "Could not handle '%s'", path);
ctx.fail(e);
Review comment:
yeah ctx.fail is fine
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] dylanenabled opened a new issue #1030: Way to set a serviceaccount for the integration pod?
dylanenabled opened a new issue #1030: Way to set a serviceaccount for the integration pod? URL: https://github.com/apache/camel-k/issues/1030 I'm using AWS EKS to host a kubernetes cluster and I want my camelk integration to connect to an AWS SQS queue to receive messages. AWS recently released [IAM roles for service accounts ](https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts.html) which lets me attach a role to serviceaccounts with policies that allow the role to access the SQS service. (It does this by injecting environment variables and a secret volume into the pod containers with that service account attached). So, basically, is there a way to tell `kamel run` to attach a specific serviceaccount to the pod it creates? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #136: @ConfigProperty not injected in a RouteBuilder
ppalaga commented on issue #136: @ConfigProperty not injected in a RouteBuilder URL: https://github.com/apache/camel-quarkus/issues/136#issuecomment-547844788 I have primitive PoC how this could work. Plz. assign to me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #348: Fix #220 platform-http component should return 204 for success and no…
ppalaga commented on a change in pull request #348: Fix #220 platform-http
component should return 204 for success and no…
URL: https://github.com/apache/camel-quarkus/pull/348#discussion_r340461185
##
File path:
extensions/platform-http/runtime/src/main/java/org/apache/camel/quarkus/component/platform/http/runtime/QuarkusPlatformHttpConsumer.java
##
@@ -111,13 +111,18 @@ protected void doStart() throws Exception {
newRoute.handler(
ctx -> {
+final Exchange exchange = toExchange(ctx);
try {
-final Exchange e = toExchange(ctx);
-getProcessor().process(e);
-writeResponse(ctx, e,
getEndpoint().getHeaderFilterStrategy());
+createUoW(exchange);
+getAsyncProcessor().process(
+exchange,
+doneSync -> writeResponse(ctx, exchange,
getEndpoint().getHeaderFilterStrategy())
+);
} catch (Exception e) {
LOG.debugf(e, "Could not handle '%s'", path);
ctx.fail(e);
Review comment:
Yes, I'd see `getExceptionHandler().handleException(e)` as a good
replacement for the current `LOG.debugf(e, "Could not handle '%s'", path)`
because the default `LoggingExceptionHandler` just does some logging and the
message it logs is actually better than `Could not handle '%s'`.
But we still need to mark the Vert.x `RoutingContext` as failed somehow,
because otherwise it will hang forever, won't it? We have no custom
ExceptionHandler on the Camel side that would do this and I see no good reason
to create one, because calling `ctx.fail(e)` is much less code. WDYT?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] dylanenabled opened a new issue #1031: Support for AWS ECR in kaniko builder
dylanenabled opened a new issue #1031: Support for AWS ECR in kaniko builder URL: https://github.com/apache/camel-k/issues/1031 Currently the kaniko builder only supports pushing images to Google. I'd like it if kaniko could push builds to AWS ECR. It looks like this is fairly straightforward to implement in the kaniko image as described in the [documentation](https://github.com/GoogleContainerTools/kaniko#pushing-to-amazon-ecr). It looks like being able to define a `--registryDockerConfig` parameter when installing would work. This could save a provided docker `config.json` to a configmap, and then mounts it at `/kaniko/.docker` in the build image, similar to how the kaniko secret is saved. The aws account credentials could be saved similarly to how it is done for GCR. instead mounted to `/root/.aws`, but this could be optional because the IAM credentials could also be provided to the builder by EKS via the IAM integration using the camel-k-builder serviceaccount if the cluster has that set up (see #1030) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] hguerrero commented on issue #563: Inject CamelContext into Java DSL RouteBuilder
hguerrero commented on issue #563: Inject CamelContext into Java DSL RouteBuilder URL: https://github.com/apache/camel-k/issues/563#issuecomment-548928318 @davsclaus @lburgazzoli can you add an example of how to configure the context with a connection factory using Java DSL? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] pabloxtiyo opened a new issue #1039: Camel K Operator is not reading the Telegram endpoint API-Key properly.
pabloxtiyo opened a new issue #1039: Camel K Operator is not reading the Telegram endpoint API-Key properly. URL: https://github.com/apache/camel-k/issues/1039 Hi, im running Camel-K last version over GKE and when I try to use the Telegram Endpoint I'm getting this issue: Caused by: java.lang.IllegalArgumentException: AuthorizationToken must be configured on either component or endpoint for telegram: telegram://bots/ If I run the same code with Spring Boot works like a charm. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #374: chore(deps): remove jetty-client from suport/common
asf-ci commented on issue #374: chore(deps): remove jetty-client from suport/common URL: https://github.com/apache/camel-quarkus/pull/374#issuecomment-549550377 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/382/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] gastaldi commented on issue #373: Upgrade to quarkus 0.28.0
gastaldi commented on issue #373: Upgrade to quarkus 0.28.0 URL: https://github.com/apache/camel-quarkus/pull/373#issuecomment-549479921 Better update to 0.28.1 (it should be available soon) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] gastaldi commented on issue #373: Upgrade to quarkus 0.28.0
gastaldi commented on issue #373: Upgrade to quarkus 0.28.0 URL: https://github.com/apache/camel-quarkus/pull/373#issuecomment-549479646 I can confirm that the integration tests in quarkus-platform pass with this PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli merged pull request #373: Upgrade to quarkus 0.28.0
lburgazzoli merged pull request #373: Upgrade to quarkus 0.28.0 URL: https://github.com/apache/camel-quarkus/pull/373 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #373: Upgrade to quarkus 0.28.0
lburgazzoli commented on issue #373: Upgrade to quarkus 0.28.0 URL: https://github.com/apache/camel-quarkus/pull/373#issuecomment-549512812 @gastaldi I suspect it may be a problem of bom imported in various location This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #374: chore(deps): remove jetty-client from suport/common
lburgazzoli commented on issue #374: chore(deps): remove jetty-client from suport/common URL: https://github.com/apache/camel-quarkus/pull/374#issuecomment-549512198 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli closed issue #372: Upgrade to Quarkus 0.28.1
lburgazzoli closed issue #372: Upgrade to Quarkus 0.28.1 URL: https://github.com/apache/camel-quarkus/issues/372 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli opened a new pull request #367: Add description to extension matedata
lburgazzoli opened a new pull request #367: Add description to extension matedata URL: https://github.com/apache/camel-quarkus/pull/367 Fixes #360 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #367: Add description to extension matedata
lburgazzoli commented on issue #367: Add description to extension matedata URL: https://github.com/apache/camel-quarkus/pull/367#issuecomment-549123227 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli closed issue #347: Add category to extension descriptors
lburgazzoli closed issue #347: Add category to extension descriptors URL: https://github.com/apache/camel-quarkus/issues/347 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #347: Add category to extension descriptors
lburgazzoli commented on issue #347: Add category to extension descriptors URL: https://github.com/apache/camel-quarkus/issues/347#issuecomment-549122205 Done with https://github.com/apache/camel-quarkus/pull/350 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli merged pull request #367: Add description to extension matedata
lburgazzoli merged pull request #367: Add description to extension matedata URL: https://github.com/apache/camel-quarkus/pull/367 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli closed issue #360: Add description to extension matedata
lburgazzoli closed issue #360: Add description to extension matedata URL: https://github.com/apache/camel-quarkus/issues/360 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga opened a new pull request #366: Set camel-quarkus-last-release: 0.3.1 in site.yml
ppalaga opened a new pull request #366: Set camel-quarkus-last-release: 0.3.1 in site.yml URL: https://github.com/apache/camel-quarkus/pull/366 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #367: Add description to extension matedata
asf-ci commented on issue #367: Add description to extension matedata URL: https://github.com/apache/camel-quarkus/pull/367#issuecomment-549130764 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/379/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli merged pull request #366: Set camel-quarkus-last-release: 0.3.1 in site.yml
lburgazzoli merged pull request #366: Set camel-quarkus-last-release: 0.3.1 in site.yml URL: https://github.com/apache/camel-quarkus/pull/366 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #352: Re-enable the FHIR tests once the FHIR testing service is back again
lburgazzoli commented on issue #352: Re-enable the FHIR tests once the FHIR testing service is back again URL: https://github.com/apache/camel-quarkus/issues/352#issuecomment-549122675 May be better to use something like: https://hapifhir.io/doc_server_tester.html This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli closed pull request #368: DO NOT MERGE
lburgazzoli closed pull request #368: DO NOT MERGE URL: https://github.com/apache/camel-quarkus/pull/368 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #143: Create a Camel AMQP extension
lburgazzoli commented on issue #143: Create a Camel AMQP extension URL: https://github.com/apache/camel-quarkus/issues/143#issuecomment-549133527 @zhfeng I' not very sure about the need of wait for https://github.com/quarkusio/quarkus/issues/3436 as camel-jms uses quite a log of Spring API so it may work investigating what alternative options we do have. maybe we can do something similar to camel-sjms but for the amqp protocol. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli edited a comment on issue #143: Create a Camel AMQP extension
lburgazzoli edited a comment on issue #143: Create a Camel AMQP extension URL: https://github.com/apache/camel-quarkus/issues/143#issuecomment-549133527 @zhfeng I' not very sure about the need of wait for https://github.com/quarkusio/quarkus/issues/3436 as camel-jms uses quite a log of Spring API that may end-up not being supported so it may work investigating what alternative options we do have. maybe we can do something similar to camel-sjms but for the amqp protocol. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #369: Use capabilities instead of feature names
lburgazzoli commented on issue #369: Use capabilities instead of feature names URL: https://github.com/apache/camel-quarkus/pull/369#issuecomment-549156019 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #369: Use capabilities instead of feature names
asf-ci commented on issue #369: Use capabilities instead of feature names URL: https://github.com/apache/camel-quarkus/pull/369#issuecomment-549164952 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/380/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli merged pull request #369: Use capabilities instead of feature names
lburgazzoli merged pull request #369: Use capabilities instead of feature names URL: https://github.com/apache/camel-quarkus/pull/369 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #289: Run CI with Java 11
lburgazzoli commented on issue #289: Run CI with Java 11 URL: https://github.com/apache/camel-quarkus/issues/289#issuecomment-549180568 We have not a GitHub Action that builds the project in JVM mode against Java 11 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] zhfeng commented on issue #143: Create a Camel AMQP extension
zhfeng commented on issue #143: Create a Camel AMQP extension URL: https://github.com/apache/camel-quarkus/issues/143#issuecomment-549199908 OK, I will take a look at the camel-sjms This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
lburgazzoli commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders URL: https://github.com/apache/camel-quarkus/pull/358#discussion_r344565753 ## File path: extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java ## @@ -232,7 +228,6 @@ CamelMainBuildItem main( CamelContextBuildItem context, CamelRoutesCollectorBuildItem routesCollector, List listeners, -List routesBuilders, Review comment: Camel has the ability to do class-path scanning to discover routes which can be activated by configuring which packages camel has to scan for `RoutesBuilder` classes (already supported by other platform such as Spring, CDI, Main) so we can mimic that behaviour at build time with a `quarkus.camel.*` option (note that this can activated also right now through camel main properties but class path scanning would happen at runtime). By doing that, routes builders can be added to the context by: - producing a `CamelBeanBuildItem` - using a `MainListener` - using an injected `CamelContext` - using a CDI annotation such as `@ApplicationScoped` - listing the packages to scan for auto discovery (as far as I remember discovered routes have lower precedence than those available from the container thus discarded if the same route class is also provided by the container) An additional option that has been discussed would be to leverage camel's annotation `@BindToRegistry` which would act like a cross platform lite DI. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
lburgazzoli commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders URL: https://github.com/apache/camel-quarkus/pull/358#discussion_r344565753 ## File path: extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java ## @@ -232,7 +228,6 @@ CamelMainBuildItem main( CamelContextBuildItem context, CamelRoutesCollectorBuildItem routesCollector, List listeners, -List routesBuilders, Review comment: Camel has the ability to do class-path scanning to discover routes which can be activated by configuring which packages camel has to scan for `RoutesBuilder` classes (already supported by other platform such as Spring, CDI, Main) so we can mimic that behaviour at build time with a `quarkus.camel.` option (note that this can activated also right now through camel main properties but class path scanning would happen at runtime). By doing that, routes builders can be added to the context by: - producing a `CamelBeanBuildItem` - using a `MainListener` - using a CDI annotation such as `@ApplicationScoped` - listing the packages to scan for auto discovery (as far as I remember discovered routes have lower precedence than those available from the container thus discarded if the same route class is also provided by the container) An additional option that has been discussed would be to leverage camel's annotation `@BindToRegistry` which would act like a cross platform lite DI. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
lburgazzoli commented on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders URL: https://github.com/apache/camel-quarkus/pull/358#issuecomment-551896685 I think we really need to get rid of the double discovery as having two identical builder is confusing and inefficient This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli edited a comment on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
lburgazzoli edited a comment on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders URL: https://github.com/apache/camel-quarkus/pull/358#issuecomment-551896685 I think we really need to get rid of the double discovery as having two identical builder is confusing and inefficient and it is a generic issue that has broader impacts than camel-quarkus This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli opened a new pull request #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner
lburgazzoli opened a new pull request #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner URL: https://github.com/apache/camel-quarkus/pull/392 Fixes #389 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli merged pull request #390: Add SnakeYAML extension
lburgazzoli merged pull request #390: Add SnakeYAML extension URL: https://github.com/apache/camel-quarkus/pull/390 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] davsclaus commented on issue #391: camel-validator component
davsclaus commented on issue #391: camel-validator component URL: https://github.com/apache/camel-quarkus/issues/391#issuecomment-552384606 Just mind you may need to add the new extensions to some pom files in the poms folder. The create extension tool dont get around doing all that 100%. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #390: Add SnakeYAML extension
asf-ci commented on issue #390: Add SnakeYAML extension URL: https://github.com/apache/camel-quarkus/pull/390#issuecomment-552423909 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/385/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner
lburgazzoli commented on issue #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner URL: https://github.com/apache/camel-quarkus/pull/392#issuecomment-552423722 The default type registry does it's own class-path scanning and does not offer an hook for quarkus idiomatic injection of a custom type converter loaders, this PR aims to leverage Quarkus facilities to discover resource files at build time and add an option to inject custom type converter using a build item. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli closed issue #338: Create a Camel SnakeYAML extension
lburgazzoli closed issue #338: Create a Camel SnakeYAML extension URL: https://github.com/apache/camel-quarkus/issues/338 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #390: Add SnakeYAML extension
lburgazzoli commented on issue #390: Add SnakeYAML extension URL: https://github.com/apache/camel-quarkus/pull/390#issuecomment-552378989 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
lburgazzoli commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders URL: https://github.com/apache/camel-quarkus/pull/358#discussion_r344665013 ## File path: extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java ## @@ -232,7 +228,6 @@ CamelMainBuildItem main( CamelContextBuildItem context, CamelRoutesCollectorBuildItem routesCollector, List listeners, -List routesBuilders, Review comment: No CamelBeanBuildItem is - IMHO - the right bean to use as every route bound to the registry is then automatically discovered so CamelRoutesBuilderBuildItem is superfluous. The problem about using ArC in STATIC_INIT is that it may not be aware of the "runtime beans" at that point in time, at least in my experience. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner
lburgazzoli commented on issue #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner URL: https://github.com/apache/camel-quarkus/pull/392#issuecomment-552409366 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #389: [code formatter] multi line TODOs are not supported
ppalaga commented on issue #389: [code formatter] multi line TODOs are not supported URL: https://github.com/apache/camel-quarkus/issues/389#issuecomment-552353847 In Quarkus it works the way you describe and they have the following two settings that might be what we are missing: ``` ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ploef opened a new issue #391: camel-validator component
ploef opened a new issue #391: camel-validator component URL: https://github.com/apache/camel-quarkus/issues/391 Hi, I'm converting some of my Spring Boot services to Quarkus and see that the camel-validation-component is missing. I will try to create an extension for it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
ppalaga commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders URL: https://github.com/apache/camel-quarkus/pull/358#discussion_r344661828 ## File path: extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java ## @@ -232,7 +228,6 @@ CamelMainBuildItem main( CamelContextBuildItem context, CamelRoutesCollectorBuildItem routesCollector, List listeners, -List routesBuilders, Review comment: Yes, I agree. You perhaps meant CamelRoutesBuilderBuildItem rather than CamelBeanBuildItem? The ultimate aim of this PR is to make the `@Inject`, `@ConfigProperty`, etc. work in RoutesBuilders (see the tests in this PR that currently fail). I agree that the problem of double Route initialization is actually the root cause. My previous proposal to solve both problems by delegating the creation of all RouteBuilders to Arc was rejected for boot performance reasons which I found quite legitimate. I proposed an alternative approach where Arc beans are thrown away from the list provided via CamelRoutesBuilderBuildItem, but I see no feedback for that. In between, I looked how to implement that reliably, and found that the list of Arc beans could perhaps be pulled from Arc itself like this: https://github.com/ppalaga/camel-quarkus/commit/cdbfd1999b35e103944d41e570d266d73fd20995#diff-ec6205752018e84a80fcd9eaa92af189R203-R209 (once they change the visibility of some methods, I asked the Arc guys about that). What do you think about the linked solution? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
lburgazzoli commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders URL: https://github.com/apache/camel-quarkus/pull/358#discussion_r344665013 ## File path: extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java ## @@ -232,7 +228,6 @@ CamelMainBuildItem main( CamelContextBuildItem context, CamelRoutesCollectorBuildItem routesCollector, List listeners, -List routesBuilders, Review comment: No CamelBeanBuildItem is - IMHO - the right bean to use as every route bound to the registry is then automatically discovered so CamelRoutesBuilderBuildItem is superfluous but that is a minor issue. The problem about using ArC in STATIC_INIT is that it may not be aware of the "runtime beans" at that point in time, at least in my experience. You may think to override the route discovery class and apply the filter there. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner
lburgazzoli commented on a change in pull request #392: Perform
TypeConverterLoader discovery using jandex instead of camel's class path scanner
URL: https://github.com/apache/camel-quarkus/pull/392#discussion_r344684441
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelSupport.java
##
@@ -87,6 +88,14 @@ public static boolean isPublic(ClassInfo ci) {
.map(ClassInfo::toString);
}
+public static CamelBeanBuildItem createBeanFromType(RecorderContext
context, String type) {
+return new CamelBeanBuildItem(type, context.classProxy(type),
context.newInstance(type));
+}
+
+public static CamelBeanBuildItem createBeanFromType(RecorderContext
context, ClassInfo info) {
+return createBeanFromType(context, info.name().toString());
+}
+
Review comment:
they are leftover, let me remove them
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ploef opened a new pull request #393: added Camel validation extension
ploef opened a new pull request #393: added Camel validation extension URL: https://github.com/apache/camel-quarkus/pull/393 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton opened a new pull request #390: Add SnakeYAML extension
jamesnetherton opened a new pull request #390: Add SnakeYAML extension URL: https://github.com/apache/camel-quarkus/pull/390 fixes #338 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
lburgazzoli commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders URL: https://github.com/apache/camel-quarkus/pull/358#discussion_r344665013 ## File path: extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java ## @@ -232,7 +228,6 @@ CamelMainBuildItem main( CamelContextBuildItem context, CamelRoutesCollectorBuildItem routesCollector, List listeners, -List routesBuilders, Review comment: No CamelBeanBuildItem is - IMHO - the right bean to use as every route bound to the registry is then automatically discovered so CamelRoutesBuilderBuildItem is superfluous but that is a minor issue. The problem about using ArC in STATIC_INIT is that it may not be aware of the "runtime beans" at that point in time, at least in my experience. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner
ppalaga commented on a change in pull request #392: Perform TypeConverterLoader
discovery using jandex instead of camel's class path scanner
URL: https://github.com/apache/camel-quarkus/pull/392#discussion_r344679240
##
File path:
extensions/core/runtime/src/main/java/org/apache/camel/quarkus/core/FastTypeConverter.java
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.core;
+
+import org.apache.camel.impl.converter.DefaultTypeConverter;
+import org.apache.camel.spi.TypeConverterLoader;
+
+public class FastTypeConverter extends DefaultTypeConverter {
+public FastTypeConverter() {
+super(null, null, null, null, false);
+}
+
+@Override
+protected void doStart() throws Exception {
+for (TypeConverterLoader loader :
getCamelContext().getRegistry().findByType(TypeConverterLoader.class)) {
+log.debug("TypeConverterLoader: {} loading converters", loader);
+loader.load(this);
+}
+}
+
+@Override
+public void loadCoreAndFastTypeConverters() throws Exception {
+throw new IllegalStateException("This method should not be invoked");
Review comment:
The message is not useful unless it gives a hint why it should not be
invoked.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner
ppalaga commented on a change in pull request #392: Perform TypeConverterLoader
discovery using jandex instead of camel's class path scanner
URL: https://github.com/apache/camel-quarkus/pull/392#discussion_r344677133
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelSupport.java
##
@@ -87,6 +88,14 @@ public static boolean isPublic(ClassInfo ci) {
.map(ClassInfo::toString);
}
+public static CamelBeanBuildItem createBeanFromType(RecorderContext
context, String type) {
+return new CamelBeanBuildItem(type, context.classProxy(type),
context.newInstance(type));
+}
+
+public static CamelBeanBuildItem createBeanFromType(RecorderContext
context, ClassInfo info) {
+return createBeanFromType(context, info.name().toString());
+}
+
Review comment:
I do not see any of these methods used anywhere. Are you sure we need them?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli opened a new issue #389: [code formatter] multi line TODOs are not supported
lburgazzoli opened a new issue #389: [code formatter] multi line TODOs are not supported URL: https://github.com/apache/camel-quarkus/issues/389 Assuming I have a TODO like: ```java // TODO: blablabla // blablabla ``` This is then re-formatted as: ```java // TODO: blablabla // blablabla ``` Which loses IDE support This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #391: camel-validator component
ppalaga commented on issue #391: camel-validator component URL: https://github.com/apache/camel-quarkus/issues/391#issuecomment-552383469 Nice to hear that! Do not hesitate to ask here if you have specific questions. You might want to check https://camel.apache.org/camel-quarkus/latest/contributor-guide.html This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
lburgazzoli commented on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders URL: https://github.com/apache/camel-quarkus/pull/358#issuecomment-552000542 does this means that route builder classes are now instantiated at runtime only ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
ppalaga commented on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders URL: https://github.com/apache/camel-quarkus/pull/358#issuecomment-552003860 > does this means that route builder classes are now instantiated at runtime only ? Yes, the constructors are called from main() not from a clinit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
lburgazzoli commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders URL: https://github.com/apache/camel-quarkus/pull/358#discussion_r344382003 ## File path: extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java ## @@ -232,7 +228,6 @@ CamelMainBuildItem main( CamelContextBuildItem context, CamelRoutesCollectorBuildItem routesCollector, List listeners, -List routesBuilders, Review comment: I should be able to add routes that are instantiated at build time, i.e. if I use camel annotation for DI I do not need ArC at all thus I can optimize a bit my application. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
lburgazzoli commented on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders URL: https://github.com/apache/camel-quarkus/pull/358#issuecomment-552005268 This is IMHO bad as we are de optimizing the app This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
ppalaga commented on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders URL: https://github.com/apache/camel-quarkus/pull/358#issuecomment-551999282 b14487b is the most elegant fix I was able to find. All RoutesBuilders are instantiated by Arc and queried via the Registry. CamelRoutesBuilderBuildItem removed altogether. Not a WiP anymore. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] davsclaus closed issue #386: @Inject CamelContext on RouteBuilder seems not working
davsclaus closed issue #386: @Inject CamelContext on RouteBuilder seems not working URL: https://github.com/apache/camel-quarkus/issues/386 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] davsclaus commented on issue #386: @Inject CamelContext on RouteBuilder seems not working
davsclaus commented on issue #386: @Inject CamelContext on RouteBuilder seems not working URL: https://github.com/apache/camel-quarkus/issues/386#issuecomment-551997566 See ticket #136 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] davsclaus closed issue #384: camel-quarkus-microprofile-metrics - Does not work
davsclaus closed issue #384: camel-quarkus-microprofile-metrics - Does not work URL: https://github.com/apache/camel-quarkus/issues/384 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
ppalaga commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders URL: https://github.com/apache/camel-quarkus/pull/358#discussion_r344385789 ## File path: extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java ## @@ -232,7 +228,6 @@ CamelMainBuildItem main( CamelContextBuildItem context, CamelRoutesCollectorBuildItem routesCollector, List listeners, -List routesBuilders, Review comment: That would re-introduce the double initialization of the routes. I was thinking of filtering by `@ApplicationScoped` that can be done well using Jandex: Builders having `@ApplicationScoped` would behave like in the current proposal and all others could go via `CamelRoutesBuilderBuildItem`. This would be more complex and thus potentially more buggy and harder to maintain. Maybe you have a better idea? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] davsclaus commented on issue #384: camel-quarkus-microprofile-metrics - Does not work
davsclaus commented on issue #384: camel-quarkus-microprofile-metrics - Does not work URL: https://github.com/apache/camel-quarkus/issues/384#issuecomment-551997208 See ticket #319 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner
asf-ci commented on issue #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner URL: https://github.com/apache/camel-quarkus/pull/392#issuecomment-552460424 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/386/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
