[GitHub] [camel-website] zregvart commented on pull request #386: chore: remove the width toggle

2020-06-10 Thread GitBox


zregvart commented on pull request #386:
URL: https://github.com/apache/camel-website/pull/386#issuecomment-642208329


   I'm going to wait for #383 to get merged and then rebase this on top.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [camel-website] zregvart commented on pull request #386: chore: remove the width toggle

2020-06-09 Thread GitBox


zregvart commented on pull request #386:
URL: https://github.com/apache/camel-website/pull/386#issuecomment-640785335


   @aashnajena @AemieJ nice catch, thanks! I wasn't really testing this, I've 
made a change in 1bc995a77936490e6b51386a115ac7a4883aa15f to base the width on 
1366px (~76rem). It's not really targeting 1366px screens as we have navigation 
pane on the left (and soon on the right), but it leaves some margins on the 
left and right. The base was 720px (46rem) to me seems too narrow for the 
tables in the component reference.
   
   Please have a look at the preview and share your feedback.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org