Re: [PR] Annotate BatchStatement methods with CheckReturnValue [cassandra-java-driver]

2024-05-25 Thread via GitHub
akhaku commented on PR #1607: URL: https://github.com/apache/cassandra-java-driver/pull/1607#issuecomment-2132044855 Sure, done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Annotate BatchStatement methods with CheckReturnValue [cassandra-java-driver]

2024-05-21 Thread via GitHub
lukasz-antoniak commented on PR #1607: URL: https://github.com/apache/cassandra-java-driver/pull/1607#issuecomment-2122499865 Shall we also add `@CheckReturnValue` to `Statement#setNowInSeconds(int)`? All Implementations are immutable and create new object. ```java @NonNull @Su

Re: [PR] Annotate BatchStatement methods with CheckReturnValue [cassandra-java-driver]

2024-03-13 Thread via GitHub
akhaku commented on PR #1607: URL: https://github.com/apache/cassandra-java-driver/pull/1607#issuecomment-1995596202 Thanks for the approval! Rebased to fix the merge conflict, please merge when ready. -- This is an automated message from the Apache Git Service. To respond to the message