[
https://issues.apache.org/jira/browse/CASSANDRA-19193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830416#comment-17830416
]
Alex Petrov edited comment on CASSANDRA-19193 at 3/25/24 9:50 AM:
------------------------------------------------------------------
+1, new test looks great!
very small nit: for consistency, maybe rename {{movingNode}} to {{toMove}} and
{{joiningNode}} to {{toJoin}}? Or the other two ({{toReplace}} and {{toLeave}})
to {{replacedNode}} and {{leavingNode}}. Either way.
was (Author: ifesdjeen):
+1, new test looks great!
> Reimplement ClusterMetadata::writePlacementAllSettled
> -----------------------------------------------------
>
> Key: CASSANDRA-19193
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19193
> Project: Cassandra
> Issue Type: Improvement
> Components: Transactional Cluster Metadata
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Normal
> Fix For: 5.1-alpha1
>
> Attachments: ci_summary.html, result_details.tar.gz
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This should step through InProgressSequences to determine state when
> finished, rather than emulating the logic inline.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
