[ https://issues.apache.org/jira/browse/CASSANDRA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14999294#comment-14999294 ]
Ariel Weisberg edited comment on CASSANDRA-9800 at 11/10/15 8:30 PM: --------------------------------------------------------------------- There were some warnings in 3.0 and trunk so I created a 3.0 branch as well |[2.2 code|https://github.com/apache/cassandra/compare/cassandra-2.2...aweisberg:CASSANDRA-9800-2.2?expand=1]|[utests|http://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-9800-2.2-testall/]|[dtests|http://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-9800-2.2-dtest/]| |[3.0 code|https://github.com/apache/cassandra/compare/cassandra-3.0...aweisberg:CASSANDRA-9800-3.0?expand=1]|[utests|http://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-9800-3.0-testall/]|[dtests|http://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-9800-3.0-dtest/]| was (Author: aweisberg): There were some warnings in 3.0 and trunk as well so I created a 3.0 branch as well |[2.2 code|https://github.com/apache/cassandra/compare/cassandra-2.2...aweisberg:CASSANDRA-9800-2.2?expand=1]|[utests|http://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-9800-2.2-testall/]|[dtests|http://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-9800-2.2-dtest/]| |[3.0 code|https://github.com/apache/cassandra/compare/cassandra-3.0...aweisberg:CASSANDRA-9800-3.0?expand=1]|[utests|http://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-9800-3.0-testall/]|[dtests|http://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-9800-3.0-dtest/]| > 2.2 eclipse-warnings > -------------------- > > Key: CASSANDRA-9800 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9800 > Project: Cassandra > Issue Type: Bug > Reporter: Michael Shuler > Assignee: Ariel Weisberg > Fix For: 2.2.x > > > commit 052222615a754e5bbb5299d51470a2ccdb70a5b0 > Date: Mon Jul 13 17:53:42 2015 -0400 > If you wish to look at the latest output, check the > {{eclipse_compiler_checks.txt}} artifact saved on the latest build: > http://cassci.datastax.com/job/cassandra-2.2_eclipse-warnings/lastBuild/ > Output of current 2.2 HEAD eclipse-warnings: > {noformat} > # 7/14/15 12:21:30 AM UTC > # Eclipse Compiler for Java(TM) v20150120-1634, 3.10.2, Copyright IBM Corp > 2000, 2013. All rights reserved. > incorrect classpath: > /mnt/data/jenkins/workspace/cassandra-2.2_eclipse-warnings/build/cobertura/classes > ---------- > 1. ERROR in > /mnt/data/jenkins/workspace/cassandra-2.2_eclipse-warnings/src/java/org/apache/cassandra/tools/SSTableExport.java > (at line 315) > ISSTableScanner scanner = reader.getScanner(); > ^^^^^^^ > Resource 'scanner' should be managed by try-with-resource > ---------- > ---------- > 2. ERROR in > /mnt/data/jenkins/workspace/cassandra-2.2_eclipse-warnings/src/java/org/apache/cassandra/db/compaction/LeveledCompactionStrategy.java > (at line 247) > scanners.add(new LeveledScanner(intersecting, range)); > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > Potential resource leak: '<unassigned Closeable value>' may not be closed > ---------- > ---------- > 3. ERROR in > /mnt/data/jenkins/workspace/cassandra-2.2_eclipse-warnings/src/java/org/apache/cassandra/db/compaction/CompactionManager.java > (at line 819) > ISSTableScanner scanner = cleanupStrategy.getScanner(sstable, > getRateLimiter()); > ^^^^^^^ > Resource 'scanner' should be managed by try-with-resource > ---------- > ---------- > 4. ERROR in > /mnt/data/jenkins/workspace/cassandra-2.2_eclipse-warnings/src/java/org/apache/cassandra/db/WindowsFailedSnapshotTracker.java > (at line 55) > BufferedReader reader = new BufferedReader(new > FileReader(TODELETEFILE)); > ^^^^^^ > Resource 'reader' should be managed by try-with-resource > ---------- > 5. ERROR in > /mnt/data/jenkins/workspace/cassandra-2.2_eclipse-warnings/src/java/org/apache/cassandra/db/WindowsFailedSnapshotTracker.java > (at line 55) > BufferedReader reader = new BufferedReader(new > FileReader(TODELETEFILE)); > ^^^^^^ > Resource 'reader' should be managed by try-with-resource > ---------- > ---------- > 6. ERROR in > /mnt/data/jenkins/workspace/cassandra-2.2_eclipse-warnings/src/java/org/apache/cassandra/io/util/SegmentedFile.java > (at line 183) > ChannelProxy channelCopy = getChannel(path); > ^^^^^^^^^^^ > Resource 'channelCopy' should be managed by try-with-resource > ---------- > 7. ERROR in > /mnt/data/jenkins/workspace/cassandra-2.2_eclipse-warnings/src/java/org/apache/cassandra/io/util/SegmentedFile.java > (at line 186) > return complete(channelCopy, overrideLength); > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > Potential resource leak: 'channelCopy' may not be closed at this location > ---------- > 7 problems (7 errors) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)