[jira] [Commented] (CASSANDRA-15373) validate value sizes in LegacyLayout

2019-11-11 Thread Benedict Elliott Smith (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971559#comment-16971559 ] Benedict Elliott Smith commented on CASSANDRA-15373: So, while it might make

[jira] [Commented] (CASSANDRA-15373) validate value sizes in LegacyLayout

2019-11-11 Thread Benedict Elliott Smith (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971558#comment-16971558 ] Benedict Elliott Smith commented on CASSANDRA-15373: So, while it might make

[jira] [Commented] (CASSANDRA-15373) validate value sizes in LegacyLayout

2019-11-11 Thread Alex Petrov (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971375#comment-16971375 ] Alex Petrov commented on CASSANDRA-15373: - I've noticed that the patch uses

[jira] [Commented] (CASSANDRA-15373) validate value sizes in LegacyLayout

2019-10-28 Thread Blake Eggleston (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961319#comment-16961319 ] Blake Eggleston commented on CASSANDRA-15373: - fixed, also made a small adjustment to

[jira] [Commented] (CASSANDRA-15373) validate value sizes in LegacyLayout

2019-10-28 Thread Sam Tunnicliffe (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961237#comment-16961237 ] Sam Tunnicliffe commented on CASSANDRA-15373: - +1 from me too - you just need to fix the

[jira] [Commented] (CASSANDRA-15373) validate value sizes in LegacyLayout

2019-10-28 Thread Blake Eggleston (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961190#comment-16961190 ] Blake Eggleston commented on CASSANDRA-15373: - good catch, fixed > validate value sizes

[jira] [Commented] (CASSANDRA-15373) validate value sizes in LegacyLayout

2019-10-28 Thread Benedict Elliott Smith (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961057#comment-16961057 ] Benedict Elliott Smith commented on CASSANDRA-15373: I think there's one

[jira] [Commented] (CASSANDRA-15373) validate value sizes in LegacyLayout

2019-10-25 Thread Blake Eggleston (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959940#comment-16959940 ] Blake Eggleston commented on CASSANDRA-15373: - thanks, pushed up updated branches >

[jira] [Commented] (CASSANDRA-15373) validate value sizes in LegacyLayout

2019-10-25 Thread Sam Tunnicliffe (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959815#comment-16959815 ] Sam Tunnicliffe commented on CASSANDRA-15373: - LGTM, with 2 minor comments: * In

[jira] [Commented] (CASSANDRA-15373) validate value sizes in LegacyLayout

2019-10-24 Thread Blake Eggleston (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959009#comment-16959009 ] Blake Eggleston commented on CASSANDRA-15373: - thanks, added checks to both methods >

[jira] [Commented] (CASSANDRA-15373) validate value sizes in LegacyLayout

2019-10-24 Thread Benedict Elliott Smith (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958789#comment-16958789 ] Benedict Elliott Smith commented on CASSANDRA-15373: Patch looks good, only